[RFC v1 00/14] Add some mt7988 DTS labels and new nodes

[RFC v1 00/14] Add some mt7988 DTS labels and new nodes

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

This series adds some missing labels and new nodes to mt7988 DTS.

If wanted i can squash the coommits adding labels to have less patches,
but for first review i let them separate.

Frank Wunderlich (14):
  arm64: dts: mediatek: mt7988: add missing label for apmixedsys
  arm64: dts: mediatek: mt7988: add labels for i2c nodes
  arm64: dts: mediatek: mt7988: add labels for usb nodes
  arm64: dts: mediatek: mt7988: add serial labels
  arm64: dts: mediatek: mt7988: add label for pwm node
  arm64: dts: mediatek: mt7988: add label for efuse
  arm64: dts: mediatek: mt7988: add mmc support
  arm64: dts: mediatek: mt7988: add fixed regulators for 1v8 and 3v3
  arm64: dts: mediatek: mt7988: extend efuse node
  arm64: dts: mediatek: mt7988: add lvts node
  arm64: dts: mediatek: mt7988: add thermal-zone
  arm64: dts: mediatek: mt7988: add reserved memory
  arm64: dts: mediatek: mt7988: add mcu-sys node for cpu
  arm64: dts: mediatek: mt7988: add operating-points

 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 196 ++++++++++++++++++++--
 1 file changed, 181 insertions(+), 15 deletions(-)

-- 
2.43.0

[RFC v1 01/14] arm64: dts: mediatek: mt7988: add missing label for apmixedsys

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Label to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 46969577c87a..5b93c2c843e0 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -100,7 +100,7 @@ watchdog: watchdog@1001c000 {
 			#reset-cells = <1>;
 		};
 
-		clock-controller@1001e000 {
+		apmixedsys: clock-controller@1001e000 {
 			compatible = "mediatek,mt7988-apmixedsys";
 			reg = <0 0x1001e000 0 0x1000>;
 			#clock-cells = <1>;
-- 
2.43.0

Re: [RFC v1 01/14] arm64: dts: mediatek: mt7988: add missing label for apmixedsys

[AngeloGioacchino Del Regno]

Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add Label to allow easier referencing in dtsi and board dts.

Please add the necessary label(s) along with the addition of their users.

Don't just add them randomly like this "for later" without any valid justification
(where a justified addition is one that shows that you're adding the label and
that you're using it somewhere!)

Thanks,
Angelo

[RFC v1 02/14] arm64: dts: mediatek: mt7988: add labels for i2c nodes

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Labels to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 5b93c2c843e0..0aa789da5592 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -211,7 +211,7 @@ serial@11000200 {
 			status = "disabled";
 		};
 
-		i2c@11003000 {
+		i2c0: i2c@11003000 {
 			compatible = "mediatek,mt7981-i2c";
 			reg = <0 0x11003000 0 0x1000>,
 			      <0 0x10217080 0 0x80>;
@@ -224,7 +224,7 @@ i2c@11003000 {
 			status = "disabled";
 		};
 
-		i2c@11004000 {
+		i2c1: i2c@11004000 {
 			compatible = "mediatek,mt7981-i2c";
 			reg = <0 0x11004000 0 0x1000>,
 			      <0 0x10217100 0 0x80>;
@@ -237,7 +237,7 @@ i2c@11004000 {
 			status = "disabled";
 		};
 
-		i2c@11005000 {
+		i2c2: i2c@11005000 {
 			compatible = "mediatek,mt7981-i2c";
 			reg = <0 0x11005000 0 0x1000>,
 			      <0 0x10217180 0 0x80>;
-- 
2.43.0

[RFC v1 03/14] arm64: dts: mediatek: mt7988: add labels for usb nodes

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Labels to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 0aa789da5592..6d2ea317f9b2 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -250,7 +250,7 @@ i2c2: i2c@11005000 {
 			status = "disabled";
 		};
 
-		usb@11190000 {
+		ssusb0: usb@11190000 {
 			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
 			reg = <0 0x11190000 0 0x2e00>,
 			      <0 0x11193e00 0 0x0100>;
@@ -264,7 +264,7 @@ usb@11190000 {
 			clock-names = "sys_ck", "ref_ck", "mcu_ck", "dma_ck", "xhci_ck";
 		};
 
-		usb@11200000 {
+		ssusb1: usb@11200000 {
 			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
 			reg = <0 0x11200000 0 0x2e00>,
 			      <0 0x11203e00 0 0x0100>;
-- 
2.43.0

[RFC v1 04/14] arm64: dts: mediatek: mt7988: add serial labels

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Labels to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 6d2ea317f9b2..e5e7951b24f8 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -178,7 +178,7 @@ pwm@10048000 {
 			status = "disabled";
 		};
 
-		serial@11000000 {
+		serial0: serial@11000000 {
 			compatible = "mediatek,mt7988-uart", "mediatek,mt6577-uart";
 			reg = <0 0x11000000 0 0x100>;
 			interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
@@ -189,7 +189,7 @@ serial@11000000 {
 			status = "disabled";
 		};
 
-		serial@11000100 {
+		serial1: serial@11000100 {
 			compatible = "mediatek,mt7988-uart", "mediatek,mt6577-uart";
 			reg = <0 0x11000100 0 0x100>;
 			interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>;
@@ -200,7 +200,7 @@ serial@11000100 {
 			status = "disabled";
 		};
 
-		serial@11000200 {
+		serial2: serial@11000200 {
 			compatible = "mediatek,mt7988-uart", "mediatek,mt6577-uart";
 			reg = <0 0x11000200 0 0x100>;
 			interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.43.0

[RFC v1 05/14] arm64: dts: mediatek: mt7988: add label for pwm node

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Label to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index e5e7951b24f8..0425aec8dacb 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -159,7 +159,7 @@ mux {
 			};
 		};
 
-		pwm@10048000 {
+		pwm: pwm@10048000 {
 			compatible = "mediatek,mt7988-pwm";
 			reg = <0 0x10048000 0 0x1000>;
 			clocks = <&infracfg CLK_INFRA_66M_PWM_BCK>,
-- 
2.43.0

[RFC v1 06/14] arm64: dts: mediatek: mt7988: add label for efuse

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Label to allow easier referencing in dtsi and board dts.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 0425aec8dacb..777067b326b2 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -285,7 +285,7 @@ clock-controller@11f40000 {
 			#clock-cells = <1>;
 		};
 
-		efuse@11f50000 {
+		efuse: efuse@11f50000 {
 			compatible = "mediatek,mt7988-efuse", "mediatek,efuse";
 			reg = <0 0x11f50000 0 0x1000>;
 			#address-cells = <1>;
-- 
2.43.0

[RFC v1 07/14] arm64: dts: mediatek: mt7988: add mmc support

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add devicetree node for MMC controller.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 777067b326b2..639c307b9984 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -278,6 +278,28 @@ ssusb1: usb@11200000 {
 			clock-names = "sys_ck", "ref_ck", "mcu_ck", "dma_ck", "xhci_ck";
 		};
 
+		mmc0: mmc@11230000 {
+			compatible = "mediatek,mt7988-mmc";
+			reg = <0 0x11230000 0 0x1000>,
+			      <0 0x11D60000 0 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&infracfg CLK_INFRA_MSDC400>,
+				 <&infracfg CLK_INFRA_MSDC2_HCK>,
+				 <&infracfg CLK_INFRA_66M_MSDC_0_HCK>,
+				 <&infracfg CLK_INFRA_133M_MSDC_0_HCK>;
+			assigned-clocks = <&topckgen CLK_TOP_EMMC_250M_SEL>,
+					  <&topckgen CLK_TOP_EMMC_400M_SEL>;
+			assigned-clock-parents = <&topckgen CLK_TOP_NET1PLL_D5_D2>,
+						 <&apmixedsys CLK_APMIXED_MSDCPLL>;
+			clock-names = "source",
+				      "hclk",
+				      "axi_cg",
+				      "ahb_cg";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		clock-controller@11f40000 {
 			compatible = "mediatek,mt7988-xfi-pll";
 			reg = <0 0x11f40000 0 0x1000>;
-- 
2.43.0

[RFC v1 08/14] arm64: dts: mediatek: mt7988: add fixed regulators for 1v8 and 3v3

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add regulator nodes used for mmc.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 639c307b9984..7371cd80a4ff 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -62,6 +62,24 @@ psci {
 		method = "smc";
 	};
 
+	reg_1p8v: regulator-1p8v {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-1.8V";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
 	soc {
 		compatible = "simple-bus";
 		ranges;
-- 
2.43.0

Re: [RFC v1 08/14] arm64: dts: mediatek: mt7988: add fixed regulators for 1v8 and 3v3

[AngeloGioacchino Del Regno]

Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add regulator nodes used for mmc.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

That's a board specific thing, not a SoC one; please add it to your board dts
instead.

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index 639c307b9984..7371cd80a4ff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -62,6 +62,24 @@ psci {
>   		method = "smc";
>   	};
>   
> +	reg_1p8v: regulator-1p8v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "fixed-1.8V";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +
> +	reg_3p3v: regulator-3p3v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "fixed-3.3V";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +
>   	soc {
>   		compatible = "simple-bus";
>   		ranges;

[RFC v1 09/14] arm64: dts: mediatek: mt7988: extend efuse node

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add subnodes for efuse containing calibration data for lvts and phys.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 7371cd80a4ff..ed8ce1e6f68b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -330,6 +330,25 @@ efuse: efuse@11f50000 {
 			reg = <0 0x11f50000 0 0x1000>;
 			#address-cells = <1>;
 			#size-cells = <1>;
+
+			cpufreq_calibration: calib@278 {
+				reg = <0x278 0x1>;
+			};
+			lvts_calibration: calib@918 {
+				reg = <0x918 0x28>;
+			};
+			phy_calibration_p0: calib@940 {
+				reg = <0x940 0x10>;
+			};
+			phy_calibration_p1: calib@954 {
+				reg = <0x954 0x10>;
+			};
+			phy_calibration_p2: calib@968 {
+				reg = <0x968 0x10>;
+			};
+			phy_calibration_p3: calib@97c {
+				reg = <0x97c 0x10>;
+			};
 		};
 
 		clock-controller@15000000 {
-- 
2.43.0

[RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index ed8ce1e6f68b..de9a9ff2edd8 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -4,6 +4,7 @@
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/phy/phy.h>
 #include <dt-bindings/pinctrl/mt65xx.h>
+#include <dt-bindings/reset/mediatek,mt7988-resets.h>
 
 / {
 	compatible = "mediatek,mt7988a";
@@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
 			compatible = "mediatek,mt7988-infracfg", "syscon";
 			reg = <0 0x10001000 0 0x1000>;
 			#clock-cells = <1>;
+			#reset-cells = <1>;
 		};
 
 		topckgen: clock-controller@1001b000 {
@@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
 			status = "disabled";
 		};
 
+		lvts: lvts@1100a000 {
+			compatible = "mediatek,mt7988-lvts-ap";
+			#thermal-sensor-cells = <1>;
+			reg = <0 0x1100a000 0 0x1000>;
+			clocks = <&infracfg CLK_INFRA_26M_THERM_SYSTEM>;
+			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
+			resets = <&infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST>;
+			nvmem-cells = <&lvts_calibration>;
+			nvmem-cell-names = "lvts-calib-data-1";
+		};
+
 		ssusb0: usb@11190000 {
 			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
 			reg = <0 0x11190000 0 0x2e00>,
-- 
2.43.0

Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node

[AngeloGioacchino Del Regno]

Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Please add the lvts_calibration nvmem entry in this commit instead.

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index ed8ce1e6f68b..de9a9ff2edd8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -4,6 +4,7 @@
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/phy/phy.h>
>   #include <dt-bindings/pinctrl/mt65xx.h>
> +#include <dt-bindings/reset/mediatek,mt7988-resets.h>
>   
>   / {
>   	compatible = "mediatek,mt7988a";
> @@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
>   			compatible = "mediatek,mt7988-infracfg", "syscon";
>   			reg = <0 0x10001000 0 0x1000>;
>   			#clock-cells = <1>;
> +			#reset-cells = <1>;
>   		};
>   
>   		topckgen: clock-controller@1001b000 {
> @@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
>   			status = "disabled";
>   		};
>   
> +		lvts: lvts@1100a000 {
> +			compatible = "mediatek,mt7988-lvts-ap";
> +			#thermal-sensor-cells = <1>;
> +			reg = <0 0x1100a000 0 0x1000>;
> +			clocks = <&infracfg CLK_INFRA_26M_THERM_SYSTEM>;
> +			interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>;
> +			resets = <&infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST>;
> +			nvmem-cells = <&lvts_calibration>;
> +			nvmem-cell-names = "lvts-calib-data-1";
> +		};
> +
>   		ssusb0: usb@11190000 {
>   			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
>   			reg = <0 0x11190000 0 0x2e00>,

Aw: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node

[Frank Wunderlich]

> Gesendet: Mittwoch, 27. November 2024 um 14:34
&gt; Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
&gt; An: "Frank Wunderlich" <linux@fw-web.de>, "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>
&gt; CC: "Frank Wunderlich" <frank-w@public-files.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
&gt; Betreff: Re: [RFC v1 10/14] arm64: dts: mediatek: mt7988: add lvts node
&gt;
&gt; Il 29/10/24 11:39, Frank Wunderlich ha scritto:
&gt; &gt; From: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt;
&gt; &gt; Add Low Voltage Thermal Sensor (LVTS) node for mt7988 SoC.
&gt; &gt;
&gt; &gt; Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
&gt;
&gt; Please add the lvts_calibration nvmem entry in this commit instead.

and leaving the other (currently not linked) subnodes?

&gt; Cheers,
&gt; Angelo
&gt;
&gt; &gt; ---
&gt; &gt;   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 13 +++++++++++++
&gt; &gt;   1 file changed, 13 insertions(+)
&gt; &gt;
&gt; &gt; diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; index ed8ce1e6f68b..de9a9ff2edd8 100644
&gt; &gt; --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; @@ -4,6 +4,7 @@
&gt; &gt;   #include <dt-bindings interrupt-controller="" arm-gic.h="">
&gt; &gt;   #include <dt-bindings phy="" phy.h="">
&gt; &gt;   #include <dt-bindings pinctrl="" mt65xx.h="">
&gt; &gt; +#include <dt-bindings reset="" mediatek,mt7988-resets.h="">
&gt; &gt;
&gt; &gt;   / {
&gt; &gt;   	compatible = "mediatek,mt7988a";
&gt; &gt; @@ -103,6 +104,7 @@ infracfg: clock-controller@10001000 {
&gt; &gt;   			compatible = "mediatek,mt7988-infracfg", "syscon";
&gt; &gt;   			reg = &lt;0 0x10001000 0 0x1000&gt;;
&gt; &gt;   			#clock-cells = &lt;1&gt;;
&gt; &gt; +			#reset-cells = &lt;1&gt;;
&gt; &gt;   		};
&gt; &gt;
&gt; &gt;   		topckgen: clock-controller@1001b000 {
&gt; &gt; @@ -268,6 +270,17 @@ i2c2: i2c@11005000 {
&gt; &gt;   			status = "disabled";
&gt; &gt;   		};
&gt; &gt;
&gt; &gt; +		lvts: lvts@1100a000 {
&gt; &gt; +			compatible = "mediatek,mt7988-lvts-ap";
&gt; &gt; +			#thermal-sensor-cells = &lt;1&gt;;
&gt; &gt; +			reg = &lt;0 0x1100a000 0 0x1000&gt;;
&gt; &gt; +			clocks = &lt;&amp;infracfg CLK_INFRA_26M_THERM_SYSTEM&gt;;
&gt; &gt; +			interrupts = <gic_spi 138="" irq_type_level_high="">;
&gt; &gt; +			resets = &lt;&amp;infracfg MT7988_INFRA_RST1_THERM_CTRL_SWRST&gt;;
&gt; &gt; +			nvmem-cells = &lt;&amp;lvts_calibration&gt;;
&gt; &gt; +			nvmem-cell-names = "lvts-calib-data-1";
&gt; &gt; +		};
&gt; &gt; +
&gt; &gt;   		ssusb0: usb@11190000 {
&gt; &gt;   			compatible = "mediatek,mt7988-xhci", "mediatek,mtk-xhci";
&gt; &gt;   			reg = &lt;0 0x11190000 0 0x2e00&gt;,
&gt;
&gt; </gic_spi></dt-bindings></dt-bindings></dt-bindings></dt-bindings></frank-w@public-files.de></frank-w@public-files.de></frank-w@public-files.de></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></robh@kernel.org></linux@fw-web.de></angelogioacchino.delregno@collabora.com>

[RFC v1 11/14] arm64: dts: mediatek: mt7988: add thermal-zone

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add basic thermal-zone node.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 39 +++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index de9a9ff2edd8..a3a7deda35a5 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -379,6 +379,45 @@ clock-controller@15031000 {
 		};
 	};
 
+	thermal-zones {
+		cpu_thermal: cpu-thermal {
+			polling-delay-passive = <1000>;
+			polling-delay = <1000>;
+			thermal-sensors = <&lvts 0>;
+			trips {
+				cpu_trip_crit: crit {
+					temperature = <125000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+
+				cpu_trip_hot: hot {
+					temperature = <120000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+
+				cpu_trip_active_high: active-high {
+					temperature = <115000>;
+					hysteresis = <2000>;
+					type = "active";
+				};
+
+				cpu_trip_active_med: active-med {
+					temperature = <85000>;
+					hysteresis = <2000>;
+					type = "active";
+				};
+
+				cpu_trip_active_low: active-low {
+					temperature = <40000>;
+					hysteresis = <2000>;
+					type = "active";
+				};
+			};
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupt-parent = <&gic>;
-- 
2.43.0

Re: [RFC v1 11/14] arm64: dts: mediatek: mt7988: add thermal-zone

[AngeloGioacchino Del Regno]

Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add basic thermal-zone node.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 39 +++++++++++++++++++++++
>   1 file changed, 39 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index de9a9ff2edd8..a3a7deda35a5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -379,6 +379,45 @@ clock-controller@15031000 {
>   		};
>   	};
>   
> +	thermal-zones {
> +		cpu_thermal: cpu-thermal {
> +			polling-delay-passive = <1000>;
> +			polling-delay = <1000>;
> +			thermal-sensors = <&lvts 0>;
> +			trips {
> +				cpu_trip_crit: crit {
> +					temperature = <125000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};

No, please just add "crit" - as that is the one that is used to not let the
SoC to reach Tj.

All of the others are board specific, so the trips down there (hot->low) are
to be added to your board dts instead.

Cheers,
Angelo

> +
> +				cpu_trip_hot: hot {
> +					temperature = <120000>;
> +					hysteresis = <2000>;
> +					type = "hot";
> +				};
> +
> +				cpu_trip_active_high: active-high {
> +					temperature = <115000>;
> +					hysteresis = <2000>;
> +					type = "active";
> +				};
> +
> +				cpu_trip_active_med: active-med {
> +					temperature = <85000>;
> +					hysteresis = <2000>;
> +					type = "active";
> +				};
> +
> +				cpu_trip_active_low: active-low {
> +					temperature = <40000>;
> +					hysteresis = <2000>;
> +					type = "active";
> +				};
> +			};
> +		};
> +	};
> +
>   	timer {
>   		compatible = "arm,armv8-timer";
>   		interrupt-parent = <&gic>;

[RFC v1 12/14] arm64: dts: mediatek: mt7988: add reserved memory

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add memory range handled by ATF to not be touched by linux kernel.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index a3a7deda35a5..7721d2ec06ee 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -81,6 +81,18 @@ reg_3p3v: regulator-3p3v {
 		regulator-always-on;
 	};
 
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		/* 320 KiB reserved for ARM Trusted Firmware (BL31 and BL32) */
+		secmon_reserved: secmon@43000000 {
+			reg = <0 0x43000000 0 0x50000>;
+			no-map;
+		};
+	};
+
 	soc {
 		compatible = "simple-bus";
 		ranges;
-- 
2.43.0

Re: [RFC v1 12/14] arm64: dts: mediatek: mt7988: add reserved memory

[AngeloGioacchino Del Regno]

Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add memory range handled by ATF to not be touched by linux kernel.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

If you are really sure that this is always the same for all boards based on MT7988,
I will trust you and give you my R-b once this series gets out of RFC state.

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index a3a7deda35a5..7721d2ec06ee 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -81,6 +81,18 @@ reg_3p3v: regulator-3p3v {
>   		regulator-always-on;
>   	};
>   
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		/* 320 KiB reserved for ARM Trusted Firmware (BL31 and BL32) */
> +		secmon_reserved: secmon@43000000 {
> +			reg = <0 0x43000000 0 0x50000>;
> +			no-map;
> +		};
> +	};
> +
>   	soc {
>   		compatible = "simple-bus";
>   		ranges;

Aw: Re: [RFC v1 12/14] arm64: dts: mediatek: mt7988: add reserved memory

[Frank Wunderlich]

> Gesendet: Mittwoch, 27. November 2024 um 14:34
&gt; Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
&gt; An: "Frank Wunderlich" <linux@fw-web.de>, "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>
&gt; CC: "Frank Wunderlich" <frank-w@public-files.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
&gt; Betreff: Re: [RFC v1 12/14] arm64: dts: mediatek: mt7988: add reserved memory
&gt;
&gt; Il 29/10/24 11:39, Frank Wunderlich ha scritto:
&gt; &gt; From: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt;
&gt; &gt; Add memory range handled by ATF to not be touched by linux kernel.
&gt; &gt;
&gt; &gt; Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
&gt;
&gt; If you are really sure that this is always the same for all boards based on MT7988,
&gt; I will trust you and give you my R-b once this series gets out of RFC state.

I'm not sure, but ATF is SoC specific and so it should be a SoC specific range, not board specific

&gt; Cheers,
&gt; Angelo
&gt;
&gt; &gt; ---
&gt; &gt;   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 12 ++++++++++++
&gt; &gt;   1 file changed, 12 insertions(+)
&gt; &gt;
&gt; &gt; diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; index a3a7deda35a5..7721d2ec06ee 100644
&gt; &gt; --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; @@ -81,6 +81,18 @@ reg_3p3v: regulator-3p3v {
&gt; &gt;   		regulator-always-on;
&gt; &gt;   	};
&gt; &gt;
&gt; &gt; +	reserved-memory {
&gt; &gt; +		#address-cells = &lt;2&gt;;
&gt; &gt; +		#size-cells = &lt;2&gt;;
&gt; &gt; +		ranges;
&gt; &gt; +
&gt; &gt; +		/* 320 KiB reserved for ARM Trusted Firmware (BL31 and BL32) */
&gt; &gt; +		secmon_reserved: secmon@43000000 {
&gt; &gt; +			reg = &lt;0 0x43000000 0 0x50000&gt;;
&gt; &gt; +			no-map;
&gt; &gt; +		};
&gt; &gt; +	};
&gt; &gt; +
&gt; &gt;   	soc {
&gt; &gt;   		compatible = "simple-bus";
&gt; &gt;   		ranges;
&gt;
&gt; </frank-w@public-files.de></frank-w@public-files.de></frank-w@public-files.de></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></robh@kernel.org></linux@fw-web.de></angelogioacchino.delregno@collabora.com>

[RFC v1 13/14] arm64: dts: mediatek: mt7988: add mcu-sys node for cpu

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add mcu-sys node which is used later as clock-controller for cpus.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index 7721d2ec06ee..e037854666c1 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -210,6 +210,12 @@ pwm: pwm@10048000 {
 			status = "disabled";
 		};
 
+		mcusys: mcusys@100e0000 {
+			compatible = "mediatek,mt7988-mcusys", "syscon";
+			reg = <0 0x100e0000 0 0x1000>;
+			#clock-cells = <1>;
+		};
+
 		serial0: serial@11000000 {
 			compatible = "mediatek,mt7988-uart", "mediatek,mt6577-uart";
 			reg = <0 0x11000000 0 0x100>;
-- 
2.43.0

[RFC v1 14/14] arm64: dts: mediatek: mt7988: add operating-points

[Frank Wunderlich]

From: Frank Wunderlich <frank-w@public-files.de>

Add operating points defining frequency/voltages of cpu cores.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 45 +++++++++++++++++++++--
 1 file changed, 41 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
index e037854666c1..25669d498617 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
@@ -16,32 +16,69 @@ cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu@0 {
+		cpu0: cpu@0 {
 			compatible = "arm,cortex-a73";
 			reg = <0x0>;
 			device_type = "cpu";
 			enable-method = "psci";
+			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
+				 <&topckgen CLK_TOP_XTAL>;
+			clock-names = "cpu", "intermediate";
+			operating-points-v2 = <&cluster0_opp>;
 		};
 
-		cpu@1 {
+		cpu1: cpu@1 {
 			compatible = "arm,cortex-a73";
 			reg = <0x1>;
 			device_type = "cpu";
 			enable-method = "psci";
+			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
+				 <&topckgen CLK_TOP_XTAL>;
+			clock-names = "cpu", "intermediate";
+			operating-points-v2 = <&cluster0_opp>;
 		};
 
-		cpu@2 {
+		cpu2: cpu@2 {
 			compatible = "arm,cortex-a73";
 			reg = <0x2>;
 			device_type = "cpu";
 			enable-method = "psci";
+			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
+				 <&topckgen CLK_TOP_XTAL>;
+			clock-names = "cpu", "intermediate";
+			operating-points-v2 = <&cluster0_opp>;
 		};
 
-		cpu@3 {
+		cpu3: cpu@3 {
 			compatible = "arm,cortex-a73";
 			reg = <0x3>;
 			device_type = "cpu";
 			enable-method = "psci";
+			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
+				 <&topckgen CLK_TOP_XTAL>;
+			clock-names = "cpu", "intermediate";
+			operating-points-v2 = <&cluster0_opp>;
+		};
+
+		cluster0_opp: opp-table-0 {
+			compatible = "operating-points-v2";
+			opp-shared;
+			opp00 {
+				opp-hz = /bits/ 64 <800000000>;
+				opp-microvolt = <850000>;
+			};
+			opp01 {
+				opp-hz = /bits/ 64 <1100000000>;
+				opp-microvolt = <850000>;
+			};
+			opp02 {
+				opp-hz = /bits/ 64 <1500000000>;
+				opp-microvolt = <850000>;
+			};
+			opp03 {
+				opp-hz = /bits/ 64 <1800000000>;
+				opp-microvolt = <900000>;
+			};
 		};
 	};
 
-- 
2.43.0

Re: [RFC v1 14/14] arm64: dts: mediatek: mt7988: add operating-points

[AngeloGioacchino Del Regno]

Il 29/10/24 11:39, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add operating points defining frequency/voltages of cpu cores.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 45 +++++++++++++++++++++--
>   1 file changed, 41 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> index e037854666c1..25669d498617 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
> @@ -16,32 +16,69 @@ cpus {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>   
> -		cpu@0 {
> +		cpu0: cpu@0 {

Where are those cpuX labels used? I don't see any usage.

>   			compatible = "arm,cortex-a73";
>   			reg = <0x0>;
>   			device_type = "cpu";
>   			enable-method = "psci";
> +			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
> +				 <&topckgen CLK_TOP_XTAL>;
> +			clock-names = "cpu", "intermediate";
> +			operating-points-v2 = <&cluster0_opp>;
>   		};
>   
> -		cpu@1 {
> +		cpu1: cpu@1 {
>   			compatible = "arm,cortex-a73";
>   			reg = <0x1>;
>   			device_type = "cpu";
>   			enable-method = "psci";
> +			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
> +				 <&topckgen CLK_TOP_XTAL>;
> +			clock-names = "cpu", "intermediate";
> +			operating-points-v2 = <&cluster0_opp>;
>   		};
>   
> -		cpu@2 {
> +		cpu2: cpu@2 {
>   			compatible = "arm,cortex-a73";
>   			reg = <0x2>;
>   			device_type = "cpu";
>   			enable-method = "psci";
> +			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
> +				 <&topckgen CLK_TOP_XTAL>;
> +			clock-names = "cpu", "intermediate";
> +			operating-points-v2 = <&cluster0_opp>;
>   		};
>   
> -		cpu@3 {
> +		cpu3: cpu@3 {
>   			compatible = "arm,cortex-a73";
>   			reg = <0x3>;
>   			device_type = "cpu";
>   			enable-method = "psci";
> +			clocks = <&mcusys CLK_MCU_ARM_DIV_SEL>,
> +				 <&topckgen CLK_TOP_XTAL>;
> +			clock-names = "cpu", "intermediate";
> +			operating-points-v2 = <&cluster0_opp>;
> +		};
> +
> +		cluster0_opp: opp-table-0 {
> +			compatible = "operating-points-v2";
> +			opp-shared;
> +			opp00 {

...But you can also be consistent with other devicetrees and follow the pattern
for the node names of the OPP entries.

opp-800000000
opp-1100000000
...etc

Cheers,
Angelo

> +				opp-hz = /bits/ 64 <800000000>;
> +				opp-microvolt = <850000>;
> +			};
> +			opp01 {
> +				opp-hz = /bits/ 64 <1100000000>;
> +				opp-microvolt = <850000>;
> +			};
> +			opp02 {
> +				opp-hz = /bits/ 64 <1500000000>;
> +				opp-microvolt = <850000>;
> +			};
> +			opp03 {
> +				opp-hz = /bits/ 64 <1800000000>;
> +				opp-microvolt = <900000>;
> +			};
>   		};
>   	};
>   

Aw: Re: [RFC v1 14/14] arm64: dts: mediatek: mt7988: add operating-points

[Frank Wunderlich]

> Gesendet: Mittwoch, 27. November 2024 um 14:34
&gt; Von: "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
&gt; An: "Frank Wunderlich" <linux@fw-web.de>, "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>
&gt; CC: "Frank Wunderlich" <frank-w@public-files.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
&gt; Betreff: Re: [RFC v1 14/14] arm64: dts: mediatek: mt7988: add operating-points
&gt;
&gt; Il 29/10/24 11:39, Frank Wunderlich ha scritto:
&gt; &gt; From: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt;
&gt; &gt; Add operating points defining frequency/voltages of cpu cores.
&gt; &gt;
&gt; &gt; Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
&gt; &gt; ---
&gt; &gt;   arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 45 +++++++++++++++++++++--
&gt; &gt;   1 file changed, 41 insertions(+), 4 deletions(-)
&gt; &gt;
&gt; &gt; diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; index e037854666c1..25669d498617 100644
&gt; &gt; --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi
&gt; &gt; @@ -16,32 +16,69 @@ cpus {
&gt; &gt;   		#address-cells = &lt;1&gt;;
&gt; &gt;   		#size-cells = &lt;0&gt;;
&gt; &gt;
&gt; &gt; -		cpu@0 {
&gt; &gt; +		cpu0: cpu@0 {
&gt;
&gt; Where are those cpuX labels used? I don't see any usage.

these are used in later patch and needed in uboot when we want to switch to OF_UPSTREAM.

&gt; &gt;   			compatible = "arm,cortex-a73";
&gt; &gt;   			reg = &lt;0x0&gt;;
&gt; &gt;   			device_type = "cpu";
&gt; &gt;   			enable-method = "psci";
&gt; &gt; +			clocks = &lt;&amp;mcusys CLK_MCU_ARM_DIV_SEL&gt;,
&gt; &gt; +				 &lt;&amp;topckgen CLK_TOP_XTAL&gt;;
&gt; &gt; +			clock-names = "cpu", "intermediate";
&gt; &gt; +			operating-points-v2 = &lt;&amp;cluster0_opp&gt;;
&gt; &gt;   		};
&gt; &gt;
&gt; &gt; -		cpu@1 {
&gt; &gt; +		cpu1: cpu@1 {
&gt; &gt;   			compatible = "arm,cortex-a73";
&gt; &gt;   			reg = &lt;0x1&gt;;
&gt; &gt;   			device_type = "cpu";
&gt; &gt;   			enable-method = "psci";
&gt; &gt; +			clocks = &lt;&amp;mcusys CLK_MCU_ARM_DIV_SEL&gt;,
&gt; &gt; +				 &lt;&amp;topckgen CLK_TOP_XTAL&gt;;
&gt; &gt; +			clock-names = "cpu", "intermediate";
&gt; &gt; +			operating-points-v2 = &lt;&amp;cluster0_opp&gt;;
&gt; &gt;   		};
&gt; &gt;
&gt; &gt; -		cpu@2 {
&gt; &gt; +		cpu2: cpu@2 {
&gt; &gt;   			compatible = "arm,cortex-a73";
&gt; &gt;   			reg = &lt;0x2&gt;;
&gt; &gt;   			device_type = "cpu";
&gt; &gt;   			enable-method = "psci";
&gt; &gt; +			clocks = &lt;&amp;mcusys CLK_MCU_ARM_DIV_SEL&gt;,
&gt; &gt; +				 &lt;&amp;topckgen CLK_TOP_XTAL&gt;;
&gt; &gt; +			clock-names = "cpu", "intermediate";
&gt; &gt; +			operating-points-v2 = &lt;&amp;cluster0_opp&gt;;
&gt; &gt;   		};
&gt; &gt;
&gt; &gt; -		cpu@3 {
&gt; &gt; +		cpu3: cpu@3 {
&gt; &gt;   			compatible = "arm,cortex-a73";
&gt; &gt;   			reg = &lt;0x3&gt;;
&gt; &gt;   			device_type = "cpu";
&gt; &gt;   			enable-method = "psci";
&gt; &gt; +			clocks = &lt;&amp;mcusys CLK_MCU_ARM_DIV_SEL&gt;,
&gt; &gt; +				 &lt;&amp;topckgen CLK_TOP_XTAL&gt;;
&gt; &gt; +			clock-names = "cpu", "intermediate";
&gt; &gt; +			operating-points-v2 = &lt;&amp;cluster0_opp&gt;;
&gt; &gt; +		};
&gt; &gt; +
&gt; &gt; +		cluster0_opp: opp-table-0 {
&gt; &gt; +			compatible = "operating-points-v2";
&gt; &gt; +			opp-shared;
&gt; &gt; +			opp00 {
&gt;
&gt; ...But you can also be consistent with other devicetrees and follow the pattern
&gt; for the node names of the OPP entries.
&gt;
&gt; opp-800000000
&gt; opp-1100000000
&gt; ...etc

ok, will change this..so just adding the opp-hz value to the name (or label)?

&gt; Cheers,
&gt; Angelo
&gt;
&gt; &gt; +				opp-hz = /bits/ 64 &lt;800000000&gt;;
&gt; &gt; +				opp-microvolt = &lt;850000&gt;;
&gt; &gt; +			};
&gt; &gt; +			opp01 {
&gt; &gt; +				opp-hz = /bits/ 64 &lt;1100000000&gt;;
&gt; &gt; +				opp-microvolt = &lt;850000&gt;;
&gt; &gt; +			};
&gt; &gt; +			opp02 {
&gt; &gt; +				opp-hz = /bits/ 64 &lt;1500000000&gt;;
&gt; &gt; +				opp-microvolt = &lt;850000&gt;;
&gt; &gt; +			};
&gt; &gt; +			opp03 {
&gt; &gt; +				opp-hz = /bits/ 64 &lt;1800000000&gt;;
&gt; &gt; +				opp-microvolt = &lt;900000&gt;;
&gt; &gt; +			};
&gt; &gt;   		};
&gt; &gt;   	};
&gt; &gt;
&gt;
&gt;
&gt; </frank-w@public-files.de></frank-w@public-files.de></frank-w@public-files.de></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></robh@kernel.org></linux@fw-web.de></angelogioacchino.delregno@collabora.com>

Aw: [RFC v1 00/14] Add some mt7988 DTS labels and new nodes

[Frank Wunderlich]

just a gentle ping...any thoughts about it?

should i squash the label-commits or can it applied this way?

btw. the series about mt7986/bpi-r3 is also open till half year...and it was resend too...

https://patchwork.kernel.org/project/linux-mediatek/patch/20240608080530.9436-2-linux@fw-web.de/

regards Frank


> Gesendet: Dienstag, 29. Oktober 2024 um 11:39
&gt; Von: "Frank Wunderlich" <linux@fw-web.de>
&gt; An: "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, "Conor Dooley" <conor+dt@kernel.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>
&gt; CC: "Frank Wunderlich" <frank-w@public-files.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org
&gt; Betreff: [RFC v1 00/14] Add some mt7988 DTS labels and new nodes
&gt;
&gt; From: Frank Wunderlich <frank-w@public-files.de>
&gt;
&gt; This series adds some missing labels and new nodes to mt7988 DTS.
&gt;
&gt; If wanted i can squash the coommits adding labels to have less patches,
&gt; but for first review i let them separate.
&gt;
&gt; Frank Wunderlich (14):
&gt;   arm64: dts: mediatek: mt7988: add missing label for apmixedsys
&gt;   arm64: dts: mediatek: mt7988: add labels for i2c nodes
&gt;   arm64: dts: mediatek: mt7988: add labels for usb nodes
&gt;   arm64: dts: mediatek: mt7988: add serial labels
&gt;   arm64: dts: mediatek: mt7988: add label for pwm node
&gt;   arm64: dts: mediatek: mt7988: add label for efuse
&gt;   arm64: dts: mediatek: mt7988: add mmc support
&gt;   arm64: dts: mediatek: mt7988: add fixed regulators for 1v8 and 3v3
&gt;   arm64: dts: mediatek: mt7988: extend efuse node
&gt;   arm64: dts: mediatek: mt7988: add lvts node
&gt;   arm64: dts: mediatek: mt7988: add thermal-zone
&gt;   arm64: dts: mediatek: mt7988: add reserved memory
&gt;   arm64: dts: mediatek: mt7988: add mcu-sys node for cpu
&gt;   arm64: dts: mediatek: mt7988: add operating-points
&gt;
&gt;  arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 196 ++++++++++++++++++++--
&gt;  1 file changed, 181 insertions(+), 15 deletions(-)
&gt;
&gt; --
&gt; 2.43.0
</frank-w@public-files.de></frank-w@public-files.de></angelogioacchino.delregno@collabora.com></matthias.bgg@gmail.com></conor+dt@kernel.org></krzk+dt@kernel.org></robh@kernel.org></linux@fw-web.de>