From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Dmitry Yashin <dmt.yashin@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: rockchip,rk3308-codec: add port property
Date: Tue, 29 Oct 2024 11:25:25 +0100 [thread overview]
Message-ID: <20241029112525.50c15b60@booty> (raw)
In-Reply-To: <20241028213314.476776-2-dmt.yashin@gmail.com>
Hello Dmitry,
On Tue, 29 Oct 2024 02:33:12 +0500
Dmitry Yashin <dmt.yashin@gmail.com> wrote:
> Fix DTB warnings when rk3308-codec used with audio-graph-card by
> documenting port property:
>
> codec@ff560000: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Dmitry Yashin <dmt.yashin@gmail.com>
> ---
> .../devicetree/bindings/sound/rockchip,rk3308-codec.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> index ecf3d7d968c8..2cf229a076f0 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> @@ -48,6 +48,10 @@ properties:
> - const: mclk_rx
> - const: hclk
>
> + port:
> + $ref: audio-graph-port.yaml#
> + unevaluatedProperties: false
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Also, why not adding a 'port' node to the example below? Can be done in
v2 in case you send one.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-10-29 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 21:33 [PATCH 0/3] arm64: dts: rockchip: add Banana Pi BPI-P2 Pro board Dmitry Yashin
2024-10-28 21:33 ` [PATCH 1/3] ASoC: dt-bindings: rockchip,rk3308-codec: add port property Dmitry Yashin
2024-10-29 10:25 ` Luca Ceresoli [this message]
2024-10-28 21:33 ` [PATCH 2/3] dt-bindings: arm: rockchip: add Banana Pi BPI-P2 Pro board Dmitry Yashin
2024-10-29 5:57 ` Heiko Stuebner
2024-10-28 21:33 ` [PATCH 3/3] arm64: dts: " Dmitry Yashin
2024-10-29 18:56 ` (subset) [PATCH 0/3] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029112525.50c15b60@booty \
--to=luca.ceresoli@bootlin.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmt.yashin@gmail.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).