* [PATCH v2 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback @ 2024-10-29 12:02 Fabio Estevam 2024-10-29 12:02 ` [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam 2024-10-29 12:02 ` [PATCH v2 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam 0 siblings, 2 replies; 4+ messages in thread From: Fabio Estevam @ 2024-10-29 12:02 UTC (permalink / raw) To: shawnguo Cc: marex, a.fatoum, andreas, kernel, robh, krzk+dt, conor+dt, devicetree, imx, linux-arm-kernel, dri-devel, Fabio Estevam From: Fabio Estevam <festevam@denx.de> imx6sx.dtsi has the following lcdif entries: compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; This causes the following dt-schema warning: ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible 'fsl,imx6sx-lcdif' fallback. Signed-off-by: Fabio Estevam <festevam@denx.de> --- Changes since v1: - Newly introduced. Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 8e3a98aeec32..836955de3bc9 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -32,6 +32,10 @@ properties: - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - enum: + - fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif reg: maxItems: 1 -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks 2024-10-29 12:02 [PATCH v2 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam @ 2024-10-29 12:02 ` Fabio Estevam 2024-10-29 18:09 ` Andreas Kemnade 2024-10-29 12:02 ` [PATCH v2 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam 1 sibling, 1 reply; 4+ messages in thread From: Fabio Estevam @ 2024-10-29 12:02 UTC (permalink / raw) To: shawnguo Cc: marex, a.fatoum, andreas, kernel, robh, krzk+dt, conor+dt, devicetree, imx, linux-arm-kernel, dri-devel, Fabio Estevam From: Fabio Estevam <festevam@denx.de> imx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback. ['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long The imx6sx-lcdif programming model has more advanced features, such as overlay plane and the CRC32 support than the imx28-lcdif IP. Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific fsl,imx28-lcdif fallback: compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; This helps keeping DT compatibility as well as using the more advanced lcdif features found on imx6sl and imx6sll. Signed-off-by: Fabio Estevam <festevam@denx.de> --- Changes since v1: - Newly introduced. .../devicetree/bindings/display/fsl,lcdif.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index 836955de3bc9..08ce19638fbd 100644 --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -32,11 +32,23 @@ properties: - fsl,imx8mn-lcdif - fsl,imx8mq-lcdif - const: fsl,imx6sx-lcdif + - items: + - const: fsl,imx6sl-lcdif + - const: fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif + - items: + - const: fsl,imx6sll-lcdif + - const: fsl,imx6sx-lcdif + - const: fsl,imx28-lcdif + - items: + - enum: + - fsl,imx6sl-lcdif + - fsl,imx6sll-lcdif + - const: fsl,imx28-lcdif - items: - enum: - fsl,imx6sx-lcdif - const: fsl,imx28-lcdif - reg: maxItems: 1 -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks 2024-10-29 12:02 ` [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam @ 2024-10-29 18:09 ` Andreas Kemnade 0 siblings, 0 replies; 4+ messages in thread From: Andreas Kemnade @ 2024-10-29 18:09 UTC (permalink / raw) To: Fabio Estevam Cc: shawnguo, marex, a.fatoum, kernel, robh, krzk+dt, conor+dt, devicetree, imx, linux-arm-kernel, dri-devel, Fabio Estevam Am Tue, 29 Oct 2024 09:02:35 -0300 schrieb Fabio Estevam <festevam@gmail.com>: > From: Fabio Estevam <festevam@denx.de> > > imx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > > This causes dt-schema warnings as the current binding only > allow 'fsl,imx6sx-lcdif' as fallback. > > ['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long > ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long > > The imx6sx-lcdif programming model has more advanced features, such > as overlay plane and the CRC32 support than the imx28-lcdif IP. > > Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific > fsl,imx28-lcdif fallback: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", > "fsl,imx28-lcdif"; > > This helps keeping DT compatibility as well as using the more advanced > lcdif features found on imx6sl and imx6sll. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v1: > - Newly introduced. > > .../devicetree/bindings/display/fsl,lcdif.yaml | 14 > +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index > 836955de3bc9..08ce19638fbd 100644 --- > a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++ > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -32,11 > +32,23 @@ properties: > - fsl,imx8mn-lcdif > - fsl,imx8mq-lcdif > - const: fsl,imx6sx-lcdif > + - items: > + - const: fsl,imx6sl-lcdif > + - const: fsl,imx6sx-lcdif > + - const: fsl,imx28-lcdif > + - items: > + - const: fsl,imx6sll-lcdif > + - const: fsl,imx6sx-lcdif > + - const: fsl,imx28-lcdif > + - items: > + - enum: > + - fsl,imx6sl-lcdif > + - fsl,imx6sll-lcdif > + - const: fsl,imx28-lcdif What do we need this for? Either imx6sx-lcdif is a useful fallback compatible or not. But not sometimes. Looking at the kernel driver: It is. So IMHO only the three element variants should be allowed. Regards, Andreas ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible 2024-10-29 12:02 [PATCH v2 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam 2024-10-29 12:02 ` [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam @ 2024-10-29 12:02 ` Fabio Estevam 1 sibling, 0 replies; 4+ messages in thread From: Fabio Estevam @ 2024-10-29 12:02 UTC (permalink / raw) To: shawnguo Cc: marex, a.fatoum, andreas, kernel, robh, krzk+dt, conor+dt, devicetree, imx, linux-arm-kernel, dri-devel, Fabio Estevam From: Fabio Estevam <festevam@denx.de> The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility. Signed-off-by: Fabio Estevam <festevam@denx.de> --- Changes since v1: - Add 3 entries for keeping DT compatibility. (Ahmad, Andreas). arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 3 ++- arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi index 6aa61235e39e..840e19b2ca0f 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi @@ -773,7 +773,8 @@ epdc: epdc@20f4000 { }; lcdif: lcdif@20f8000 { - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif", + "fsl,imx28-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_LCDIF_PIX>, diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi index 85fe2a4ab97a..e6fd47814665 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi @@ -648,7 +648,8 @@ pxp: pxp@20f0000 { }; lcdif: lcd-controller@20f8000 { - compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sll-lcdif", "fsl,imx6sx-lcdif", + "fsl,imx28-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SLL_CLK_LCDIF_PIX>, -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-29 18:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-10-29 12:02 [PATCH v2 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback Fabio Estevam 2024-10-29 12:02 ` [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks Fabio Estevam 2024-10-29 18:09 ` Andreas Kemnade 2024-10-29 12:02 ` [PATCH v2 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible Fabio Estevam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).