devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, sre@kernel.org, tsbogend@alpha.franken.de,
	markus.stockhausen@gmx.de, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v7 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals
Date: Thu, 31 Oct 2024 15:48:52 +0000	[thread overview]
Message-ID: <20241031154852.GI10824@google.com> (raw)
In-Reply-To: <20241017001653.178399-4-chris.packham@alliedtelesis.co.nz>

On Thu, 17 Oct 2024, Chris Packham wrote:

> Add device tree schema for the Realtek RTL9300 switches. The RTL9300
> family is made up of the RTL9301, RTL9302B, RTL9302C and RTL9303. These
> have the same SoC differ in the Ethernet switch/SERDES arrangement.
> 
> Currently the only supported features are the syscon-reboot and i2c
> controllers. The syscon-reboot is needed to be able to reboot the board.
> The I2C controllers are slightly unusual because they each own an SCL
> pin (GPIO8 for the first controller, GPIO 17 for the second) but have 8
> common SDA pins which can be assigned to either controller (but not
> both).
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> 
> Notes:
>     Changes in v7:
>     - Set additionalProperties: false
>     - Remove extraneous examples from i2c binding
>     Changes in v6:
>     - Drop wildcard compatible
>     - Add specific compatibles for the 4 known SoC variants
>     - For the i2c part of the binding accept realtek,rtl9301 as a fallback
>       for the other compatibles
>     - The overall switches will eventually differ because these will have
>       different SERDES/port arrangements so they aren't getting the same
>       fallback treatment
>     Changes in v5:
>       I've combined the two series I had in flight so this is the
>       combination of adding the switch syscon, the reboot and i2c. It makes
>       the changelog a bit meaningless so I've dropped the earlier
>       commentary.
>     
>       As requested I've put a more complete example in the main
>       rtl9300-switch.yaml.
>     
>       I've kept rtl9300-i2c.yaml separate for now but link to it with a $ref
>       from rtl9300-switch.yaml to reduce clutter. The example in
>       rtl9300-i2c.yaml is technically duplicating part of the example from
>       rtl9300-switch.yaml but I feel it's nice to be able to see the example
>       next to where the properties are defined.
> 
>  .../bindings/i2c/realtek,rtl9301-i2c.yaml     |  69 +++++++++++
>  .../bindings/mfd/realtek,rtl9301-switch.yaml  | 114 ++++++++++++++++++

Can you separate these out so I can apply the MFD part please?

-- 
Lee Jones [李琼斯]

  parent reply	other threads:[~2024-10-31 15:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  0:16 [PATCH v7 0/6] RTL9300 support for reboot and i2c Chris Packham
2024-10-17  0:16 ` [PATCH v7 1/6] dt-bindings: reset: syscon-reboot: Add reg property Chris Packham
2024-10-17  0:16 ` [PATCH v7 2/6] power: reset: syscon-reboot: Accept " Chris Packham
2024-10-17  0:16 ` [PATCH v7 3/6] dt-bindings: mfd: Add Realtek RTL9300 switch peripherals Chris Packham
2024-10-17  7:56   ` Krzysztof Kozlowski
2024-10-31 15:48   ` Lee Jones [this message]
2024-10-17  0:16 ` [PATCH v7 4/6] mips: dts: realtek: Add syscon-reboot node Chris Packham
2024-10-17  0:16 ` [PATCH v7 5/6] mips: dts: realtek: Add I2C controllers Chris Packham
2024-10-17  0:16 ` [PATCH v7 6/6] i2c: Add driver for the RTL9300 I2C controller Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241031154852.GI10824@google.com \
    --to=lee@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=markus.stockhausen@gmx.de \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).