public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: ahaslam@baylibre.com
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com,
	dlechner@baylibre.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] Improvements and Enhancements for AD5791 DAC Driver
Date: Thu, 31 Oct 2024 21:38:03 +0000	[thread overview]
Message-ID: <20241031213803.18091910@jic23-huawei> (raw)
In-Reply-To: <20241031071746.848694-1-ahaslam@baylibre.com>

On Thu, 31 Oct 2024 08:17:40 +0100
ahaslam@baylibre.com wrote:

> From: Axel Haslam <ahaslam@baylibre.com>
> 
> These patches aim to improve on the ad5791 driver:
>  - make use of chip_info / match tables, and drop device enum id.
>  - Add reset, clr and ldac gpios that have to be set to the correct level in case they
>    are not hardwired on the setup/PCB.
>  - simplify probe by using the devm_* functions to automatically free resources.
Applied. Thanks,

> ---
> Changes in v3:
> - v2 is missing the version prefix. Im sending v3 just with the added review-by tag.
> - Add review-by tag from David Lechner
> - Link to V2: https://lore.kernel.org/all/94a03835-bdd1-4243-88c7-0ad85784fe36@baylibre.com/
> 
> Changes in v2:
> - Fix probe error print using uninitialized ret.
> - Add documentation for new struct parameters
> - Add review-by tags to device tree bindings
> - Link to V1: https://lore.kernel.org/all/CAKXjFTPwN2TYW6sq1kj3miZ0f5OqKX0aTk8eGf1sj9TBk1_e=A@mail.gmail.com/T/
> 
> Axel Haslam (6):
>   dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios
>   dt-bindings: iio: dac: ad5791: Add required voltage supplies
>   iio: dac: ad5791: Include chip_info in device match tables
>   iio: dac: ad5791: Add reset, clr and ldac gpios
>   iio: dac: ad5791: Use devm_regulator_get_enable_read_voltage
>   iio: dac: ad5791: Use devm_iio_device_register
> 
>  .../bindings/iio/dac/adi,ad5791.yaml          |  39 ++++
>  drivers/iio/dac/ad5791.c                      | 203 ++++++++----------
>  2 files changed, 131 insertions(+), 111 deletions(-)
> 


      parent reply	other threads:[~2024-10-31 21:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  7:17 [PATCH v3 0/6] Improvements and Enhancements for AD5791 DAC Driver ahaslam
2024-10-31  7:17 ` [PATCH v3 1/6] dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios ahaslam
2024-10-31  7:17 ` [PATCH v3 2/6] dt-bindings: iio: dac: ad5791: Add required voltage supplies ahaslam
2024-10-31  7:17 ` [PATCH v3 3/6] iio: dac: ad5791: Include chip_info in device match tables ahaslam
2024-10-31  7:17 ` [PATCH v3 4/6] iio: dac: ad5791: Add reset, clr and ldac gpios ahaslam
2024-10-31  7:17 ` [PATCH v3 5/6] iio: dac: ad5791: Use devm_regulator_get_enable_read_voltage ahaslam
2024-10-31  7:17 ` [PATCH v3 6/6] iio: dac: ad5791: Use devm_iio_device_register ahaslam
2024-10-31 21:38 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241031213803.18091910@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=ahaslam@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox