* [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1
@ 2024-10-31 19:47 Frank Li
2024-10-31 19:59 ` Dmitry Baryshkov
2024-11-04 15:40 ` Rob Herring
0 siblings, 2 replies; 7+ messages in thread
From: Frank Li @ 2024-10-31 19:47 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Guido Gúnther,
Robert Chiras, open list:DRM DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint'
property referencing video-interfaces.yaml. Allow 'data-lanes' values
1, 2, 3, and 4 for port@1.
Fix below CHECK_DTB warnings:
arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb:
dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
index 350fb8f400f02..5952e6448ed47 100644
--- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml
@@ -111,11 +111,27 @@ properties:
unevaluatedProperties: false
port@1:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description:
DSI output port node to the panel or the next bridge
in the chain
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ description: array of physical DSI data lane indexes.
+ minItems: 1
+ items:
+ - const: 1
+ - const: 2
+ - const: 3
+ - const: 4
+
required:
- port@0
- port@1
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 2024-10-31 19:47 [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 Frank Li @ 2024-10-31 19:59 ` Dmitry Baryshkov 2024-10-31 20:20 ` Frank Li 2024-11-04 15:40 ` Rob Herring 1 sibling, 1 reply; 7+ messages in thread From: Dmitry Baryshkov @ 2024-10-31 19:59 UTC (permalink / raw) To: Frank Li Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guido Gúnther, Robert Chiras, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. > > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 350fb8f400f02..5952e6448ed47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -111,11 +111,27 @@ properties: > unevaluatedProperties: false > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: > DSI output port node to the panel or the next bridge > in the chain > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 Why are they indexed starting from 1? > + > required: > - port@0 > - port@1 > -- > 2.34.1 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 2024-10-31 19:59 ` Dmitry Baryshkov @ 2024-10-31 20:20 ` Frank Li 2024-10-31 20:55 ` Dmitry Baryshkov 0 siblings, 1 reply; 7+ messages in thread From: Frank Li @ 2024-10-31 20:20 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guido Gúnther, Robert Chiras, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Oct 31, 2024 at 09:59:26PM +0200, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > 1, 2, 3, and 4 for port@1. > > > > Fix below CHECK_DTB warnings: > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > index 350fb8f400f02..5952e6448ed47 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > @@ -111,11 +111,27 @@ properties: > > unevaluatedProperties: false > > > > port@1: > > - $ref: /schemas/graph.yaml#/properties/port > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > description: > > DSI output port node to the panel or the next bridge > > in the chain > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: array of physical DSI data lane indexes. > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > Why are they indexed starting from 1? Not sure, git grep -r data-lanes Documentation/devicetree/bindings/ Most start from 1. Not sure latest DT team's intention. Frank > > > + > > required: > > - port@0 > > - port@1 > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 2024-10-31 20:20 ` Frank Li @ 2024-10-31 20:55 ` Dmitry Baryshkov 2024-10-31 21:14 ` Laurent Pinchart 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Baryshkov @ 2024-10-31 20:55 UTC (permalink / raw) To: Frank Li Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guido Gúnther, Robert Chiras, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Oct 31, 2024 at 04:20:10PM -0400, Frank Li wrote: > On Thu, Oct 31, 2024 at 09:59:26PM +0200, Dmitry Baryshkov wrote: > > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > > 1, 2, 3, and 4 for port@1. > > > > > > Fix below CHECK_DTB warnings: > > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > index 350fb8f400f02..5952e6448ed47 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > @@ -111,11 +111,27 @@ properties: > > > unevaluatedProperties: false > > > > > > port@1: > > > - $ref: /schemas/graph.yaml#/properties/port > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > description: > > > DSI output port node to the panel or the next bridge > > > in the chain > > > > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# > > > + unevaluatedProperties: false > > > + > > > + properties: > > > + data-lanes: > > > + description: array of physical DSI data lane indexes. > > > + minItems: 1 > > > + items: > > > + - const: 1 > > > + - const: 2 > > > + - const: 3 > > > + - const: 4 > > > > Why are they indexed starting from 1? > > Not sure, git grep -r data-lanes Documentation/devicetree/bindings/ > Most start from 1. Not sure latest DT team's intention. They usually start from 1, because just before the property comes 'clock-lanes = <0>'. Otherwise in most of the cases the lanes are indexed from 0. > > Frank > > > > > > + > > > required: > > > - port@0 > > > - port@1 > > > -- > > > 2.34.1 > > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 2024-10-31 20:55 ` Dmitry Baryshkov @ 2024-10-31 21:14 ` Laurent Pinchart 0 siblings, 0 replies; 7+ messages in thread From: Laurent Pinchart @ 2024-10-31 21:14 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Frank Li, Andrzej Hajda, Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guido Gúnther, Robert Chiras, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Oct 31, 2024 at 10:55:30PM +0200, Dmitry Baryshkov wrote: > On Thu, Oct 31, 2024 at 04:20:10PM -0400, Frank Li wrote: > > On Thu, Oct 31, 2024 at 09:59:26PM +0200, Dmitry Baryshkov wrote: > > > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > > > 1, 2, 3, and 4 for port@1. > > > > > > > > Fix below CHECK_DTB warnings: > > > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > > index 350fb8f400f02..5952e6448ed47 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > > > @@ -111,11 +111,27 @@ properties: > > > > unevaluatedProperties: false > > > > > > > > port@1: > > > > - $ref: /schemas/graph.yaml#/properties/port > > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > > + unevaluatedProperties: false > > > > description: > > > > DSI output port node to the panel or the next bridge > > > > in the chain > > > > > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > + properties: > > > > + data-lanes: > > > > + description: array of physical DSI data lane indexes. > > > > + minItems: 1 > > > > + items: > > > > + - const: 1 > > > > + - const: 2 > > > > + - const: 3 > > > > + - const: 4 > > > > > > Why are they indexed starting from 1? > > > > Not sure, git grep -r data-lanes Documentation/devicetree/bindings/ > > Most start from 1. Not sure latest DT team's intention. > > They usually start from 1, because just before the property comes > 'clock-lanes = <0>'. Otherwise in most of the cases the lanes are > indexed from 0. I'm not sure what the rule is for DSI, but for CSI we number data lanes starting at 1 regardless of whether or not the clock lane is configurable. Consistency help for driver implementations. > > > > + > > > > required: > > > > - port@0 > > > > - port@1 -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 2024-10-31 19:47 [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 Frank Li 2024-10-31 19:59 ` Dmitry Baryshkov @ 2024-11-04 15:40 ` Rob Herring 2024-12-05 21:07 ` Frank Li 1 sibling, 1 reply; 7+ messages in thread From: Rob Herring @ 2024-11-04 15:40 UTC (permalink / raw) To: Frank Li Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Krzysztof Kozlowski, Conor Dooley, Guido Gúnther, Robert Chiras, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > property referencing video-interfaces.yaml. Allow 'data-lanes' values > 1, 2, 3, and 4 for port@1. Describe "why", not what the changes are. I can read the diff. Why is the IP has a configurable number of lanes... > > Fix below CHECK_DTB warnings: > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > index 350fb8f400f02..5952e6448ed47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > @@ -111,11 +111,27 @@ properties: > unevaluatedProperties: false > > port@1: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: > DSI output port node to the panel or the next bridge > in the chain > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > required: > - port@0 > - port@1 > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 2024-11-04 15:40 ` Rob Herring @ 2024-12-05 21:07 ` Frank Li 0 siblings, 0 replies; 7+ messages in thread From: Frank Li @ 2024-12-05 21:07 UTC (permalink / raw) To: Rob Herring Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Krzysztof Kozlowski, Conor Dooley, Guido Gúnther, Robert Chiras, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Mon, Nov 04, 2024 at 09:40:59AM -0600, Rob Herring wrote: > On Thu, Oct 31, 2024 at 03:47:14PM -0400, Frank Li wrote: > > Change $ref of port@1 from 'port' to 'port-base' and add 'endpoint' > > property referencing video-interfaces.yaml. Allow 'data-lanes' values > > 1, 2, 3, and 4 for port@1. > > Describe "why", not what the changes are. I can read the diff. Why is > the IP has a configurable number of lanes... How about "This controller support scalable data lanes from 1 to 4. Add the 'data-lanes' property to configure the number of MIPI display panel lanes selected for boards." Frank > > > > > Fix below CHECK_DTB warnings: > > arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070jvhg33.dtb: > > dsi@30a00000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > .../bindings/display/bridge/nwl-dsi.yaml | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > index 350fb8f400f02..5952e6448ed47 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml > > @@ -111,11 +111,27 @@ properties: > > unevaluatedProperties: false > > > > port@1: > > - $ref: /schemas/graph.yaml#/properties/port > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > description: > > DSI output port node to the panel or the next bridge > > in the chain > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + description: array of physical DSI data lane indexes. > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + > > required: > > - port@0 > > - port@1 > > -- > > 2.34.1 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-12-05 21:07 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-10-31 19:47 [PATCH 1/1] dt-bindings: display: nwl-dsi: Allow 'data-lanes' property for port@1 Frank Li 2024-10-31 19:59 ` Dmitry Baryshkov 2024-10-31 20:20 ` Frank Li 2024-10-31 20:55 ` Dmitry Baryshkov 2024-10-31 21:14 ` Laurent Pinchart 2024-11-04 15:40 ` Rob Herring 2024-12-05 21:07 ` Frank Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).