From: Markus Burri <markus.burri@mt.com>
To: linux-kernel@vger.kernel.org
Cc: Markus Burri <markus.burri@mt.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v2 6/7] Input: matrix_keypad - add settle time after enable all columns
Date: Tue, 5 Nov 2024 14:03:21 +0100 [thread overview]
Message-ID: <20241105130322.213623-7-markus.burri@mt.com> (raw)
In-Reply-To: <20241105130322.213623-1-markus.burri@mt.com>
Matrix_keypad with high capacity need a longer settle time after enable
all columns and re-enabling interrupts.
This to give time stable the system and not generate interrupts.
Add a new optional device-tree property to configure the time before
enabling interrupts after disable all columns.
The default is no delay.
Signed-off-by: Markus Burri <markus.burri@mt.com>
---
drivers/input/keyboard/matrix_keypad.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
index 2818915..46873b8 100644
--- a/drivers/input/keyboard/matrix_keypad.c
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -27,6 +27,7 @@ struct matrix_keypad {
unsigned int row_shift;
unsigned int col_scan_delay_us;
+ unsigned int all_cols_on_delay_us;
/* key debounce interval in milli-second */
unsigned int debounce_ms;
bool drive_inactive_cols;
@@ -78,6 +79,9 @@ static void activate_all_cols(struct matrix_keypad *keypad, bool on)
for (col = 0; col < keypad->num_col_gpios; col++)
__activate_col(keypad, col, on);
+
+ if (on && keypad->all_cols_on_delay_us)
+ fsleep(keypad->all_cols_on_delay_us);
}
static bool row_asserted(struct matrix_keypad *keypad, int row)
@@ -403,6 +407,8 @@ static int matrix_keypad_probe(struct platform_device *pdev)
&keypad->debounce_ms);
device_property_read_u32(&pdev->dev, "col-scan-delay-us",
&keypad->col_scan_delay_us);
+ device_property_read_u32(&pdev->dev, "all-cols-on-delay-us",
+ &keypad->all_cols_on_delay_us);
err = matrix_keypad_init_gpio(pdev, keypad);
if (err)
--
2.39.5
next prev parent reply other threads:[~2024-11-05 13:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 6:29 [PATCH 0/6] Input: matrix-keypad: Various performance improvements Markus Burri
2024-10-31 6:29 ` [PATCH 1/6] Input: matrix_keypad - move gpio-row init to the init part Markus Burri
2024-10-31 6:30 ` [PATCH 2/6] Input: matrix_keypad - use fsleep for variable delay duration Markus Burri
2024-10-31 6:30 ` [PATCH 3/6] Input: matrix_keypad - add function for reading row state Markus Burri
2024-10-31 6:30 ` [PATCH 4/6] dt-bindings: input: matrix_keypad - add settle time after enable all columns Markus Burri
2024-10-31 8:32 ` Krzysztof Kozlowski
2024-10-31 6:30 ` [PATCH 5/6] Input: " Markus Burri
2024-10-31 6:30 ` [PATCH 6/6] Input: matrix_keypad - detect change during scan Markus Burri
2024-11-05 13:03 ` [PATCH v2 0/7] Input: matrix-keypad: Various performance improvements Markus Burri
2024-11-05 13:03 ` [PATCH v2 1/7] Input: matrix_keypad - use fsleep for variable delay duration Markus Burri
2024-11-05 19:16 ` Dmitry Torokhov
2024-11-05 13:03 ` [PATCH v2 2/7] Input: matrix_keypad - add function for reading row state Markus Burri
2024-11-05 13:03 ` [PATCH v2 3/7] dt-bindings: input: matrix_keypad - convert to YAML Markus Burri
2024-11-05 17:20 ` kernel test robot
2024-11-11 21:37 ` Rob Herring
2024-11-05 13:03 ` [PATCH v2 4/7] dt-bindings: input: matrix_keypad - add missing property Markus Burri
2024-11-05 18:22 ` Conor Dooley
2024-11-05 19:14 ` Dmitry Torokhov
2024-11-06 16:24 ` Conor Dooley
2024-11-05 13:03 ` [PATCH v2 5/7] dt-bindings: input: matrix_keypad - add settle time after enable all columns Markus Burri
2024-11-11 21:38 ` Rob Herring
2024-11-05 13:03 ` Markus Burri [this message]
2024-11-05 13:03 ` [PATCH v2 7/7] Input: matrix_keypad - detect change during scan Markus Burri
2024-11-05 19:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241105130322.213623-7-markus.burri@mt.com \
--to=markus.burri@mt.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).