[PATCH] dt-bindings: Enable dtc "interrupt_provider" warnings

[PATCH] dt-bindings: Enable dtc "interrupt_provider" warnings

[Rob Herring (Arm)]

All the warnings from the "interrupt_provider" dtc check are fixed now,
so enable the warning for the examples.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/Makefile            | 1 -
 Documentation/devicetree/bindings/example-schema.yaml | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index bf7d64632e20..8390d6c00030 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -56,7 +56,6 @@ DT_DOCS = $(patsubst $(srctree)/%,%,$(shell $(find_all_cmd)))
 override DTC_FLAGS := \
 	-Wno-avoid_unnecessary_addr_size \
 	-Wno-graph_child_address \
-	-Wno-interrupt_provider \
 	-Wno-unique_unit_address \
 	-Wunique_unit_address_if_enabled
 
diff --git a/Documentation/devicetree/bindings/example-schema.yaml b/Documentation/devicetree/bindings/example-schema.yaml
index a41f9b9a196b..484f8babcda4 100644
--- a/Documentation/devicetree/bindings/example-schema.yaml
+++ b/Documentation/devicetree/bindings/example-schema.yaml
@@ -262,4 +262,5 @@ examples:
         reg-names = "core", "aux";
         interrupts = <10>;
         interrupt-controller;
+        #interrupt-cells = <2>;
     };
-- 
2.45.2

Re: [PATCH] dt-bindings: Enable dtc "interrupt_provider" warnings

[Rob Herring (Arm)]

On Tue, 05 Nov 2024 15:32:32 -0600, Rob Herring (Arm) wrote:
> All the warnings from the "interrupt_provider" dtc check are fixed now,
> so enable the warning for the examples.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/Makefile            | 1 -
>  Documentation/devicetree/bindings/example-schema.yaml | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.example.dts:27.33-39.11: Warning (interrupt_provider): /example-0/msi-controller@5d270000: Missing '#interrupt-cells' in interrupt provider
Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dts:22.55-31.15: Warning (interrupt_provider): /example-0/bus/msi-controller@33d00000: Missing '#interrupt-cells' in interrupt provider
Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Documentation/devicetree/bindings/usb/cypress,cypd4226.example.dts:20.13-50.11: Warning (interrupt_provider): /example-0/i2c: '#interrupt-cells' found, but node is not an interrupt provider
Documentation/devicetree/bindings/usb/cypress,cypd4226.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.example.dts:26.14-48.11: Warning (interrupt_provider): /example-0/pmic: '#interrupt-cells' found, but node is not an interrupt provider
Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Documentation/devicetree/bindings/pci/snps,dw-pcie.example.dts:24.23-47.11: Warning (interrupt_provider): /example-0/pcie@dfc00000: '#interrupt-cells' found, but node is not an interrupt provider
Documentation/devicetree/bindings/pci/snps,dw-pcie.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Documentation/devicetree/bindings/gpio/st,nomadik-gpio.example.dts:24.23-33.11: Warning (interrupt_provider): /example-0/gpio@8012e080: Missing '#interrupt-cells' in interrupt provider
Documentation/devicetree/bindings/gpio/st,nomadik-gpio.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241105213232.443192-1-robh@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH] dt-bindings: Enable dtc "interrupt_provider" warnings

[Rob Herring]

On Tue, Nov 5, 2024 at 4:26 PM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Tue, 05 Nov 2024 15:32:32 -0600, Rob Herring (Arm) wrote:
> > All the warnings from the "interrupt_provider" dtc check are fixed now,
> > so enable the warning for the examples.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/Makefile            | 1 -
> >  Documentation/devicetree/bindings/example-schema.yaml | 1 +
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.example.dts:27.33-39.11: Warning (interrupt_provider): /example-0/msi-controller@5d270000: Missing '#interrupt-cells' in interrupt provider
> Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
> Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dts:22.55-31.15: Warning (interrupt_provider): /example-0/bus/msi-controller@33d00000: Missing '#interrupt-cells' in interrupt provider
> Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
> Documentation/devicetree/bindings/usb/cypress,cypd4226.example.dts:20.13-50.11: Warning (interrupt_provider): /example-0/i2c: '#interrupt-cells' found, but node is not an interrupt provider
> Documentation/devicetree/bindings/usb/cypress,cypd4226.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
> Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.example.dts:26.14-48.11: Warning (interrupt_provider): /example-0/pmic: '#interrupt-cells' found, but node is not an interrupt provider
> Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
> Documentation/devicetree/bindings/pci/snps,dw-pcie.example.dts:24.23-47.11: Warning (interrupt_provider): /example-0/pcie@dfc00000: '#interrupt-cells' found, but node is not an interrupt provider
> Documentation/devicetree/bindings/pci/snps,dw-pcie.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
> Documentation/devicetree/bindings/gpio/st,nomadik-gpio.example.dts:24.23-33.11: Warning (interrupt_provider): /example-0/gpio@8012e080: Missing '#interrupt-cells' in interrupt provider
> Documentation/devicetree/bindings/gpio/st,nomadik-gpio.example.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'

These are all fixed in linux-next.

Rob