From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EA836D; Wed, 6 Nov 2024 18:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730918020; cv=none; b=M2oidLbcqhUPGZx7nPoXuU0QmhhssuIY3uyTH3Ee/NxA0zJy3CsAoPJFs1u1w6rcdiArX7/mtBSvQ5nrCr8x+tEicxiVkwNgunc9kzSR1bphgcqmm0QrqnGznABWxTyBx8Ih2SVekOuD2TGLcU7HH2024W7EmNCUFcXLy5vRDZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730918020; c=relaxed/simple; bh=y2p9ZXBMTA9Kxb0m1NNUcP0JaTs+i1CzMOB0sUQFJ88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BhlLdFJs5F/s5Pp+eoMmPoR/937V92mkhxOoKIU00UeXq+by0PYlURNRC2E6nQE935puBcwxC7A7fDqrEMQbT62TmBByicEkJZ88D2HY0074javK8UK6y4D8uctURZmNdLjL9OoSokAZsFLQhhezcal6pZ2Ia8qR6kCMi7V5eAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j2kbkIVV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j2kbkIVV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0069C4CEC6; Wed, 6 Nov 2024 18:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730918020; bh=y2p9ZXBMTA9Kxb0m1NNUcP0JaTs+i1CzMOB0sUQFJ88=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j2kbkIVVWaM3yO7REJyQCuGZCGdvolulDmtWYZJ0519Ine255Oc+aU0EfsQBl5qnz ZhVvIX8tYeXL5CG1bDHiVCtWL6JSaB9HWVHfUZgUiwPJfC3+tN7AjLZr7YrAWJ+9zX huQL2/Vw2aWIHmrd1fWltvMnj2gEnIql62lTQCRJnygS54B5HtRx26fqV7u5QrhlRE nqXaQ+4jXROb6fWlsgz5HtTGJ6fPPGDPclGFwzEWUO6JQ/QMcXNJw4QeoYDHK+2QlK Y9qWRWt5TDUSMbESUMfXKUu6tXKgV3nzYV8Se/Bv1/RUunU692C2eKh45GN3w2Mxqd NfilyF32y3EWg== Date: Wed, 6 Nov 2024 18:33:34 +0000 From: Conor Dooley To: Matt Coster Cc: Frank Binns , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Randolph Sapp , Darren Etheridge Subject: Re: [PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings Message-ID: <20241106-motivator-mama-5a9d8d14aece@spud> References: <20241105-sets-bxs-4-64-patch-v1-v1-0-4ed30e865892@imgtec.com> <20241105-sets-bxs-4-64-patch-v1-v1-8-4ed30e865892@imgtec.com> <20241105-sulfite-justness-d7b7fb98905c@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uwRbB0EuidyiYIep" Content-Disposition: inline In-Reply-To: --uwRbB0EuidyiYIep Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 06, 2024 at 10:18:10AM +0000, Matt Coster wrote: > On 05/11/2024 18:03, Conor Dooley wrote: > > On Tue, Nov 05, 2024 at 03:58:14PM +0000, Matt Coster wrote: > >> + / { > >> + #address-cells =3D <2>; > >> + #size-cells =3D <2>; > >> + interrupt-controller; > >> + #interrupt-cells =3D <3>; > >> + > >> + gpu@4e20000000 { > >> + compatible =3D "ti,j721s2-gpu", "img,img-bxs-4-64", "img,= img-rogue"; > >> + reg =3D /bits/ 64 <0x4e2000 0000 0x80000>; > >=20 > > Can you format this normally please? Drop the #address/size-cells down > > to 1 if you're against having 0x0s. >=20 > Sure. I thought /bits/ was the "new" way of doing things, but I'm not > really bothered either way. Maybe in other cases, I've never seen it for reg. The dts coding style examples even have 0x0s in them. For other properties, sure this might be the "new" way of doing it but not for reg, probably in part because it makes it difficult to see if the number matches the number of cells in #address/size-cells. --uwRbB0EuidyiYIep Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZyu2fgAKCRB4tDGHoIJi 0kWlAP9yWsCojC2B4lhypgsjcV7rscFmE6WzqejRkjQrCUmWsgD/bTWjxUFQ+uvC x36sUGD0EDrdVAQB+gNiLRi+EDhv7Ag= =VsBN -----END PGP SIGNATURE----- --uwRbB0EuidyiYIep--