From: Lee Jones <lee@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: pavel@ucw.cz, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@salutedevices.com
Subject: Re: [RESEND PATCH v2 0/2] leds: pwm: Add default-brightness property
Date: Wed, 6 Nov 2024 10:54:55 +0000 [thread overview]
Message-ID: <20241106105455.GQ1807686@google.com> (raw)
In-Reply-To: <20241105185006.1380166-1-gnstark@salutedevices.com>
On Tue, 05 Nov 2024, George Stark wrote:
> led-pwm driver supports default-state DT property and if that state is on then
> the driver during initialization turns on the LED setting maximum brightness.
> Sometimes it's desirable to use lower initial brightness.
> This patch series adds support for DT property default-brightness.
>
> Things to discuss:
> If such a property is acceptable it could be moved to leds/common.yaml due to
> several drivers support multiple brightness levels and could support the property
> too.
>
> Changes in v2:
> leds: pwm: Add optional DT property default-brightness
> - refactor patch to make it more accurate
> link to v1: [1]
>
> [1] https://lore.kernel.org/lkml/20241015151410.2158102-3-gnstark@salutedevices.com/T/
>
> George Stark (2):
> dt-bindings: leds: pwm: Add default-brightness property
> leds: pwm: Add optional DT property default-brightness
>
> .../devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++
> drivers/leds/leds-pwm.c | 17 ++++++++++++++++-
> 2 files changed, 22 insertions(+), 1 deletion(-)
The set doesn't apply. Please rebase it.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-11-06 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 18:50 [RESEND PATCH v2 0/2] leds: pwm: Add default-brightness property George Stark
2024-11-05 18:50 ` [RESEND PATCH v2 1/2] dt-bindings: " George Stark
2024-11-05 18:50 ` [RESEND PATCH v2 2/2] leds: pwm: Add optional DT property default-brightness George Stark
2024-11-12 12:14 ` (subset) " Lee Jones
2024-11-06 10:54 ` Lee Jones [this message]
2024-11-12 12:14 ` [RESEND PATCH v2 0/2] leds: pwm: Add default-brightness property Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106105455.GQ1807686@google.com \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gnstark@salutedevices.com \
--cc=kernel@salutedevices.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).