From: Andreas Kemnade <andreas@kemnade.info>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sre@kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Date: Mon, 11 Nov 2024 11:31:17 +0100 [thread overview]
Message-ID: <20241111113117.2392d4d8@akair> (raw)
In-Reply-To: <bf50b6c0-af1a-4c7f-9c3e-ffbd3da87a80@gmail.com>
Am Mon, 4 Nov 2024 08:06:53 +0200
schrieb Matti Vaittinen <mazziesaccount@gmail.com>:
> On 01/11/2024 21:27, Rob Herring wrote:
> > On Tue, Oct 29, 2024 at 12:11:12PM +0100, Andreas Kemnade wrote:
> >> Apparently there was some confusion regarding milliohm vs. megaohm.
> >> (m/M). Use microohms to be able to properly specify the charger
> >> resistor like other drivers do. This is not used yet by mainline code
> >> yet. Specify a current sense resistor in milliohms range rathes then
> >> megaohms range in the examples.
> >
> > milliohms?
> >
> > rathes?
> >
> >>
> >> CC: sre@kernel.org
> >> Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
> >> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d
> >> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> >> ---
> >> .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 13 +++++++------
> >> 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > Looks like rohm,bd71815-pmic.yaml has the same problem.
>
> Yes! Thanks for pointing it out. I'll wait for a while if Andreas wants
> to fix them both at the same go. I'll send a fix for BD71815 if I've not
> seen one in a week or so :)
>
There is more debris left from an apparently copy-paste-modify process
from bd71828. That should be checked. At least there are several
occurances of the BD71828 string in there. So a brush is needed.
Regards,
Andreas
next prev parent reply other threads:[~2024-11-11 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 11:11 [PATCH] dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm Andreas Kemnade
2024-10-29 13:00 ` Matti Vaittinen
2024-11-01 19:27 ` Rob Herring
2024-11-04 6:06 ` Matti Vaittinen
2024-11-11 10:31 ` Andreas Kemnade [this message]
2024-11-12 5:42 ` Matti Vaittinen
2024-11-04 9:00 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241111113117.2392d4d8@akair \
--to=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).