[PATCH 0/3] arm64: dts: qcom: Pixel 3a Flash LEDs

[PATCH 0/3] arm64: dts: qcom: Pixel 3a Flash LEDs

[Richard Acayan]

This adds support for the flash LEDs on PM660L and enables it on the
Pixel 3a as an initial user.

Richard Acayan (3):
  dt-bindings: leds: qcom,spmi-flash-led: add pm660l compatible
  arm64: dts: qcom: pm660l: add flash leds
  arm64: dts: qcom: sdm670-google-sargo: add flash leds

 .../bindings/leds/qcom,spmi-flash-led.yaml         |  1 +
 arch/arm64/boot/dts/qcom/pm660l.dtsi               |  6 ++++++
 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts   | 14 ++++++++++++++
 3 files changed, 21 insertions(+)

-- 
2.47.0

[PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add pm660l compatible

[Richard Acayan]

Add the compatible for the flash LED controller on the PM660L PMIC.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
index 1ba607685f5f..bcf0ad4ea57e 100644
--- a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
+++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml
@@ -23,6 +23,7 @@ properties:
     items:
       - enum:
           - qcom,pm6150l-flash-led
+          - qcom,pm660l-flash-led
           - qcom,pm8150c-flash-led
           - qcom,pm8150l-flash-led
           - qcom,pm8350c-flash-led
-- 
2.47.0

[PATCH 2/3] arm64: dts: qcom: pm660l: add flash leds

[Richard Acayan]

The PM660L has support for QPNP flash LEDs. Add them to the device tree.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
 arch/arm64/boot/dts/qcom/pm660l.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
index 0094e0ef058b..3f8b9eafe164 100644
--- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
@@ -70,6 +70,12 @@ pm660l_lpg: pwm {
 			status = "disabled";
 		};
 
+		pm660l_flash: led-controller@d300 {
+			compatible = "qcom,pm660l-flash-led", "qcom,spmi-flash-led";
+			reg = <0xd300>;
+			status = "disabled";
+		};
+
 		pm660l_wled: leds@d800 {
 			compatible = "qcom,pm660l-wled";
 			reg = <0xd800>, <0xd900>;
-- 
2.47.0

[PATCH 3/3] arm64: dts: qcom: sdm670-google-sargo: add flash leds

[Richard Acayan]

The Pixel 3a has two identical flash LEDs. Add them together.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
 arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
index 176b0119fe6d..800773a676c0 100644
--- a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
+++ b/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts
@@ -10,6 +10,7 @@
 
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 #include <dt-bindings/power/qcom-rpmpd.h>
 #include "sdm670.dtsi"
@@ -482,6 +483,19 @@ &mdss_mdp {
 	status = "okay";
 };
 
+&pm660l_flash {
+	status = "okay";
+
+	led-0 {
+		function = LED_FUNCTION_FLASH;
+		color = <LED_COLOR_ID_WHITE>;
+		led-sources = <1>, <2>;
+		led-max-microamp = <500000>;
+		flash-max-microamp = <1500000>;
+		flash-max-timeout-us = <1280000>;
+	};
+};
+
 &pm660l_gpios {
 	vol_up_pin: vol-up-state {
 		pins = "gpio7";
-- 
2.47.0

Re: [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add pm660l compatible

[Rob Herring (Arm)]

On Mon, 11 Nov 2024 21:40:52 -0500, Richard Acayan wrote:
> Add the compatible for the flash LED controller on the PM660L PMIC.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
>  Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 3/3] arm64: dts: qcom: sdm670-google-sargo: add flash leds

[Konrad Dybcio]

On 12.11.2024 3:40 AM, Richard Acayan wrote:
> The Pixel 3a has two identical flash LEDs. Add them together.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: (subset) [PATCH 1/3] dt-bindings: leds: qcom,spmi-flash-led: add pm660l compatible

[Lee Jones]

On Mon, 11 Nov 2024 21:40:52 -0500, Richard Acayan wrote:
> Add the compatible for the flash LED controller on the PM660L PMIC.
> 
> 

Applied, thanks!

[1/3] dt-bindings: leds: qcom,spmi-flash-led: add pm660l compatible
      commit: a1234b215538279c8520481f6d539f1582bd17d8

--
Lee Jones [李琼斯]

Re: (subset) [PATCH 0/3] arm64: dts: qcom: Pixel 3a Flash LEDs

[Bjorn Andersson]

On Mon, 11 Nov 2024 21:40:51 -0500, Richard Acayan wrote:
> This adds support for the flash LEDs on PM660L and enables it on the
> Pixel 3a as an initial user.
> 
> Richard Acayan (3):
>   dt-bindings: leds: qcom,spmi-flash-led: add pm660l compatible
>   arm64: dts: qcom: pm660l: add flash leds
>   arm64: dts: qcom: sdm670-google-sargo: add flash leds
> 
> [...]

Applied, thanks!

[2/3] arm64: dts: qcom: pm660l: add flash leds
      commit: 9b2955bae7025190c8d15983b37554da96e43e21
[3/3] arm64: dts: qcom: sdm670-google-sargo: add flash leds
      commit: 44d2a252698effd2f247a31492c10e1290903474

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>