From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5776421CF86; Tue, 12 Nov 2024 10:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731408528; cv=none; b=qd21qqJmmElRqo8ojXhuW6w60O2LuoOLah6vV4lGTejz7o/ihfBsVPMSM/P6sGMc3UVXmHRqZXFDYcqOGUM6Mquu/bt9q/aqvMI0Lkxt2p9HvwFZx2AFY8Lm1Frnl6inPx3Ag2gw0EIHhF3J8WmMAprPimyzdLpZLMEGqxNfPu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731408528; c=relaxed/simple; bh=Rlz9/2w3HuGHPx/1Dx6dMSeAHh6+zlOAnHthXakqKJ4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d+wxFEPST5Ua9G2imtY5gPmu/raZSUw7lmZBvPgHQUhG/SMRjxcQKzA//Kzt6f1wTHY+Z2ohooSqsHoW/OuzLTstD66/GmeLrwQFNBgOckKFU/CTS2Q3e8/lQ+ywik9wlXNylXULRWfDcsjiSJe0azdb47AMa7tG3qUtRPQS4Q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=9oMiat9a; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="9oMiat9a" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Cc:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=2m7yLhxfZDBBcaSm+o4e0Z6YDFzbc2KbJ1HEoJJMrgE=; b=9oMiat9aS3OnXG3WvYQ6dodxHB c3IKeiuhoIjkbP/vFCRnyEKdsl90Q82eNInauL9GoJFDN6sN/smTp40tdct7YHbmusIztadZeNmT1 cMA32aoHjjpu+yKHPZr3sMJE0SXKKv8n09FgEm6HNwnVZ3xYBr/QG8Q0PEvXAJ60wd2xK7/g/atl1 5cidNMeMHYtCv1CxH09N+J4oAvA2DozhbCpxbtemIOZsxhUpKlrGweu3bj2lRyvOONLu+cZs+FZJn 0/eXYnZJRXoVFmduzywld+K6DGYhoeTbfRx/GqN6A460Lbv1GK1yxOZxQO8CeeS0eOplhyS4GE/fh v+x5pbSg==; Date: Tue, 12 Nov 2024 11:48:18 +0100 From: Andreas Kemnade To: Mithil Bavishi Cc: Aaro Koskinen , Kevin Hilman , Roger Quadros , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang , Lad Prabhakar , Thierry Reding , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1 Message-ID: <20241112114818.1eb238e9@akair> In-Reply-To: <20241108200440.7562-11-bavishimithil@gmail.com> References: <20241108200440.7562-1-bavishimithil@gmail.com> <20241108200440.7562-11-bavishimithil@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Am Fri, 8 Nov 2024 20:04:39 +0000 schrieb Mithil Bavishi : > Create a device tree for the 10 inch variants (P5100, P5110, P5113) > > Signed-off-by: Mithil Bavishi > --- > .../dts/ti/omap/omap4-samsung-espresso10.dts | 102 ++++++++++++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts > > diff --git a/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts b/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts > new file mode 100644 > index 000000000..70bbef468 > --- /dev/null > +++ b/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts > @@ -0,0 +1,102 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/dts-v1/; > + > +#include "omap4-samsung-espresso-common.dtsi" > +#include > +/ { > + model = "Samsung Galaxy Tab 2 (10 inch)"; > + compatible = "samsung,espresso10", "ti,omap4430", "ti,omap4"; > + > + i2c-gpio-5 { > + smb347: charger@6 { > + compatible = "summit,smb347"; > + reg = <0x6>; // 0x0C >> 1 > + interrupt-parent = <&gpio2>; > + interrupts = <0 IRQ_TYPE_EDGE_BOTH>; > + > + summit,enable-usb-charging; > + summit,enable-charge-control = ; > + summit,chip-temperature-threshold-celsius = <120>; > + summit,usb-current-limit-microamp = <1800000>; > + }; > + }; > + > + backlight: backlight { > + compatible = "pwm-backlight"; > + pinctrl-names = "default"; > + pinctrl-0 = <&backlight_pins>; > + pwms = <&pwm10 0 1600 0>; > + power-supply = <®_lcd>; > + enable-gpios = <&gpio3 31 GPIO_ACTIVE_HIGH>; > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <7>; > + }; > + > + panel { > + compatible = "samsung,ltn101al03", "panel-lvds"; > + power-supply = <®_lcd>; > + width-mm = <223>; > + height-mm = <125>; > + data-mapping = "vesa-24"; > + backlight = <&backlight>; > + > + panel-timing { > + clock-frequency = <69818000>; > + > + hback-porch = <64>; > + hactive = <1280>; > + hfront-porch = <16>; > + hsync-len = <48>; > + > + vback-porch = <11>; > + vactive = <800>; > + vfront-porch = <16>; > + vsync-len = <3>; > + > + hsync-active = <0>; > + vsync-active = <0>; > + de-active = <1>; > + pixelclk-active = <1>; > + }; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&bridge_out>; > + }; > + }; > + }; > +}; > + > +&i2c3 { > + touchscreen: synaptics-rmi4-i2c@20 { touchscreen@20 > + compatible = "syna,rmi4-i2c"; > + reg = <0x20>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + interrupt-parent = <&gpio2>; > + interrupts = <14 IRQ_TYPE_EDGE_FALLING>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&touch_pins>; > + > + avdd-supply = <®_touch_ldo_en>; not known in schema > + vdd-supply = <&ldo6>; > + > + syna,reset-delay-ms = <200>; > + syna,startup-delay-ms = <200>; > + > + touchscreen-size-x = <1279>; Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml: horizontal resolution of touchscreen (maximum x coordinate reported + 1) So this touchscreen reports max 1278? > + touchscreen-size-y = <799>; same question. And these things belong below rm4-f11 according to Documentation/devicetree/bindings/input/syna,rmi4.yaml Regards, Andreas