public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Philipp Rosenberger <p.rosenberger@kunbus.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	"Lino Sanfilippo" <l.sanfilippo@kunbus.com>,
	"Thomas Böhler" <t.boehler@kunbus.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: rtc: pcf2127: Add nxp,battery-backed flag
Date: Tue, 12 Nov 2024 10:40:06 -0600	[thread overview]
Message-ID: <20241112164006.GB1151895-robh@kernel.org> (raw)
In-Reply-To: <20241111154144.163604-2-p.rosenberger@kunbus.com>

On Mon, Nov 11, 2024 at 04:41:43PM +0100, Philipp Rosenberger wrote:
> This commit introduces the nxp,battery-backed property to the
> nxp,pcf2127 Device Tree bindings. This flag indicates that the
> RTC is battery-backed and forces the driver to enable the
> battery switch-over function, but only if no other mode is already
> configured.
> 
> With the PCF2131, the battery switch-over is disabled by default.
> If the battery switch-over is not enabled by the bootloader or
> firmware, this property ensures that the RTC can function correctly
> when powered by the battery.
> 
> Signed-off-by: Philipp Rosenberger <p.rosenberger@kunbus.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index 2d9fe5a75b06..87ba16346fb4 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -30,6 +30,13 @@ properties:
>  
>    reset-source: true
>  
> +  nxp,battery-backed:
> +    description: |
> +      Indicates that the RTC is battery-backed. This property forces
> +      the driver to enable the battery switch-over function, but only if
> +      no other mode is already configured.
> +    $ref: /schemas/types.yaml#/definitions/flag

Seems like something that would be a common property? I didn't find any 
prior art though.

Rob

  reply	other threads:[~2024-11-12 16:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-11 15:41 [PATCH v3 0/2] rtc: pcf2127: make battery switch-over configurable Philipp Rosenberger
2024-11-11 15:41 ` [PATCH v3 1/2] dt-bindings: rtc: pcf2127: Add nxp,battery-backed flag Philipp Rosenberger
2024-11-12 16:40   ` Rob Herring [this message]
2024-11-11 15:41 ` [PATCH v3 2/2] rtc: pcf2127: Add 'nxp,battery-switchover' DT property to enable battery switch-over Philipp Rosenberger
2024-11-11 18:27   ` Christophe JAILLET
2024-11-12 16:38   ` Rob Herring
2024-11-14  8:51 ` [PATCH v3 0/2] rtc: pcf2127: make battery switch-over configurable Alexandre Belloni
2024-11-27 12:58   ` Philipp Rosenberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241112164006.GB1151895-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=krzk+dt@kernel.org \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=p.rosenberger@kunbus.com \
    --cc=t.boehler@kunbus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox