Re: [PATCH v5 13/14] PCI: rockchip-ep: Handle PERST# signal in endpoint mode

Bjorn Helgaas
2024-12-15T00:13:15Z

On Thu, Oct 17, 2024 at 10:58:48AM +0900, Damien Le Moal wrote:
> Currently, the Rockchip PCIe endpoint controller driver does not handle
> the PERST# signal, which prevents detecting when link training should
> actually be started or if the host resets the device. This however can
> be supported using the controller reset_gpios property set as an input
> GPIO for endpoint mode.

> @@ -50,6 +51,9 @@ struct rockchip_pcie_ep {
> u64 irq_pci_addr;
> u8 irq_pci_fn;
> u8 irq_pending;
> + int perst_irq;
> + bool perst_asserted;
> + bool link_up;
> struct delayed_work link_training;
> };

I should have caught this last cycle, but just noticed this:

$ make W=1 -k drivers/pci/ drivers/misc/pci_*
...
CC drivers/pci/controller/pcie-rockchip-ep.o
drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_irq' not described in 'rockchip_pcie_ep'
drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'perst_asserted' not described in 'rockchip_pcie_ep'
drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_up' not described in 'rockchip_pcie_ep'
drivers/pci/controller/pcie-rockchip-ep.c:59: warning: Function parameter or struct member 'link_training' not described in 'rockchip_pcie_ep'