Re: [PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add compatible string 'nxp,fxls8967af'

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

On Wed, Nov 13, 2024 at 12:54:39PM -0500, Frank Li wrote:
> From: Han Xu <han.xu@nxp.com>
> 
> Add compatible string 'nxp,fxls8967af' for the NXP FXLS8967AF accelerometer
> sensor.
> 
> Signed-off-by: Han Xu <han.xu@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
> index 783c7ddfcd90a..c375ef1bd083f 100644
> --- a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
> @@ -14,12 +14,16 @@ description: |
>    SPI and I2C interface.
>      https://www.nxp.com/docs/en/data-sheet/FXLS8962AF.pdf
>      https://www.nxp.com/docs/en/data-sheet/FXLS8964AF.pdf
> +    https://www.nxp.com/docs/en/data-sheet/FXLS8967AF.pdf
>  
>  properties:
>    compatible:
> +    description:
> +      These chips are compatible with each other, just have different IDs.

Then there should be a fallback. Please remove this description and add
the new device with a fallback to an existing one.

>      enum:
>        - nxp,fxls8962af
>        - nxp,fxls8964af
> +      - nxp,fxls8967af
>  
>    reg:
>      maxItems: 1
> 
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]