Re: [PATCH] dt-bindings: mfd: omap-usb-tll: convert to YAML

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

On Thu, Nov 14, 2024 at 07:58:30PM +0100, Karol Przybylski wrote:
> diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-tll.yaml b/Documentation/devicetree/bindings/mfd/omap-usb-tll.yaml
> new file mode 100644
> index 000000000000..f49417d1faf7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/omap-usb-tll.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/omap-usb-tll.yaml#

ti,usbhs-tll.yaml as the filename please.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OMAP HS USB Host TLL (Transceiver-Less Interface)
> +
> +maintainers:
> +  - <maintainer@kernel.org>

Put whoever the original author of the binding was here, failing that
probably the platform maintainers for omap.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,usbhs-tll
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ti,hwmod:

Pretty sure you need a type here:
    $ref: /schemas/types.yaml#/definitions/string

> +    const: usb_tll_hs
> +
> +  clocks:
> +    minItems: 2

Please add an items list here for each clock with a description.

Where did the minItems: 2 come from? The text binding suggests that 1
would be valid.


Cheers,
Conor.

> +
> +  clock-names:
> +    items:
> +      - const: usb_tll_hs_usb_ch0_clk
> +      - const: usb_tll_hs_usb_ch1_clk
> +      - const: usb_tll_hs_usb_ch2_clk
> +    minItems: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - ti,hwmod
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usbhstll@4a062000 {
> +      compatible = "ti,usbhs-tll";
> +      reg = <0x4a062000 0x1000>;
> +      interrupts = <78>;
> +      ti,hwmod = "usb_tll_hs";
> +    };
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]