From: Conor Dooley <conor@kernel.org>
To: cleverline1mc@gmail.com
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Stefan Wahren <stefan.wahren@chargebyte.com>,
Ben Gardner <bgardner@wabtec.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property
Date: Fri, 15 Nov 2024 18:16:32 +0000 [thread overview]
Message-ID: <20241115-happy-garter-2cf65f4b1290@spud> (raw)
In-Reply-To: <20241115-ds2482-add-reg-v1-3-cc84b9aba126@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
On Fri, Nov 15, 2024 at 03:58:06PM +0100, Kryštof Černý via B4 Relay wrote:
> From: Kryštof Černý <cleverline1mc@gmail.com>
>
> Adds the newly added vcc-supply property to bindings.
This commit message is a circular argument. You're adding it to the
binding, which of course means it is newly added.
>
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
> ---
> Documentation/devicetree/bindings/w1/maxim,ds2482.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> index 422becc6e1fa8d58665c5586ebdc611cd0b2c760..a6b9e0658ec858cb24b21cf64443a061bb43e4ef 100644
> --- a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> +++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> @@ -25,6 +25,9 @@ properties:
> reg:
> maxItems: 1
>
> + vcc-supply:
> + description: phandle of the regulator that provides the supply voltage.
"vcc-supply: true" should suffice.
> +
> required:
> - compatible
> - reg
>
> --
> 2.39.5
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-11-15 18:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 14:58 [PATCH 0/3] Add support for attaching a regulator to w1: ds2482 Kryštof Černý via B4 Relay
2024-11-15 14:58 ` [PATCH 1/3] w1: ds2482: Add regulator support Kryštof Černý via B4 Relay
2024-11-15 14:58 ` [PATCH 2/3] w1: ds2482: Fix datasheet URL Kryštof Černý via B4 Relay
2024-11-15 14:58 ` [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property Kryštof Černý via B4 Relay
2024-11-15 18:16 ` Conor Dooley [this message]
2024-11-20 8:34 ` Kryštof Černý
2024-11-20 8:48 ` Krzysztof Kozlowski
2024-11-20 22:53 ` Kryštof Černý
2024-11-21 7:43 ` Krzysztof Kozlowski
2024-11-21 15:56 ` Kryštof Černý
2024-11-21 16:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115-happy-garter-2cf65f4b1290@spud \
--to=conor@kernel.org \
--cc=bgardner@wabtec.com \
--cc=cleverline1mc@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stefan.wahren@chargebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox