From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A642C185949 for ; Fri, 15 Nov 2024 06:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653665; cv=none; b=kldd7zB7fJC2r08r7j5D6RS9I4X7G6RmSXF9+Ey0h/hngEO2Nh3eioUXzUWJjrpzypBrwCURPv4UgCB5rAiGdGabnKNu8a/GTdXS9FQb+rRMYHq5FusOWCP5kFmlfkLoTEYJdijEQjanDg1WFJzjoHS35K32eChujfxXWr/Xcw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653665; c=relaxed/simple; bh=x/2VSAbk+bd/qDKumw5Nythdu6G/pN92DH/s7nEgFDo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q+m4OUA12DzVVWiVUps/HBclsL+7q5dg4spXpY6Q2GHrXuyrG/HEod2K8QWw33lIghGXqwdTFLMpkwONRBu40MQzeDSSUn1utRsb3oq85CJncClShNNisBw6pspjyJm4Z3JWU+6jvcK6ULY1bUYx5Q38Ef6qwzg0HVz/fWyO/sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bB7zh8A+; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bB7zh8A+" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-29066daf9e2so747359fac.3 for ; Thu, 14 Nov 2024 22:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731653663; x=1732258463; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=VpIhQ9mb9ycFkMd8PQ/S0ZDiIrP7seI2TZz9r3I3eW0=; b=bB7zh8A+4YNHlnJRWHl0AdwOyZLUqD7YAhPZs0D85RbtFhEJMiGiPiL9aj+pd5igsA 8yLgjwev/I9f//Pw4ncgEL+FDHxn6igllRoeiDgJ4yy6EdpqyCsT9znBq5d+rRV+Q3qB BrfVQ1T6bbH1nhxEha4jzzNYgIw7W9+kLhPpRskE1kRHoI9r7VHTlcDwAaLN0/+GA2Os B22qix1W796c+ZF+XCd3/PpijbV2EqgNkXdbGaalzq6EIk/RUVxIYZb2fhdSvvhbs+92 uTO2bTffO2jUJuhphPhaHpbQoKxnvacA85Sw2FF92nvYw9EUhMXP29QmJNl8+FMMCeYO pFDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731653663; x=1732258463; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VpIhQ9mb9ycFkMd8PQ/S0ZDiIrP7seI2TZz9r3I3eW0=; b=GeqdX0VoyHyHq/y6i6Z9zfb2y7vRY5vLtDRJ7L3HOhbGzu6ScT4/NdMmfW+S0atxkA bLVqmtI96BG+7K7smDiG2+H35ValrAtJg5jA/owYNpcj/2um7eVXnBH0wZLOC6tR8bRY 55TNhlRfKWWhL5wez+tHJND7XcwHAD2jc5FaRia9E8cSekiF4FxEacUbG3yt9L2jBE8R A9uMuyjV13RE59/Hh0jqtV4XWgfuPSxMW8zQNYBdiGA3OSsPu5dch5/8AsfSrowRL1W7 ZtsrgInlkQrv4/pl8d1ahuMHCBdYLi4+Tkg3SoKlTGVZ3zir79MyMS8jltdBWfSiRHnl Jv6Q== X-Forwarded-Encrypted: i=1; AJvYcCU3DUkqC7N/6o1cdf0QJwACuFk7ko6s91+6CI39Rr2eBGJzJDlC8feNqjdRiQAHtF6LVlWwaRWZ0/cU@vger.kernel.org X-Gm-Message-State: AOJu0YxHo8/yVYkirtkXWmZOizCSxGhvgpW2Yh7Yabh5kaqF7r5jGyme AwE8cyg3kB2hFu50qjo+tI4XlW/auIUANuAnfnb86wXgcx6PZ4fgF1y26uxtLg== X-Google-Smtp-Source: AGHT+IGA2wP5EZO//DczjdnLKwXL89OrzkosGXPzS/O5S6Z8HF8QEOaPag4uwMWdG7hB0NyuZCDjFw== X-Received: by 2002:a05:6871:691:b0:270:27e6:6f1a with SMTP id 586e51a60fabf-2962e2a0d04mr1279132fac.41.1731653662715; Thu, 14 Nov 2024 22:54:22 -0800 (PST) Received: from thinkpad ([117.193.208.47]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f8c1c3224asm650735a12.29.2024.11.14.22.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 22:54:22 -0800 (PST) Date: Fri, 15 Nov 2024 12:24:12 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, frank.li@nxp.com, s.hauer@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 06/10] PCI: imx6: Fix the missing reference clock disable logic Message-ID: <20241115065412.l2r5vmqaw3ufcjo3@thinkpad> References: <20241101070610.1267391-1-hongxing.zhu@nxp.com> <20241101070610.1267391-7-hongxing.zhu@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241101070610.1267391-7-hongxing.zhu@nxp.com> On Fri, Nov 01, 2024 at 03:06:06PM +0800, Richard Zhu wrote: > Ensure the *_enable_ref_clk() function is symmetric by addressing missing > disable parts on some platforms. > > Fixes: d0a75c791f98 ("PCI: imx6: Factor out ref clock disable to match enable") > Signed-off-by: Richard Zhu Reviewed-by: Manivannan Sadhasivam - Mani > Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 54039d2760d5..bb130c84c016 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -595,10 +595,9 @@ static int imx_pcie_attach_pd(struct device *dev) > > static int imx6sx_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable) > { > - if (enable) > - regmap_clear_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > - IMX6SX_GPR12_PCIE_TEST_POWERDOWN); > - > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > + IMX6SX_GPR12_PCIE_TEST_POWERDOWN, > + enable ? 0 : IMX6SX_GPR12_PCIE_TEST_POWERDOWN); > return 0; > } > > @@ -627,19 +626,20 @@ static int imx8mm_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable) > { > int offset = imx_pcie_grp_offset(imx_pcie); > > - if (enable) { > - regmap_clear_bits(imx_pcie->iomuxc_gpr, offset, IMX8MQ_GPR_PCIE_CLK_REQ_OVERRIDE); > - regmap_set_bits(imx_pcie->iomuxc_gpr, offset, IMX8MQ_GPR_PCIE_CLK_REQ_OVERRIDE_EN); > - } > - > + regmap_update_bits(imx_pcie->iomuxc_gpr, offset, > + IMX8MQ_GPR_PCIE_CLK_REQ_OVERRIDE, > + enable ? 0 : IMX8MQ_GPR_PCIE_CLK_REQ_OVERRIDE); > + regmap_update_bits(imx_pcie->iomuxc_gpr, offset, > + IMX8MQ_GPR_PCIE_CLK_REQ_OVERRIDE_EN, > + enable ? IMX8MQ_GPR_PCIE_CLK_REQ_OVERRIDE_EN : 0); > return 0; > } > > static int imx7d_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable) > { > - if (!enable) > - regmap_set_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > - IMX7D_GPR12_PCIE_PHY_REFCLK_SEL); > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > + IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, > + enable ? 0 : IMX7D_GPR12_PCIE_PHY_REFCLK_SEL); > return 0; > } > > -- > 2.37.1 > -- மணிவண்ணன் சதாசிவம்