From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42EB515FD13 for ; Fri, 15 Nov 2024 06:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653832; cv=none; b=M75BJhL/NsEnQRIrU97mzvTsRTo+3x4pHIZd4CDP2x3+qqKak1B/24JHDbt8NTO3qPh0dhxJis1VhHeo95/rZ+QjQmBE264A35NoiplCSRU+chDmOu8FbLxwX6tUIbSSxUpQGV+tzn2g539cGmLm0unSJXs1ArbwgKIiPS4M4hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731653832; c=relaxed/simple; bh=dpza+eGWv/xmHMp57zlEEJfK0Yeu8rMvSSrLh34VFDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lh31iH9M2HI8SP/kIQbIHDBd+H/RyY/N2S+5U2Wdj09cmVSUIImamq42oW+blwkuDcSVATY7Wife594B3igD2oz5iLMuFbRHYTrN/3ChgKKFiYXPnmCTmXxBVE+0bzKpcFJu2oUS0x++/tPluH4hbQJacS+DlyZy9b/+btLQPrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JitGXi/u; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JitGXi/u" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20c7ee8fe6bso16042815ad.2 for ; Thu, 14 Nov 2024 22:57:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731653829; x=1732258629; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UUnANkLZ+cRlOTdO0AUsRhtlxHbXsgSkLLst9mQNAEg=; b=JitGXi/u/it8tPmt2uOffpcJAhZ1XPE2T9k84e7JbXJstvimJeKlZkKQ1S5PQ3vHmM W/3KEvY+l//FOw18pAVM9uw5c6FPbrXQdGcwZAVQurpvVZM5vnouYTXMIyh+dmL8V6Mn F32DFDL3kzc6iv3ER2/xl/BH3ok9YCkbBI64Iyfkt0RhGUMTdJyvs5B9Sm7nSTk9vcdJ YJ/eWUsbvkkOOJ0RHhdEFh97dmv7rgB0fXUj6JrUIGvTukKkNUQ/xixkF+BQAYOMWju2 saSv2KvqW19v6AqYkWBaiyzuWuLuSnbOFZIahinCGlAS2ec4FDdYDDiVZ8CghEMouz7s M97A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731653829; x=1732258629; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UUnANkLZ+cRlOTdO0AUsRhtlxHbXsgSkLLst9mQNAEg=; b=mIuH5jF/8IT8wAbqplJd60jvot/ilITgDrOuBJDHiCl7M1HrAwdLIj1LkpKOlTyQ7S C7KTwUMUDOR7YMhpWWNwEThSKlXTKE/sInlAZk5i+AOWzRMV2GkofsgPTEQJ6y+yzyZb jcXrXmkcbMObt47MchKd8h54iaMav28CREg9QTHTfcOj5K3BKB0riy1eKe+roPax+FGl TDx/xbBYmH4k9TV3nrltu8ecrhTXmpWPcwTraPM0kO92pPspYDVpoqUXpt4p5C1b/9Gk uwc4977kFhNmcOFrVgYX12bebLzv4jaio+ieJ1xQgfAUkUQZL9F9XKxmnz1xVcegfLsC rfGg== X-Forwarded-Encrypted: i=1; AJvYcCXWhyXYTcUT+x+fvbYbQrcRlyZmrABqcJg2q8nfVSc+h+NXhSvLw50VHT+NsoZBv+6UctRdbyyvqBtp@vger.kernel.org X-Gm-Message-State: AOJu0YyN/YjtGcgrCBLZly6CwclzFxEVqLHEZU1VmOqJUvMtWy677IuK m38d1U0GiQUVPwYgOBEQk0lXNIQEHUNWFueZ2BukFdqylsMsHrvBlPYI9r+Uow== X-Google-Smtp-Source: AGHT+IGyxlQ3XKDLt3Kpg+bOwQr2O6U0ym9WxGmFcCu7LdeG9Tf0de/64JRmH23hKPfODvd+Dxxf8w== X-Received: by 2002:a17:902:d48c:b0:20c:94f6:3e03 with SMTP id d9443c01a7336-211d0ed2e36mr24090375ad.47.1731653829586; Thu, 14 Nov 2024 22:57:09 -0800 (PST) Received: from thinkpad ([117.193.208.47]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0f34698sm6210935ad.133.2024.11.14.22.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 22:57:08 -0800 (PST) Date: Fri, 15 Nov 2024 12:27:00 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, frank.li@nxp.com, s.hauer@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 07/10] PCI: imx6: Clean up codes by removing imx7d_pcie_init_phy() Message-ID: <20241115065700.gfz7dmoijhh43lhd@thinkpad> References: <20241101070610.1267391-1-hongxing.zhu@nxp.com> <20241101070610.1267391-8-hongxing.zhu@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241101070610.1267391-8-hongxing.zhu@nxp.com> On Fri, Nov 01, 2024 at 03:06:07PM +0800, Richard Zhu wrote: > Remove the duplicate imx7d_pcie_init_phy() function as it is the same as > imx7d_pcie_enable_ref_clk(). > How about. "PCI: imx6: Remove imx7d_pcie_init_phy() function" This function essentially duplicates imx7d_pcie_enable_ref_clk(). So remove it." > Signed-off-by: Richard Zhu With above change, Reviewed-by: Manivannan Sadhasivam - Mani > Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index bb130c84c016..fde2f4eaf804 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -390,13 +390,6 @@ static int imx8mq_pcie_init_phy(struct imx_pcie *imx_pcie) > return 0; > } > > -static int imx7d_pcie_init_phy(struct imx_pcie *imx_pcie) > -{ > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0); > - > - return 0; > -} > - > static int imx_pcie_init_phy(struct imx_pcie *imx_pcie) > { > regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > @@ -1526,7 +1519,6 @@ static const struct imx_pcie_drvdata drvdata[] = { > .clks_cnt = ARRAY_SIZE(imx6q_clks), > .mode_off[0] = IOMUXC_GPR12, > .mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE, > - .init_phy = imx7d_pcie_init_phy, > .enable_ref_clk = imx7d_pcie_enable_ref_clk, > .core_reset = imx7d_pcie_core_reset, > }, > -- > 2.37.1 > -- மணிவண்ணன் சதாசிவம்