[PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100

[PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

X1 has multiple DWC3 hosts, including one that's USB2, which naturally
means it doesn't have a SuperSpeed interrupt. Make it optional to fix
warnings such as:

usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 935e204b607bbd3bc9bfbdcd03519202197c9eb4..98bb82c795d4589c2aa55ebe8168e3e681d1d41b 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -453,8 +453,10 @@ allOf:
     then:
       properties:
         interrupts:
+          minItems: 3
           maxItems: 4
         interrupt-names:
+          minItems: 3
           items:
             - const: pwr_event
             - const: dp_hs_phy_irq

---
base-commit: 744cf71b8bdfcdd77aaf58395e068b7457634b2c
change-id: 20241116-topic-x1e_usb2_bindings-6ce956a06374

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Re: [PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100

[Rob Herring]

On Sat, Nov 16, 2024 at 12:17:52PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> X1 has multiple DWC3 hosts, including one that's USB2, which naturally
> means it doesn't have a SuperSpeed interrupt. Make it optional to fix
> warnings such as:
> 
> usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short

That's a good start, but what about all the other warnings for usb 
interrupts?:

     13  usb@f92f8800: 'interrupt-names' is a required property
     11  usb@76f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
     11  usb@6af8800: interrupts: [[0, 347, 4], [0, 243, 4]] is too short
     11  usb@6af8800: interrupt-names:1: 'qusb2_phy' was expected
     11  usb@6af8800: interrupt-names:0: 'pwr_event' was expected
     11  usb@6af8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq'] is too short
      9  usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
      7  usb@c2f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
      5  usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
      5  usb@8af8800: interrupt-names: ['pwr_event'] is too short
      4  usb@8af8800: interrupts: [[0, 62, 4]] is too short
      4  usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short


> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH] dt-bindings: usb: qcom,dwc3: Make ss_phy_irq optional for X1E80100

[Konrad Dybcio]

On 19.11.2024 6:13 PM, Rob Herring wrote:
> On Sat, Nov 16, 2024 at 12:17:52PM +0100, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> X1 has multiple DWC3 hosts, including one that's USB2, which naturally
>> means it doesn't have a SuperSpeed interrupt. Make it optional to fix
>> warnings such as:
>>
>> usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
> 
> That's a good start, but what about all the other warnings for usb 
> interrupts?:
> 
>      13  usb@f92f8800: 'interrupt-names' is a required property
>      11  usb@76f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
>      11  usb@6af8800: interrupts: [[0, 347, 4], [0, 243, 4]] is too short
>      11  usb@6af8800: interrupt-names:1: 'qusb2_phy' was expected
>      11  usb@6af8800: interrupt-names:0: 'pwr_event' was expected
>      11  usb@6af8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq'] is too short
>       9  usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
>       7  usb@c2f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short
>       5  usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
>       5  usb@8af8800: interrupt-names: ['pwr_event'] is too short
>       4  usb@8af8800: interrupts: [[0, 62, 4]] is too short
>       4  usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short

I'll address most of those shortly. Need to dig up a couple old devices
to make sure my findings reflect reality ;)

Konrad