From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9668A42056 for ; Fri, 22 Nov 2024 17:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732295452; cv=none; b=Owo9sjHOcWTJxDUrnup3VhaAhu/+2I0mhJQ1uas0TxhGcVFM/6F1ySpcd1FXWuqKNR+XzN9vyVfq8knYGe8TxLIQMSEIPYzLGl7U6UyKqiQ0ZU21NSh9rckxyxbcO3J3g83XTfagcxvFVP3EtV18qKF2Z21y05x316hY3SZEKno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732295452; c=relaxed/simple; bh=JSfJBNYEbA8FDDOxY/qXqSPsOBH8pc0lxdl5eHk3OHg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VtxO1Yq7xw8Ja+ztjIpqlKWCwp9XkWQHtK1XSyiW23N76ujud1lbn4y30549iKvrUga3vx2CqoYn43k2Znnq782wEMi3BF9r5Z2oPCL7+KswTfPuuiUbTFTIeK8fHU6QqFndCa570fEVervzsEdgT5DmPs4CYL92lqcgkox7fKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eEHbJ5Cn; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eEHbJ5Cn" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7eb0bc007edso1631949a12.3 for ; Fri, 22 Nov 2024 09:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732295450; x=1732900250; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=m9Rzu/atJszaZiZQ8bphSysVEtM05e/rUjckRGXXQa8=; b=eEHbJ5Cnr2LP8QZElbeawTkXgevrD8ABRlNJvZt1JkG9R+miEgmgPO82jiaFVKeau0 sYR9Qa3JIM8DlJuMwGsHosxuRynXh4QW0N4EmYr3ygqHL9zyXOp7JewevuBEPBhbpu2O aYA9Ozni6L4o7LO8v6+UmOCogpUHNooCv5dRIG2YhOHIfkiyxG/VdL/Is7eNt7ePUccd 6c/2mxkv9oIeMW5N1VKoWnU0yxuIz/TnhuvOW/wUycHtIbCp+d0RyCcTgGBEb2OIGHZK iMgJDM2WAF7Br9pBVBawATHk1B6eKy+KXtCkqpfURGwyNtZi2beo9VNsFDSo+Y7nav0m Skzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732295450; x=1732900250; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m9Rzu/atJszaZiZQ8bphSysVEtM05e/rUjckRGXXQa8=; b=ItgPPEW6xpyYsmWwmBKqeZ1G7agZpwz/7tmbHrnaxAdNhcnd4TNtaJSKo2fKKOL+db 4fWUlK6Kk+zmkTZcJ859fndSrxYwCDo5yeMnUTJ7K4aOgrDJxdUXLpGV2AXMbsWZjRXP pf5n50G2vAqSs8ZG0JzK2T3ELlK6M6J6Ti7ge5QJmlIsNeAjrgfAvQxid7UTy8FElpb9 3RfVKLhEB89vX8U3sp9zBN2QtAcGLT3KVEszt5ZOFdPqHsJ5K6K6JFWPLqVZOW64iFCF Q0RlbqhPNVNgd9/cH3bNUNUC+ypM6wj+V3OPpbVEagyrE/VDDeDL5AX9o7cDlOTn/DKj myTw== X-Forwarded-Encrypted: i=1; AJvYcCWLH1jOnUm4BbE61vE+Fk3MBpUlcsHYzvhZAr4TX9PEYkjYWzKnC9do7ySOs8GCGtmgC2oTHPlQa+XY@vger.kernel.org X-Gm-Message-State: AOJu0YyH/WteCO7WlQt5cV8IMat1sxICng7ixd+fDCjds9pd8kdIlbMK tfj4LExd/5OWllyiCbSfXLCfsvvvpaIFRhO+2ZVmjPuSAbyVYl1uu5gicJe1+g== X-Gm-Gg: ASbGncuWmq38aYymfo0DPbIzjXIdlX47S6Z4KyXa7wWSI+rhGSjwKQfRVgCfwz/AeMO /Ooj6EwsKOx4kwZSyiBGSynYK3SwOSaYD0jBcqA2CM4f9HyOZSDI/ShYRiMxfsvyV+e8uD5+9Pn gireSV6M9Ws9DWfKUoEqW55+P+oNZRRe+6WUK4qeVqbzezQgBLgySiuuqkP1CpZIQp//NWjQqst 47Wr9/F7TFr6kCyXTMe3Cwjl0aCI3qyarkv/JbwI89F2Qz+7Rox3qUFw22y X-Google-Smtp-Source: AGHT+IFIhc1R40hXLVSot1qpNb47cXTxZcrRwISXx0lJGKYTEDxVxH0DwKBYDolmma7+CJxTTAgLkQ== X-Received: by 2002:a05:6a20:d503:b0:1c6:fb66:cfe with SMTP id adf61e73a8af0-1e09e45ff0emr4838841637.21.1732295449974; Fri, 22 Nov 2024 09:10:49 -0800 (PST) Received: from thinkpad ([49.207.202.49]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de57a562sm1847026b3a.195.2024.11.22.09.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 09:10:49 -0800 (PST) Date: Fri, 22 Nov 2024 22:40:43 +0530 From: Manivannan Sadhasivam To: Hongxing Zhu Cc: "l.stach@pengutronix.de" , "bhelgaas@google.com" , "lpieralisi@kernel.org" , "kw@linux.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "shawnguo@kernel.org" , Frank Li , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "imx@lists.linux.dev" , "kernel@pengutronix.de" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 04/10] PCI: imx6: Correct controller_id generation logic for i.MX7D Message-ID: <20241122171043.j2xh4fvdo6goq7o2@thinkpad> References: <20241101070610.1267391-1-hongxing.zhu@nxp.com> <20241101070610.1267391-5-hongxing.zhu@nxp.com> <20241115064321.3cuqng7bzmphiomw@thinkpad> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Nov 18, 2024 at 02:59:48AM +0000, Hongxing Zhu wrote: > > -----Original Message----- > > From: Manivannan Sadhasivam > > Sent: 2024年11月15日 14:43 > > To: Hongxing Zhu > > Cc: l.stach@pengutronix.de; bhelgaas@google.com; lpieralisi@kernel.org; > > kw@linux.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; > > shawnguo@kernel.org; Frank Li ; > > s.hauer@pengutronix.de; festevam@gmail.com; imx@lists.linux.dev; > > kernel@pengutronix.de; linux-pci@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH v6 04/10] PCI: imx6: Correct controller_id generation > > logic for i.MX7D > > > > On Fri, Nov 01, 2024 at 03:06:04PM +0800, Richard Zhu wrote: > > > i.MX7D only has one PCIe controller, so controller_id should always be 0. > > > The previous code is incorrect although yielding the correct result. > > > Fix by removing IMX7D from the switch case branch. > > > > > > > Worth adding a fixes tag? > > > It's originated from commit 2d8ed461dbc9 ("PCI: imx6: Add support for i.MX8MQ") > > How about to add one Fixes tag like this? > Fixes: commit 2d8ed461dbc9 ("PCI: imx6: Add support for i.MX8MQ") > Okay. - Mani -- மணிவண்ணன் சதாசிவம்