From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1A512CD88 for ; Sat, 23 Nov 2024 05:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732338262; cv=none; b=NqPt8wgdF8Eerl8kml64NtE55nROodeIKeEoOpd3IXP/HfZFi+48rwWk95f8NJbZ2jeXGaPVX5xmb8s3LFQq3JbOGIko6UZW4rvMQCn1SLo9i/NGpR7ak0adqYM++6NtaVWD56HiCUyWYGbivY8K0hK5wCuoCiaMjtJMNuZd10g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732338262; c=relaxed/simple; bh=h7sOQdKgslvytgzjqusSMgmQRkfNmvo2gwZJv5axaTM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JPHBCzwaKC8inYDZkgnqsJ1kymh4W5oSlXcMtiENnxTCZ8neJRzENc4cHYhfS6dk5/n0sPjhGXBVvZXfbbSN77ra9BWIwHW2iWUB2l24BK1t7rrWUauep8mOt+dyNd3jyqfvTAa3m0YzJm7yLFGVVycF/Xv18MG2mp06wgX2SdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xImdXQSk; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xImdXQSk" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7f450f7f11dso2126058a12.2 for ; Fri, 22 Nov 2024 21:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732338260; x=1732943060; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jrrbLdcdGlY2ZcZW0mEDuIlBogzMm+C1CwwsMUranJU=; b=xImdXQSkzVoZT/f4ikoq8h/MHEXQ+juahpRuXmPcIOID0hxsX7ob1C4zNRgJCKejRQ IeWjb/8xHno/zhJvNayI7BVQNRF461S3mbhAoyHIQitzWIQQguIUtg4nndXHgEkyoNL5 OSL+KAcor9vGDlXhl2EgHd1kDRutNf7RXPK8CRWATpnYIiII1CRASYdeCZHDKOlEnAv5 4L5t8WZM3Ah7VFXerCVYMxidsP13M42FGiAJkh+1bvX/wzb5KT7YXRcUeW0Uy40j0RSc r23JD0cl8wyjrDE3gLrvJHyXTuE+ktk+d0HJDzw4Lp/6obriLU/TqSHkstwGpV6C4+sh jynw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732338260; x=1732943060; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jrrbLdcdGlY2ZcZW0mEDuIlBogzMm+C1CwwsMUranJU=; b=v4jHM2p+lbEMPojJuUykkZOMXTTzcQXyTkqMRHT0RhJba01S8rbNECE/NYcVJAWh67 1KnUkSMGd/lqPm1HpkJdNvFk4MMpsIRR6m4eoYiJeMcfmJTDEwN+saWyS9ASQSXWJIvy aaIiCDBRXXeppWczaTxGxFecNQmm8z0zyxM5p31LWhqLIakPXTHKNJtd7sO3ADCkdv0Q jUwU6/gYlKGuuDNdFRgyq5Bqn3SNtxg+HWASyG+Xx3VBRfrg8l9XGvFcS3r01D9Me8xD JidJet90yEBgP9UYuxEmW9W9bnOq2UoFa5gCbg+OHCerDyKV/FxEgFUzB8fHhtObApw0 javg== X-Forwarded-Encrypted: i=1; AJvYcCXLhS3zrSHeqswvaQyGMxXfFF6en+HYk9aSuuIgfh/s5+FBvBfFun1QDSZ07PxuSYu+SQxnIisCHjOr@vger.kernel.org X-Gm-Message-State: AOJu0Yx/4GVp6DWwDsOrlzr6MNR969C2cJvTZ5e5gRgMN9gYz1urIbCR gJYoeR45s6xivE2z00RK5GK16rOy7HtHqlTwgpVecRxLG3PsMqw69S6LLVTE4A== X-Gm-Gg: ASbGncu/GxYCSNYD7DsqzyQGldJlHCkMvtOOJxl93Y/DvkKaONlZZPOBzLWgQbHnT37 HAz3so2WYCiy8O0waJkhK+rqcEQzhaGpj1Gv6gABUtZqzr5gIEQsMZEZ05n6g1hqkoOq16Rgo6e H2ykAkyNyCMip0AZ+JculK5I4uEhQMnW2ktO+35gsLUq2j8NFodeyX/sZhsmcNZHo96e9wYJJ3W 0AlOTp/e8DVWh1GSMrgv5SPOZ68JLvw7nw8ELNs5SpQ+iLev+Xv3RuCGjwHsP8+aA== X-Google-Smtp-Source: AGHT+IHtEp73R31OmhWsYzXCA+I1V+Hri+7jEcS+EPxf7JnICgfkL145nhRT5ANnQ3iNY2Z3dlcmrA== X-Received: by 2002:a05:6a20:7483:b0:1dc:c1c9:fc0a with SMTP id adf61e73a8af0-1e09e472aedmr7640085637.27.1732338260044; Fri, 22 Nov 2024 21:04:20 -0800 (PST) Received: from thinkpad ([2409:40f2:101e:13d7:85cf:a1c4:6490:6f75]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de532d0csm2519571b3a.116.2024.11.22.21.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 21:04:19 -0800 (PST) Date: Sat, 23 Nov 2024 10:34:09 +0530 From: Manivannan Sadhasivam To: Shawn Lin Cc: Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Heiko Stuebner , "Rafael J . Wysocki" , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v5 7/7] arm64: dts: rockchip: Add UFS support for RK3576 SoC Message-ID: <20241123050409.7ynmaw6cqtfefqdy@thinkpad> References: <1731048987-229149-1-git-send-email-shawn.lin@rock-chips.com> <1731048987-229149-8-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1731048987-229149-8-git-send-email-shawn.lin@rock-chips.com> On Fri, Nov 08, 2024 at 02:56:26PM +0800, Shawn Lin wrote: > Add ufshc node to rk3576.dtsi, so the board using UFS could > enable it. > > Signed-off-by: Shawn Lin > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > index 436232f..32beda2 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > @@ -1110,6 +1110,31 @@ > }; > }; > > + ufshc: ufshc@2a2d0000 { > + compatible = "rockchip,rk3576-ufshc"; > + reg = <0x0 0x2a2d0000 0 0x10000>, /* 0: HCI standard */ > + <0x0 0x2b040000 0 0x10000>, /* 1: Mphy */ > + <0x0 0x2601f000 0 0x1000>, /* 2: HCI Vendor specified */ > + <0x0 0x2603c000 0 0x1000>, /* 3: Mphy Vendor specified */ > + <0x0 0x2a2e0000 0 0x10000>; /* 4: HCI apb */ No need to add comments for each region. Bindings describe them. - Mani -- மணிவண்ணன் சதாசிவம்