From: Bingwu Zhang <xtex@envs.net>
To: David Gibson <david@gibson.dropbear.id.au>,
devicetree-compiler@vger.kernel.org
Cc: Bingwu Zhang <xtexchooser@duck.com>,
devicetree@vger.kernel.org, ~xtex/staging@lists.sr.ht
Subject: [PATCH v2] libfdt: Remove fdt parameter from overlay_fixup_one_phandle
Date: Sat, 23 Nov 2024 17:48:14 +0800 [thread overview]
Message-ID: <20241123094814.15504-2-xtex@envs.net> (raw)
From: Bingwu Zhang <xtexchooser@duck.com>
When compiling with -Wall -Wextra, the unused fdt parameter becomes a
warning. With -Werror, it becomes an error and fails the build.
As the parameter is not used in the function, let's remove it.
Signed-off-by: Bingwu Zhang <xtexchooser@duck.com>
---
Changes from v1:
- Remove fdt parameter rather than suppressing the warning directly
Link: https://lore.kernel.org/devicetree-compiler/20241116101228.164707-5-xtex@envs.net/ # v1
---
libfdt/fdt_overlay.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libfdt/fdt_overlay.c b/libfdt/fdt_overlay.c
index f61ca7ed2f0b..e6b9eb643958 100644
--- a/libfdt/fdt_overlay.c
+++ b/libfdt/fdt_overlay.c
@@ -307,7 +307,6 @@ static int overlay_update_local_references(void *fdto, uint32_t delta)
/**
* overlay_fixup_one_phandle - Set an overlay phandle to the base one
- * @fdt: Base Device Tree blob
* @fdto: Device tree overlay blob
* @symbols_off: Node offset of the symbols node in the base device tree
* @path: Path to a node holding a phandle in the overlay
@@ -328,8 +327,7 @@ static int overlay_update_local_references(void *fdto, uint32_t delta)
* 0 on success
* Negative error code on failure
*/
-static int overlay_fixup_one_phandle(void *fdt, void *fdto,
- int symbols_off,
+static int overlay_fixup_one_phandle(void *fdto, int symbols_off,
const char *path, uint32_t path_len,
const char *name, uint32_t name_len,
int poffset, uint32_t phandle)
@@ -443,7 +441,7 @@ static int overlay_fixup_phandle(void *fdt, void *fdto, int symbols_off,
if ((*endptr != '\0') || (endptr <= (sep + 1)))
return -FDT_ERR_BADOVERLAY;
- ret = overlay_fixup_one_phandle(fdt, fdto, symbols_off,
+ ret = overlay_fixup_one_phandle(fdto, symbols_off,
path, path_len, name, name_len,
poffset, phandle);
if (ret)
base-commit: b3bbee6b1242b4bb84fcb31365b76a3a45be3b6b
--
2.47.0
next reply other threads:[~2024-11-23 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 9:48 Bingwu Zhang [this message]
2024-11-25 1:26 ` [PATCH v2] libfdt: Remove fdt parameter from overlay_fixup_one_phandle David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123094814.15504-2-xtex@envs.net \
--to=xtex@envs.net \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=xtexchooser@duck.com \
--cc=~xtex/staging@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).