RE: [PATCH v6 8/8] iio: adc: ad4851: add ad485x driver

Miclaus, Antoniu
2024-11-15T10:59:38Z

> On 11/14/24 4:39 AM, Miclaus, Antoniu wrote:
> >> On 11/11/24 6:12 AM, Antoniu Miclaus wrote:
> >>> Add support for the AD485X a fully buffered, 8-channel simultaneous
> >>> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with
> >>> differential, wide common-mode range inputs.
> >>>
> >>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> >>> ---
> >>> changes in v6 (implemented most of the review comments in v5):
> >> What is the plan for addressing the rest of the comments?
> > For the rest of the comments I think I replied inline in the previous series.
> >
> I didn't look very close yet, but at a quick glance, I saw that all
> scan_type are still only signed, there is no unsigned for when the
> channels are used as single-ended. And the scan_index ordering is
> still wrong. This makes me doubt that buffered reads are working
> correctly for all configurations.

Sure, will implement the scan_type as you suggested in the next series.