From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/8] iio: accel: kx022a: Improve reset delay
Date: Sat, 23 Nov 2024 16:34:43 +0000 [thread overview]
Message-ID: <20241123163443.678f063c@jic23-huawei> (raw)
In-Reply-To: <ac1b6705945cded0e79593d64e55522681e00f9a.1732105157.git.mazziesaccount@gmail.com>
On Thu, 21 Nov 2024 10:19:50 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> All the sensors supported by kx022a driver seemed to require some delay
> after software reset to be operational again. More or less a random
> msleep(1) was added to cause the driver to go to sleep so the sensor has
> time to become operational again.
>
> Now we have official docuumentation available:
> https://fscdn.rohm.com/kionix/en/document/AN010_KX022ACR-Z_Power-on_Procedure_E.pdf
> https://fscdn.rohm.com/kionix/en/document/TN027-Power-On-Procedure.pdf
> https://fscdn.rohm.com/kionix/en/document/AN011_KX134ACR-LBZ_Power-on_Procedure_E.pdf
>
> stating the required time is 2 ms.
>
> Due to the nature of the current msleep implementation, the msleep(1) is
> likely to be sleeping more than 2ms already - but the value "1" is
> misleading in case someone needs to optimize the start time and change
> the msleep to a more accurate delay. Hence it is better for
> "documentation" purposes to use value which actually reflects the
> specified 2ms wait time.
>
> Change the value of delay after software reset to match the
> specifications and add links to the power-on procedure specifications.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Stands fine on it's own so applied (before I've even read the rest of the series).
Jonathan
next prev parent reply other threads:[~2024-11-23 16:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 8:19 [PATCH v2 0/8] Support ROHM KX134ACR-LBZ Matti Vaittinen
2024-11-21 8:19 ` [PATCH v2 1/8] iio: accel: kx022a: Improve reset delay Matti Vaittinen
2024-11-23 16:34 ` Jonathan Cameron [this message]
2024-11-21 8:20 ` [PATCH v2 2/8] iio: gts: Simplify using __free Matti Vaittinen
2024-11-23 16:37 ` Jonathan Cameron
2024-11-25 9:16 ` Matti Vaittinen
2024-11-26 17:52 ` Jonathan Cameron
2024-11-27 14:14 ` Matti Vaittinen
2024-11-21 8:20 ` [PATCH v2 3/8] iio: accel: kx022a: Use cleanup.h helpers Matti Vaittinen
2024-11-23 16:42 ` Jonathan Cameron
2024-11-25 9:34 ` Matti Vaittinen
2024-11-26 17:55 ` Jonathan Cameron
2024-11-27 13:54 ` Matti Vaittinen
2024-11-21 8:20 ` [PATCH v2 4/8] iio: accel: kx022a: Support ICs with different G-ranges Matti Vaittinen
2024-11-21 8:20 ` [PATCH v2 5/8] dt-bindings: ROHM KX134ACR-LBZ Matti Vaittinen
2024-11-21 8:21 ` [PATCH v2 6/8] iio: kx022a: Support " Matti Vaittinen
2024-11-21 8:21 ` [PATCH v2 7/8] dt-bindings: iio: kx022a: Support KX134-1211 Matti Vaittinen
2024-11-21 19:55 ` Conor Dooley
2024-11-21 8:21 ` [PATCH v2 8/8] iio: accel: " Matti Vaittinen
2024-11-23 16:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123163443.678f063c@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox