From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F651ABEA0; Mon, 25 Nov 2024 13:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732540868; cv=none; b=aUaY3xT/o0cJLzCbDeXglCemjmEMvicq+vBSzAzD/dtB2Wx+kW530fcPIgLxkROZwZ2BHjz17kufh3b4xi+tl1SbgmgpApAjs6qfuR8s0H024e8Upf9P1D9wqSlHGQwWFd2dNp4uIYTbo3jqtwFDOdInGroRJfZKTS1QYyjzPE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732540868; c=relaxed/simple; bh=3Z560kziSQXi2my1WMJNnxEGuywtw7Uta9RcrJwEvHc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SuooNe8ZwnTtoCOi9CmZaVxtI3RK4K5Q7VXDgNFl/4cisnYCLEltVo3upnd4MsGH9uqvaWCgZcUqIBBWREkcVxVBo2R+qRJY9YR5AL71vWj+oUW+hhKO9OvIiziennBN6Qy0GQ6zXn//BFbSF8CeBwA+qjP4FloJgegOLR388HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YkykpNRv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YkykpNRv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 610F7C4CED2; Mon, 25 Nov 2024 13:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732540866; bh=3Z560kziSQXi2my1WMJNnxEGuywtw7Uta9RcrJwEvHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YkykpNRv7e4NVi4Q3z8ffrcHtigFITXEIxN/5bTSjYdSwaphoIBGxqmG+/Xb46TI7 lHS/FY0EsAUAz1aYRprNvi6QHcyObwv8xHeGqJ05oGkRLX0e0qKg8xflK6oz4lAXf7 YhDyUrt9P4stTb7wr4Cj6faNKuabUVK/uT5TkuTTJ9M8Dgc7pTuXnnsJprFpWQcWsr oJtVByZrcaZVyAzTcmcBTi8a4HHu7UG0bHWY3Xph56B8h9135/UIM79mhNBzIGU96v JXhwAWUIHHY0CyLinhprle6eH9ZMJ6gAhhpTH9YT2OXbHgesMLMXeqrXQl9GDr9GhR cR4Addly+n0lQ== Date: Mon, 25 Nov 2024 07:21:04 -0600 From: Rob Herring To: Andrea della Porta Cc: Michael Turquette , Krzysztof Kozlowski , Dragan Cvetic , linux-gpio@vger.kernel.org, Herve Codina , Thomas Petazzoni , Luca Ceresoli , Bjorn Helgaas , linux-clk@vger.kernel.org, Derek Kiernan , Florian Fainelli , Conor Dooley , Bartosz Golaszewski , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Stephen Boyd , Will Deacon , Arnd Bergmann , Catalin Marinas , Andrew Lunn , Saravana Kannan , devicetree@vger.kernel.org, Stefan Wahren , linux-arm-kernel@lists.infradead.org, Broadcom internal kernel review list , Manivannan Sadhasivam , Masahiro Yamada , Lorenzo Pieralisi , Linus Walleij , Krzysztof Wilczynski Subject: Re: [PATCH v4 04/10] dt-bindings: misc: Add device specific bindings for RaspberryPi RP1 Message-ID: <20241125132104.GA1520508-robh@kernel.org> References: <173250040873.6640.9720381303445148722.robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 25, 2024 at 10:15:06AM +0100, Andrea della Porta wrote: > Hi Rob, > > On 20:06 Sun 24 Nov , Rob Herring (Arm) wrote: > > > > On Sun, 24 Nov 2024 11:51:41 +0100, Andrea della Porta wrote: > > > The RP1 is a MFD that exposes its peripherals through PCI BARs. This > > > schema is intended as minimal support for the clock generator and > > > gpio controller peripherals which are accessible through BAR1. > > > > > > Signed-off-by: Andrea della Porta > > > --- > > > .../devicetree/bindings/misc/pci1de4,1.yaml | 74 +++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb: clocks@c040018000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml# The error comes from this schema and... > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@suse.com > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > Sorry about that, but even if I see that this should be the case (I've dropped > the clock-name property from raspberrypi,rp1-clock.yaml), I can't reproduce it > with: > > # make W=1 dt_binding_check DT_SCHEMA_FILES=pci1de4,1.yaml You've limited testing to schema files matching pci1de4,1.yaml. > > and the output is: > > CHKDT Documentation/devicetree/bindings > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/misc/pci1de4,1.example.dts > DTC [C] Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb > > dt-schema seems up to date. Is my command line correct? > > Many thanks, > Andrea >