From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21E3F1AB50C; Mon, 25 Nov 2024 13:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732542397; cv=none; b=E+8n7Ph9Qork5di4ji+rY7BDh+nj+qKlQ1na0rxqTemRQCP8QbMxPVfvUMgO/m3vSmdpTWDJ2/t1ho4Qxn0POtrQeHB5o/vKsajnU0eDzMLpy6pxJKx230XM9Ltw4r5pFOguNWJOe75tbFrikJfIAuNd7V1r6A7fayp1dUQlBkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732542397; c=relaxed/simple; bh=zHg0cBNfdYbjM9MEZTXwxY4+WQFYxNEwJMWk1/4ajvw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hon5I7dSLqF/h4X084BO+WHDsrh3XFFgFhf3i79EVNc8w7iauyq3briJKAtSr/45t/VoEAFE/RH+mgpYODbISK5zXZ4/dW2RiZp99WX4Ywj+O2dn0WWjgDNj7KOU/7hyAnxm+F9kWhiJGictcghov7X6yZNDyQwIxuO9XMcbRAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hMGtm8cJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hMGtm8cJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FC89C4CECE; Mon, 25 Nov 2024 13:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1732542396; bh=zHg0cBNfdYbjM9MEZTXwxY4+WQFYxNEwJMWk1/4ajvw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hMGtm8cJbYPdtLCQPCIbIDikJESoTZ9tvTSkiOhsPrScHBWIsqgnp1BZZwFvANfZ8 UF0Wh+w9c6AAs9GtcAYw8JdyKCDQUTnKDTQFJ4Hi/J669bgudW4/pystJlY45DW2+q PXV+9BgVvAsC+CACXHZkS0iwMIwGOMLYTjEc/6Xw= Date: Mon, 25 Nov 2024 14:46:08 +0100 From: Greg Kroah-Hartman To: Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v4 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: <2024112535-viper-uncivil-3054@gregkh> References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Nov 24, 2024 at 11:51:45AM +0100, Andrea della Porta wrote: > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2611,6 +2611,9 @@ > #define PCI_VENDOR_ID_TEKRAM 0x1de1 > #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 > > +#define PCI_VENDOR_ID_RPI 0x1de4 > +#define PCI_DEVICE_ID_RPI_RP1_C0 0x0001 As you only use these in one file, please read the top of this file for why this isn't needed here, but rather should be back in that one driver. thanks, greg k-h