public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Valentina Fernandez <valentina.fernandezalanis@microchip.com>,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, ycliang@andestech.com,
	prabhakar.mahadev-lad.rj@bp.renesas.com, peterlin@andestech.com,
	samuel.holland@sifive.com, conor.dooley@microchip.com,
	alexghiti@rivosinc.com, ruanjinjie@huawei.com,
	takakura@valinux.co.jp, conor+dt@kernel.org,
	jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/4] dt-bindings: mailbox: add binding for Microchip IPC mailbox controller
Date: Tue, 26 Nov 2024 16:21:13 +0000	[thread overview]
Message-ID: <20241126-pulmonary-krypton-30da3faa8482@spud> (raw)
In-Reply-To: <vkw7o25szfn2upi5776xdojg5n5fxxaxwynth5kynjwjqzrgua@5lwrjqgzlxzi>

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

On Tue, Nov 26, 2024 at 08:04:38AM +0100, Krzysztof Kozlowski wrote:
> On Mon, Nov 25, 2024 at 05:58:17PM +0000, Valentina Fernandez wrote:
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - description:
> > +          Intended for use by software running in supervisor privileged
> > +          mode (s-mode). This SBI interface is compatible with the Mi-V
> > +          Inter-hart Communication (IHC) IP.
> > +        const: microchip,sbi-ipc
> > +
> > +      - description:
> > +          Intended for use by the SBI implementation in machine mode
> > +          (m-mode), this compatible string is for the MIV_IHC Soft-IP.
> > +        const: microchip,miv-ihc-rtl-v2

> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: microchip,sbi-ipc
> > +    then:
> > +      properties:
> > +        reg: false
> 
> What does this mean in reality? Device does not have IO address space?
> Then it is completely different programming model, isn't it?

Ye, different programming models. Two compatibles for the same hardware,
but one represents the m-mode/firmware programming model that has MMIO
access and is the SBI implementation and the other the s-mode/OS
programming model that uses ecalls provided by the SBI implementation.

> > +        microchip,ihc-chan-disabled-mask: false
> > +    else:
> > +      required:
> > +        - reg
> > +        - microchip,ihc-chan-disabled-mask


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-11-26 16:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 17:58 [PATCH v4 0/4] Add Microchip IPC mailbox Valentina Fernandez
2024-11-25 17:58 ` [PATCH v4 1/4] riscv: sbi: vendorid_list: Add Microchip Technology to the vendor list Valentina Fernandez
2024-11-25 17:58 ` [PATCH v4 2/4] riscv: export __cpuid_to_hartid_map Valentina Fernandez
2024-11-25 17:58 ` [PATCH v4 3/4] dt-bindings: mailbox: add binding for Microchip IPC mailbox controller Valentina Fernandez
2024-11-26  7:04   ` Krzysztof Kozlowski
2024-11-26 16:21     ` Conor Dooley [this message]
2024-11-25 17:58 ` [PATCH v4 4/4] mailbox: add Microchip IPC support Valentina Fernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126-pulmonary-krypton-30da3faa8482@spud \
    --to=conor@kernel.org \
    --cc=alexghiti@rivosinc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peterlin@andestech.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=samuel.holland@sifive.com \
    --cc=takakura@valinux.co.jp \
    --cc=valentina.fernandezalanis@microchip.com \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox