public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Guillaume Stols <gstols@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Nuno Sa <nuno.sa@analog.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, dlechner@baylibre.com,
	jstephan@baylibre.com, aardelean@baylibre.com,
	adureghello@baylibre.com
Subject: Re: [PATCH 5/9] iio: adc: adi-axi-adc: Add platform children support
Date: Tue, 26 Nov 2024 18:41:17 +0000	[thread overview]
Message-ID: <20241126184117.41030153@jic23-huawei> (raw)
In-Reply-To: <20241121-ad7606_add_iio_backend_software_mode-v1-5-8a693a5e3fa9@baylibre.com>

>  
> -/* Match table for of_platform binding */

No longer true? 

>  static const struct of_device_id adi_axi_adc_of_match[] = {
> -	{ .compatible = "adi,axi-adc-10.0.a", .data = &adi_axi_adc_10_0_a_info },
> -	{ /* end of list */ }
Leave this terminator as it was.  

It's not important to have, but no need to add churn here given the comment does no harm.

> +	{ .compatible = "adi,axi-adc-10.0.a", .data = &adc_generic },
> +	{  }
>  };
>  MODULE_DEVICE_TABLE(of, adi_axi_adc_of_match);
>  
> 


  reply	other threads:[~2024-11-26 18:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21 10:18 [PATCH 0/9] Add support for Software mode on AD7606's iio backend driver Guillaume Stols
2024-11-21 10:18 ` [PATCH 1/9] iio: adc: ad7606: Fix hardcoded offset in the ADC channels Guillaume Stols
2024-11-26 18:15   ` Jonathan Cameron
2024-11-21 10:18 ` [PATCH 2/9] dt-bindings: iio: dac: adi-axi-adc: Add ad7606 variant Guillaume Stols
2024-11-21 16:57   ` David Lechner
2024-11-21 19:53     ` Conor Dooley
2024-11-26 17:59       ` Jonathan Cameron
2024-11-26 18:12         ` Conor Dooley
2024-11-21 10:18 ` [PATCH 3/9] iio:adc: ad7606: Move the software mode configuration Guillaume Stols
2024-11-26 18:21   ` Jonathan Cameron
2024-11-21 10:18 ` [PATCH 4/9] iio: adc: ad7606: Move software functions into common file Guillaume Stols
2024-11-26 18:29   ` Jonathan Cameron
2024-11-21 10:18 ` [PATCH 5/9] iio: adc: adi-axi-adc: Add platform children support Guillaume Stols
2024-11-26 18:41   ` Jonathan Cameron [this message]
2024-11-21 10:18 ` [PATCH 6/9] iio: adc: adi-axi-adc: Add support for AD7606 register writing Guillaume Stols
2024-11-26 18:43   ` Jonathan Cameron
2024-11-21 10:18 ` [PATCH 7/9] iio: adc: ad7606: change r/w_register signature Guillaume Stols
2024-11-21 10:18 ` [PATCH 8/9] iio: adc: ad7606: Simplify channel macros Guillaume Stols
2024-11-26 18:46   ` Jonathan Cameron
2024-11-21 10:18 ` [PATCH 9/9] iio: adc: ad7606: Add support for writing registers when using backend Guillaume Stols
2024-11-26 18:48   ` Jonathan Cameron
2024-11-26 19:13     ` David Lechner
2024-11-26 18:00 ` [PATCH 0/9] Add support for Software mode on AD7606's iio backend driver Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126184117.41030153@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=aardelean@baylibre.com \
    --cc=adureghello@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gstols@baylibre.com \
    --cc=jstephan@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox