devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function
@ 2024-11-27 15:15 E Shattow
  2024-11-27 15:15 ` [PATCH v4 1/1] " E Shattow
  2024-12-02 19:09 ` [PATCH v4 0/1] " Conor Dooley
  0 siblings, 2 replies; 3+ messages in thread
From: E Shattow @ 2024-11-27 15:15 UTC (permalink / raw)
  To: Emil Renner Berthing, Henry Bell
  Cc: E Shattow, Conor Dooley, Emil Renner Berthing, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	linux-riscv, devicetree, linux-kernel

Enable host mode JH7110 on-chip USB for Pine64 Star64 by setting host mode 
and connect vbus pinctrl.

This functionality depends on setting the USB over-current register to 
disable at bootloader phase, for example U-Boot:
https://patchwork.ozlabs.org/project/uboot/patch/20241012031328.4268-6-minda.chen@starfivetech.com/

If the over-current register is not prepared for us then the result is no 
change in functional outcome with this patch applied; there is an error 
visible to the user and this usb configuration fails (same as it is now).

Changes since v3:
 - Rebase on latest master
 - Addtional detail to commit description

Changes since v2:
 - Rebase on latest master

Changes since v1:
 - Rebase on linux-next/master
 - use tabs for code indent

E Shattow (1):
  riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function

 .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v4 1/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0  host function
  2024-11-27 15:15 [PATCH v4 0/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function E Shattow
@ 2024-11-27 15:15 ` E Shattow
  2024-12-02 19:09 ` [PATCH v4 0/1] " Conor Dooley
  1 sibling, 0 replies; 3+ messages in thread
From: E Shattow @ 2024-11-27 15:15 UTC (permalink / raw)
  To: Emil Renner Berthing, Henry Bell
  Cc: E Shattow, Emil Renner Berthing, Conor Dooley, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	linux-riscv, devicetree, linux-kernel

Pine64 Star64 board routes all four USB-A ports to USB0 on the SoC.
Set JH7110 on-chip USB host mode and vbus pin assignment accordingly.

Signed-off-by: E Shattow <e@freeshell.de>
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
---
 .../boot/dts/starfive/jh7110-pine64-star64.dts | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts b/arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts
index fe4a490ecc61..b764d4d92fd9 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts
+++ b/arch/riscv/boot/dts/starfive/jh7110-pine64-star64.dts
@@ -80,7 +80,23 @@ &spi0 {
 	status = "okay";
 };
 
+&sysgpio {
+	usb0_pins: usb0-0 {
+		vbus-pins {
+			pinmux = <GPIOMUX(25,  GPOUT_SYS_USB_DRIVE_VBUS,
+					       GPOEN_ENABLE,
+					       GPI_NONE)>;
+			bias-disable;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
+	};
+};
+
 &usb0 {
-	dr_mode = "peripheral";
+	dr_mode = "host";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins>;
 	status = "okay";
 };
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v4 0/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function
  2024-11-27 15:15 [PATCH v4 0/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function E Shattow
  2024-11-27 15:15 ` [PATCH v4 1/1] " E Shattow
@ 2024-12-02 19:09 ` Conor Dooley
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-12-02 19:09 UTC (permalink / raw)
  To: Emil Renner Berthing, Henry Bell, E Shattow
  Cc: conor, Conor Dooley, Emil Renner Berthing, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	linux-riscv, devicetree, linux-kernel

From: Conor Dooley <conor.dooley@microchip.com>

On Wed, 27 Nov 2024 07:15:04 -0800, E Shattow wrote:
> Enable host mode JH7110 on-chip USB for Pine64 Star64 by setting host mode
> and connect vbus pinctrl.
> 
> This functionality depends on setting the USB over-current register to
> disable at bootloader phase, for example U-Boot:
> https://patchwork.ozlabs.org/project/uboot/patch/20241012031328.4268-6-minda.chen@starfivetech.com/
> 
> [...]

Applied to riscv-dt-for-next, thanks!

[1/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function
      https://git.kernel.org/conor/c/03bd268ae048

Thanks,
Conor.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-12-02 19:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-27 15:15 [PATCH v4 0/1] riscv: dts: starfive: jh7110-pine64-star64: enable usb0 host function E Shattow
2024-11-27 15:15 ` [PATCH v4 1/1] " E Shattow
2024-12-02 19:09 ` [PATCH v4 0/1] " Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).