From: Andreas Kemnade <andreas@kemnade.info>
To: tony@atomide.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andreas@kemnade.info, hns@goldelico.com,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, aaro.koskinen@iki.fi,
khilman@baylibre.com, rogerq@kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module
Date: Thu, 28 Nov 2024 00:00:28 +0100 [thread overview]
Message-ID: <20241128000028.1db436c8@akair> (raw)
In-Reply-To: <20241116211549.2020727-1-andreas@kemnade.info>
Am Sat, 16 Nov 2024 22:15:49 +0100
schrieb Andreas Kemnade <andreas@kemnade.info>:
> @@ -459,6 +460,15 @@ OMAP3630_CORE2_IOPAD(0x25fa, PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d15.hsusb2_d
> >;
> };
>
> + mcspi3hog_pins: mcspi3hog-pins {
> + pinctrl-single,pins = <
> + OMAP3630_CORE2_IOPAD(0x25dc, PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* etk_d0 */
> + OMAP3630_CORE2_IOPAD(0x25de, PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* etk_d1 */
> + OMAP3630_CORE2_IOPAD(0x25e0, PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* etk_d2 */
> + OMAP3630_CORE2_IOPAD(0x25e2, PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* etk_d3 */
> + >;
> + };
> +
mode7 is not safe mode in this special case, need mode 4 (gpio),
so this patch is broken.
Regards,
Andreas
prev parent reply other threads:[~2024-11-27 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 21:15 [PATCH v2] ARM: dts: ti/omap: gta04: fix pm issues caused by spi module Andreas Kemnade
2024-11-27 23:00 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128000028.1db436c8@akair \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).