Re: [PATCH v1 3/3] iio: adc: ad7192: Add sync gpio

Jonathan Cameron
2024-12-08T18:43:47Z

On Mon, 2 Dec 2024 16:21:43 -0600
David Lechner <dlechner@baylibre.com> wrote:

> On 11/30/24 12:38 PM, Jonathan Cameron wrote:
> > On Thu, 28 Nov 2024 14:55:03 +0200
> > Alisa-Dariana Roman <alisadariana@gmail.com> wrote:
> >
> >> Add support for the SYNC pin of AD719x devices. This pin is controlled
> >> through a GPIO. The pin allows synchronization of digital filters and
> >> analog modulators when using multiple devices.
> >>
> >> Signed-off-by: Alisa-Dariana Roman <alisa.roman@analog.com>
> > Hi.
> >
> > Like all userspace ABI, this needs documentation.
> >
> > It's an unusual feature, so some usecases would help.
> >
> > It is also cross multiple devices which makes this odd as only one device
> > can presumably acquire the gpio?
> >
> > An alternative would be to look at how to do this with a 'wrapper' sort of device
> > so that we have one instance to which this applies.
> >
> > I'm not sure that helps that much though as we'd still need some for of
> > 'I'm setup for all channels, now you can go' ABI.
> >
> > Jonathan
> >
>
> Giving userspace direct control over the /SYNC pin without coordinating
> with the rest of the driver does seem like it could be asking for trouble.
>
> It seems like the only time you would want to actually toggle the /SYNC
> pin is when starting a buffered read.
>
> 1. Deassert /SYNC so that no conversions can be triggered.
> 2. Enable buffered reads for all chips connected to the same GPIO.
> 3. Assert /SYNC to start all conversions at the same time.
>
> So it could make sense to integrate this into the buffer pre/post enable
> callbacks somehow instead of adding a new sysfs attribute.
>
> For the "wrapper" device, maybe we could do something with configfs to
> enable dynamically connecting multiple device instances? We might not
> need to actually create a separate device in sysfs, but just do something
> so that enabling a buffered read on the first chip will enable buffered
> reads on all of the chips in the group.
>
> It seems like we have some other chips that are currently being worked on
> that also have the possibility of some sort of multi-chip synchronization
> like this so it would be nice to come up with a general solution.

Most of the multichip cases we've had before have been chained, rather
than separate data interfaces, hence I don't recall us needing something
like this before.

>
> Another use case for a general synchronized buffered read/write between
> multiple chips would be the AD3552R DAC. Recently, while adding support
> for an IIO backend for this chip, we saw that the AXI DAC backend has a
> synchronization feature like this where you set an "arm" bit on all AXI
> DAC instances. Then when you enable streaming to the first chip, it also
> triggers all of the other AXI DAC blocks to start streaming at the same
> time. We ended up not implementing that feature since the IIO subsystem
> doesn't really support this yet, but could be a good one to look at as a
> similar feature with a different implementation to help us find a general
> solution.
>
This feels like a case where we need a prototype to poke holes in.
It's not totally dissimilar from the hardware trigger stuff that
exists in a few devices. Some of the stm parts for instance where the
triggering is entirely within the chip. Maybe we could make something
like that work. So the driver instance that has the sync pin registers
a trigger that the other devices use. It's a bit ugly though and we'd
still need a dt-binding to let us know 'which' devices are connected
to that sync pin.

Jonathan