Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851

David Lechner
2024-12-09T17:44:17Z

On 12/9/24 8:02 AM, Miclaus, Antoniu wrote:
>
>
> --
> Antoniu Miclăuş
>
>> -----Original Message-----
>> From: David Lechner <dlechner@baylibre.com>
>> Sent: Thursday, December 5, 2024 2:46 AM
>> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; jic23@kernel.org;
>> robh@kernel.org; conor+dt@kernel.org; linux-iio@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>> pwm@vger.kernel.org
>> Cc: Conor Dooley <conor.dooley@microchip.com>
>> Subject: Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851
>>
>> [External]
>>
>> On 11/29/24 9:35 AM, Antoniu Miclaus wrote:
>>> Add devicetree bindings for ad485x family.
>>>
>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>>> ---
>>> changes in v7:
>>> - add adc channels support
>>
>> What is the reason for this change? In a previous version of this series,
>> you explained that we didn't want to specify diff-channels in the DT
>> because there was a use case to use channels as both single-ended and
>> differential at runtime. So I am surprised to see this being added now.
>>
> We had a discussion and we decided to go for the dt approach for specifying
> the channels configuration, even though in the first place we wanted to avoid this.
> Overall it makes more sense.

OK, in that case we will also want to make use of the standard "bipolar"
property from adc.yaml as well since the chip differentiates between
unipolar and bipolar inputs.

Also, might want to drop Conor's review tag and give an explanation in
the next revision since adding these channel properties is a bit of
a big change compared to the version he reviewed.

>
>>> +patternProperties:
>>> + "^channel(@[0-7])?$":
>>> + $ref: adc.yaml
>>> + type: object
>>> + description: Represents the channels which are connected to the ADC.
>>> +
>>> + properties:
>>> + reg:
>>> + description: The channel number in single-ended mode.
>>> + minimum: 0
>>> + maximum: 7
>>> +
>>> + diff-channels: true
>>> +
>>> + required:
>>> + - reg
>>> +
>>> + additionalProperties: false
>>> +