Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851

David Lechner
2024-12-05T00:46:18Z

On 11/29/24 9:35 AM, Antoniu Miclaus wrote:
> Add devicetree bindings for ad485x family.
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v7:
> - add adc channels support

What is the reason for this change? In a previous version of this series,
you explained that we didn't want to specify diff-channels in the DT
because there was a use case to use channels as both single-ended and
differential at runtime. So I am surprised to see this being added now.

> +patternProperties:
> + "^channel(@[0-7])?$":
> + $ref: adc.yaml
> + type: object
> + description: Represents the channels which are connected to the ADC.
> +
> + properties:
> + reg:
> + description: The channel number in single-ended mode.
> + minimum: 0
> + maximum: 7
> +
> + diff-channels: true
> +
> + required:
> + - reg
> +
> + additionalProperties: false
> +