Re: [PATCH v3 7/7] iio: accel: kx022a: align with subsystem way

kernel test robot
2024-11-28T17:21:32Z

Hi Matti,

kernel test robot noticed the following build warnings:

[auto build test WARNING on a61ff7eac77e86de828fe28c4e42b8ae9ec2b195]

url: https://github.com/intel-lab-lkp/linux/commits/Matti-Vaittinen/iio-accel-kx022a-Use-cleanup-h-helpers/20241128-170626
base: a61ff7eac77e86de828fe28c4e42b8ae9ec2b195
patch link: https://lore.kernel.org/r/9b63813ecf10b1cd0126cb950bc09514c4287b9a.1732783834.git.mazziesaccount%40gmail.com
patch subject: [PATCH v3 7/7] iio: accel: kx022a: align with subsystem way
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20241129/202411290107.KXHPQXRf-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411290107.KXHPQXRf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411290107.KXHPQXRf-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/iio/accel/kionix-kx022a.c: In function 'kx022a_write_raw':
drivers/iio/accel/kionix-kx022a.c:507:9: error: implicit declaration of function 'if_not_cond_guard' [-Wimplicit-function-declaration]
507 | if_not_cond_guard(iio_claim_direct_try, idev)
| ^~~~~~~~~~~~~~~~~
drivers/iio/accel/kionix-kx022a.c:507:27: error: 'iio_claim_direct_try' undeclared (first use in this function); did you mean 'class_iio_claim_direct_try_t'?
507 | if_not_cond_guard(iio_claim_direct_try, idev)
| ^~~~~~~~~~~~~~~~~~~~
| class_iio_claim_direct_try_t
drivers/iio/accel/kionix-kx022a.c:507:27: note: each undeclared identifier is reported only once for each function it appears in
drivers/iio/accel/kionix-kx022a.c:507:54: error: expected ';' before 'return'
507 | if_not_cond_guard(iio_claim_direct_try, idev)
| ^
| ;
508 | return -EBUSY;
| ~~~~~~
In file included from drivers/iio/accel/kionix-kx022a.c:8:
>> include/linux/cleanup.h:308:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
308 | for (CLASS(_name, scope)(args), \
| ^~~
drivers/iio/accel/kionix-kx022a.c:521:17: note: in expansion of macro 'scoped_guard'
521 | scoped_guard(mutex, &data->mutex) {
| ^~~~~~~~~~~~
drivers/iio/accel/kionix-kx022a.c:532:9: note: here
532 | case IIO_CHAN_INFO_SCALE:
| ^~~~

vim +308 include/linux/cleanup.h

e4ab322fbaaaf8 Peter Zijlstra 2023-09-17 306
54da6a0924311c Peter Zijlstra 2023-05-26 307 #define scoped_guard(_name, args...) \
54da6a0924311c Peter Zijlstra 2023-05-26 @308 for (CLASS(_name, scope)(args), \
e4ab322fbaaaf8 Peter Zijlstra 2023-09-17 309 *done = NULL; __guard_ptr(_name)(&scope) && !done; done = (void *)1)
e4ab322fbaaaf8 Peter Zijlstra 2023-09-17 310

--
0-DAY CI Kernel Test Service