Re: [PATCH 2/2] iio: light: Add support for the AMS TCS3430 color sensor

Paul Kocialkowski
2024-12-01T17:58:02Z

[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]

Hi,

Le Sun 01 Dec 24, 11:58, Jonathan Cameron a écrit :
> On Sat, 30 Nov 2024 18:42:39 +0100
> Paul Kocialkowski <paulk@sys-base.io> wrote:
>
> > The AMS TCS3430 is a XYZ tristimulus color sensor, with an additional
> > infrared channel.
> >
> > This driver implements support for all channels, with configurable
> > integration time and gain. Both direct reading and triggered-buffer
> > modes are supported.
> >
> > The device's interrupt can be used to sample all channels at the end
> > of conversion and is optional.
> >
> > A thereshold mechanism is available in hardware but only applies to
> > the Z channel. As a result it is of very low interest and was not
> > implemented.
> >
> > Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
>
> Hi Paul
>
> As at least some of the feedback I gave on your other driver applies
> here as well, I'm not going to review this version separately.
>
> I'd generally advise against sending multiple similar drivers for review
> at the same time as it is less efficient. Sad truth is that reviewer
> time is generally a bigger bottleneck for kernel code than the time
> of driver authors. Any time you can put in to help with that will generally
> also accelerate the rate at which we get to your code!
>
> Absolutely fine to overlap your submissions though. When the first
> driver is getting close to being merged, feel free to send the second
> one to get review started.

That makes sense yes! Let's focus on the first driver for now and I'll apply
corresponding changes to this one when the first one is ready.

Thanks!

Paul

--
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]