From: Conor Dooley <conor@kernel.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
gustavo.pimentel@synopsys.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jingoohan1@gmail.com, michal.simek@amd.com,
bharat.kumar.gogada@amd.com
Subject: Re: [PATCH v3 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support
Date: Wed, 4 Dec 2024 17:48:20 +0000 [thread overview]
Message-ID: <20241204-marvelous-lubricant-048e71139b32@spud> (raw)
In-Reply-To: <20241204115026.3014272-2-thippeswamy.havalige@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
On Wed, Dec 04, 2024 at 05:20:24PM +0530, Thippeswamy Havalige wrote:
> Add support for mdb slcr aperture that is only supported for AMD Versal2
> devices.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
> ---
> Changes in v3:
> -------------
> - Introduced below changes in dwc yaml schema.
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> index 548f59d76ef2..02cc04339d75 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> @@ -113,6 +113,8 @@ properties:
> enum: [ smu, mpu ]
> - description: Tegra234 aperture
> enum: [ ecam ]
> + - description: AMD MDB PCIe slcr region
> + enum: [ mdb_pcie_slcr ]
Why's this an enum when it has a single value? Shouldn't it be a const?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-04 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 11:50 [PATCH v3 0/3] Add support for AMD MDB IP as Root Port Thippeswamy Havalige
2024-12-04 11:50 ` [PATCH v3 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support Thippeswamy Havalige
2024-12-04 17:48 ` Conor Dooley [this message]
2024-12-04 11:50 ` [PATCH v3 2/3] dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge Thippeswamy Havalige
2024-12-04 11:50 ` [PATCH v3 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver Thippeswamy Havalige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204-marvelous-lubricant-048e71139b32@spud \
--to=conor@kernel.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox