From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5AA926AFF; Wed, 4 Dec 2024 14:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733322445; cv=none; b=lu1si1rYaZTNmv70UlS4yC8hg27Hho51k8AFI38nUWbNtA/gtGtPBtLfbDivbHJOzpNhQL0bUZaZgZTJA6PPxve+3nlxzKBbzcfWS7nJwaO+u93yzyGMGiy+lpx4vp1UVh8uA3qJc7YWrSuUPLVLDPcybstP78gmdgSEm97i58w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733322445; c=relaxed/simple; bh=8kSlC422IeYzzzg01gqSDhhGR5XtczDm7IOevfiFGpg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YxjFIeFHUK5/dLJLqGjETyj90tlJVlSy+HOwAqhtSRDp7B4PttmIi63farSUEFg4Sb0VBHBWBA/CsXPZ4IepP8tXGREQ/0qFmvCebqKUe8V+smsK/t0ag/AEYw4B7mkLYQdEaNIfJuTRzCfT15NFqfceaRe1EPd03chRPRV/i74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BdFpiD9E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BdFpiD9E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F5A6C4CECD; Wed, 4 Dec 2024 14:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733322444; bh=8kSlC422IeYzzzg01gqSDhhGR5XtczDm7IOevfiFGpg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BdFpiD9Ehf6NJ3eXKMvlAfMjtslR49WOP1XgUzl8Ck2/Y6xhUo9QDz+XhMIbVjE45 eFZCibANpmxxsm8ynWVu518p2aaxX5pvpUjiWwJ3rL50jEhG4+crmF4GqsX+cGlAaF u3q4BVYokvbhtYT0F2HAj2uqIWUtSa/NzF9/pe/iHr7eXhLjT4RL8/r2z3XDX4OJpQ K7iLFPQx5+KMMN2w5WvvSClaxGbQsO9IHAAEIF+2l8VL3TB61Y7/VCkJFWkSfUuFqG JWEd0DwOXxYGfhjwMSg9DBQAKawNzvv6CLepS2tQA0KymkZBGUiOdZlz2DgRb4ULEe JWqZQZUMt6mXg== Date: Wed, 4 Dec 2024 08:27:22 -0600 From: Rob Herring To: Joey Lu Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org, conor+dt@kernel.org, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v4 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC Message-ID: <20241204142722.GA177756-robh@kernel.org> References: <20241202023643.75010-1-a0987203069@gmail.com> <20241202023643.75010-2-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202023643.75010-2-a0987203069@gmail.com> On Mon, Dec 02, 2024 at 10:36:41AM +0800, Joey Lu wrote: > Create initial schema for Nuvoton MA35 family Gigabit MAC. > > Signed-off-by: Joey Lu > --- > .../bindings/net/nuvoton,ma35d1-dwmac.yaml | 134 ++++++++++++++++++ > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > 2 files changed, 135 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml > new file mode 100644 > index 000000000000..e44abaf4da3e > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml > @@ -0,0 +1,134 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nuvoton,ma35d1-dwmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton DWMAC glue layer controller > + > +maintainers: > + - Joey Lu > + > +description: > + Nuvoton 10/100/1000Mbps Gigabit Ethernet MAC Controller is based on > + Synopsys DesignWare MAC (version 3.73a). > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - nuvoton,ma35d1-dwmac > + > + reg: > + maxItems: 1 > + description: > + Register range should be one of the GMAC interface. > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: MAC clock > + - description: PTP clock > + > + clock-names: > + items: > + - const: stmmaceth > + - const: ptp_ref > + > + nuvoton,sys: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to access syscon registers. > + - description: GMAC interface ID. > + enum: > + - 0 > + - 1 > + description: > + A phandle to the syscon with one argument that configures system registers > + for MA35D1's two GMACs. The argument specifies the GMAC interface ID. > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: stmmaceth > + > + phy-mode: > + enum: > + - rmii > + - rgmii > + - rgmii-id > + - rgmii-txid > + - rgmii-rxid > + > + tx-internal-delay-ps: > + default: 0 > + minimum: 0 > + maximum: 2000 > + description: > + RGMII TX path delay used only when PHY operates in RGMII mode with > + internal delay (phy-mode is 'rgmii-id' or 'rgmii-txid') in pico-seconds. > + Allowed values are from 0 to 2000. > + > + rx-internal-delay-ps: > + default: 0 > + minimum: 0 > + maximum: 2000 > + description: > + RGMII RX path delay used only when PHY operates in RGMII mode with > + internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds. > + Allowed values are from 0 to 2000. > + > + mdio: > + $ref: /schemas/net/mdio.yaml# Drop. snps,dwmac.yaml already has this. > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names Drop all 4. Already required by snps,dwmac.yaml. > + - clocks > + - clock-names > + - nuvoton,sys > + - resets > + - reset-names > + - phy-mode Drop this one too. > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + ethernet@40120000 { > + compatible = "nuvoton,ma35d1-dwmac"; > + reg = <0x40120000 0x10000>; > + interrupts = ; > + interrupt-names = "macirq"; > + clocks = <&clk EMAC0_GATE>, <&clk EPLL_DIV8>; > + clock-names = "stmmaceth", "ptp_ref"; > + > + nuvoton,sys = <&sys 0>; > + resets = <&sys MA35D1_RESET_GMAC0>; > + reset-names = "stmmaceth"; > + > + phy-mode = "rgmii-id"; > + phy-handle = <ð_phy0>; > + mdio { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@0 { > + reg = <0>; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index eb1f3ae41ab9..4bf59ab910cc 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -67,6 +67,7 @@ properties: > - ingenic,x2000-mac > - loongson,ls2k-dwmac > - loongson,ls7a-dwmac > + - nuvoton,ma35d1-dwmac > - qcom,qcs404-ethqos > - qcom,sa8775p-ethqos > - qcom,sc8280xp-ethqos > -- > 2.34.1 >