Re: [PATCH v2 05/15] iio: adc: rzg2l_adc: Switch to RUNTIME_PM_OPS() and pm_ptr()

Lad, Prabhakar
2024-12-08T20:32:29Z

On Fri, Dec 6, 2024 at 11:14 AM Claudiu <claudiu.beznea@tuxon.dev> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The use of SET_RUNTIME_PM_OPS() is now deprecated and requires
> __maybe_unused annotations to avoid warnings about unused functions.
> Switching to RUNTIME_PM_OPS() and pm_ptr() eliminates the need for such
> annotations because the compiler can directly reference the runtime PM
> functions, thereby suppressing the warnings. As a result, the
> __maybe_unused markings can be removed.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v2:
> - none
>
> drivers/iio/adc/rzg2l_adc.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
> index 780cb927eab1..482da6dcf174 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -454,7 +454,7 @@ static const struct of_device_id rzg2l_adc_match[] = {
> };
> MODULE_DEVICE_TABLE(of, rzg2l_adc_match);
>
> -static int __maybe_unused rzg2l_adc_pm_runtime_suspend(struct device *dev)
> +static int rzg2l_adc_pm_runtime_suspend(struct device *dev)
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct rzg2l_adc *adc = iio_priv(indio_dev);
> @@ -464,7 +464,7 @@ static int __maybe_unused rzg2l_adc_pm_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int __maybe_unused rzg2l_adc_pm_runtime_resume(struct device *dev)
> +static int rzg2l_adc_pm_runtime_resume(struct device *dev)
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct rzg2l_adc *adc = iio_priv(indio_dev);
> @@ -475,9 +475,7 @@ static int __maybe_unused rzg2l_adc_pm_runtime_resume(struct device *dev)
> }
>
> static const struct dev_pm_ops rzg2l_adc_pm_ops = {
> - SET_RUNTIME_PM_OPS(rzg2l_adc_pm_runtime_suspend,
> - rzg2l_adc_pm_runtime_resume,
> - NULL)
> + RUNTIME_PM_OPS(rzg2l_adc_pm_runtime_suspend, rzg2l_adc_pm_runtime_resume, NULL)
> };
>
> static struct platform_driver rzg2l_adc_driver = {
> @@ -485,7 +483,7 @@ static struct platform_driver rzg2l_adc_driver = {
> .driver = {
> .name = DRIVER_NAME,
> .of_match_table = rzg2l_adc_match,
> - .pm = &rzg2l_adc_pm_ops,
> + .pm = pm_ptr(&rzg2l_adc_pm_ops),
> },
> };
>
> --
> 2.39.2
>
>