Re: [PATCH v6 00/10] iio: adc: ad7124: Various fixes

Jonathan Cameron
2024-12-08T12:44:40Z

On Fri, 6 Dec 2024 18:28:32 +0100
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:

> Hello,
>
> here comes v6 of this series. Compared to v5
> (https://lore.kernel.org/linux-iio/20241203110019.1520071-12-u.kleine-koenig@baylibre.com)
> the following things changed:
>
> - Rebased to v6.13-rc1 + 64612ec9b909. (No changes needed here.)
>
> - Add Ack from Conor to patch #3
>
> - Fixed how R̅D̅Y̅ is written. This was wrong before because the overline
> char must be added after the character that should get the overline,
> not before. I got that wrong because of
> https://bugs.debian.org/1089108. I would expect that now this is
> properly shown in most browsers, MUAs and editors.
>
> I guess Andy still doesn't agree to write it that way. Jonathan,
> would you decide here please? If you agree with Andy I suggest to
> replace it by #RDY. Andy suggested #RDY_N which I think is too far
> away from the original name. If you (also) like R̅D̅Y̅, just keep it as
> is.
>
> - Fix error handling in patch #8
> I just pasted "return ret" to all callers of
> ad_sigma_delta_clear_pending_event() before. Now the error handling
> matches the actual needs of the context.
>
> - s/irq controller's capabilities/irq controller capabilities/
> as suggested by Andy for patch #8
>
> Best regards
> Uwe

Hi Uwe

Given the mix of fixes and other material (kind of fixes, but also kind
of new functionality), I've queued this for the next merge window in my
togreg branch. If you think there are particular patches that need to
go sooner then I can handle them in a split fashion, but that does add
risk that the whole lot might no land depending on timings (particularly
given it's coming into vacation season).

Initially pushed out as testing - I assume we'll see that sparse warning.

Thanks,

Jonathan

>
> Uwe Kleine-König (10):
> iio: adc: ad7124: Don't create more channels than the driver can handle
> iio: adc: ad7124: Refuse invalid input specifiers
> dt-bindings: iio: adc: adi,ad7{124,173,192,780}: Allow specifications of a gpio for irq line
> iio: adc: ad_sigma_delta: Add support for reading irq status using a GPIO
> iio: adc: ad_sigma_delta: Handle CS assertion as intended in ad_sd_read_reg_raw()
> iio: adc: ad_sigma_delta: Fix a race condition
> iio: adc: ad_sigma_delta: Store information about reset sequence length
> iio: adc: ad_sigma_delta: Check for previous ready signals
> iio: adc: ad7124: Add error reporting during probe
> iio: adc: ad7124: Implement temperature measurement
>
> .../bindings/iio/adc/adi,ad7124.yaml | 13 ++
> .../bindings/iio/adc/adi,ad7173.yaml | 12 +
> .../bindings/iio/adc/adi,ad7192.yaml | 15 ++
> .../bindings/iio/adc/adi,ad7780.yaml | 11 +
> drivers/iio/adc/ad7124.c | 217 +++++++++++++-----
> drivers/iio/adc/ad7173.c | 1 +
> drivers/iio/adc/ad7192.c | 4 +-
> drivers/iio/adc/ad7791.c | 1 +
> drivers/iio/adc/ad7793.c | 3 +-
> drivers/iio/adc/ad_sigma_delta.c | 194 +++++++++++++---
> include/linux/iio/adc/ad_sigma_delta.h | 8 +-
> 11 files changed, 390 insertions(+), 89 deletions(-)
>
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> prerequisite-patch-id: 617af17fc377a984762c61893b9f2a92ae62213a