Re: [PATCH v6 00/10] iio: adc: ad7124: Various fixes

Uwe Kleine-König
2024-12-12T11:28:05Z

[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]

On Wed, Dec 11, 2024 at 07:24:59PM +0000, Jonathan Cameron wrote:
> On Mon, 9 Dec 2024 10:47:29 +0100
> Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
>
> > Hello Jonathan,
> >
> > On Sun, Dec 08, 2024 at 12:44:27PM +0000, Jonathan Cameron wrote:
> > > Given the mix of fixes and other material (kind of fixes, but also kind
> > > of new functionality), I've queued this for the next merge window in my
> > > togreg branch. If you think there are particular patches that need to
> > > go sooner then I can handle them in a split fashion, but that does add
> > > risk that the whole lot might no land depending on timings (particularly
> > > given it's coming into vacation season).
> >
> > So you tend to not backport the rdy-gpios patches (i.e.
> >
> > dt-bindings: iio: adc: adi,ad7{124,173,192,780}: Allow specifications of a gpio for irq line
> > iio: adc: ad_sigma_delta: Add support for reading irq status using a GPIO
> >
> > )? I personally would want to have these backported, too, but I can
> > understand that you might decide that in a different way.
>
> Yeah. If it were tiny amount of code I might have gone the other way, but
> this just got a bit too complex.

I think it is easy to see that the changes for the rdy-gpios support has
zero impact if the device has no rdy-gpio. Then
devm_gpiod_get_optional() returns NULL and !sigma_delta->rdy_gpiod is
true and so nothing changes.

Of course it's subjective if you agree this to be easy to see, and also
if that matters for the backport.

> > Cherry picking
> >
> > iio: adc: ad_sigma_delta: Fix a race condition
> > iio: adc: ad_sigma_delta: Check for previous ready signals
> >
> > isn't trivial without the rdy-gpios, but they could be reworked. Tell me
> > if you want a helping hand (or an eye judging your backport).
>
> A backport won't go anywhere until these are upstream. At that point if you
> want them, feel free to suggest backporting these and provide the code ;)

I've not given up hope that you agree to backport also the rdy-gpio
change yet. I won't invest the work without knowing it's used in the
end. So I'll wait until the changes are upstream and you made up your
mind. Then if the need arises, I will help.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]