Re: [PATCH v6 08/10] iio: adc: ad_sigma_delta: Check for previous ready signals

Uwe Kleine-König
2024-12-17T10:23:17Z

[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]

Hello Jonathan,

On Fri, Dec 06, 2024 at 06:28:40PM +0100, Uwe Kleine-König wrote:
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
> index 101cf30f4458..d32102b25530 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> [...]
> @@ -222,6 +225,86 @@ static void ad_sd_enable_irq(struct ad_sigma_delta *sigma_delta)
> enable_irq(sigma_delta->irq_line);
> }
>
> +#define AD_SD_CLEAR_DATA_BUFLEN 9
> +
> +/* Called with `sigma_delta->bus_locked == true` only. */
> +static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta)
> +{
> + bool pending_event;
> + unsigned int data_read_len = BITS_TO_BYTES(sigma_delta->info->num_resetclks);
> + u8 *data;
> + struct spi_transfer t[] = {
> + {
> + .len = 1,
> + }, {
> + .len = data_read_len,
> + }
> + };
> + struct spi_message m;
> + int ret;
> +
> + /*
> + * Read R̅D̅Y̅ pin (if possible) or status register to check if there is an
> + * old event.
> + */
> + if (sigma_delta->rdy_gpiod) {
> + pending_event = gpiod_get_value(sigma_delta->rdy_gpiod);
> + } else {
> + unsigned status_reg;

While backporting this patch to a vendor tree I noticed checkpatch criticising:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

for the above line. Would you fixup an "int" into that line please, or
is that already too late?

Something like:

git checkout togreg
sed -i 's/unsigned status_reg;/unsigned int status_reg;/' drivers/iio/adc/ad_sigma_delta.c
git commit --fixup=132d44dc6966 drivers/iio/adc/ad_sigma_delta.c
git rebase -r --autosquash 132d44dc6966^

If it's already to late, I can prepare a proper patch for that.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]