Re: [PATCH v6 00/10] iio: adc: ad7124: Various fixes

Andy Shevchenko
2024-12-06T23:13:34Z

On Fri, Dec 6, 2024 at 7:29 PM Uwe Kleine-König
<u.kleine-koenig@baylibre.com> wrote:
>
> Hello,
>
> here comes v6 of this series. Compared to v5
> (https://lore.kernel.org/linux-iio/20241203110019.1520071-12-u.kleine-koenig@baylibre.com)
> the following things changed:
>
> - Rebased to v6.13-rc1 + 64612ec9b909. (No changes needed here.)
>
> - Add Ack from Conor to patch #3
>
> - Fixed how R̅D̅Y̅ is written. This was wrong before because the overline
> char must be added after the character that should get the overline,
> not before. I got that wrong because of
> https://bugs.debian.org/1089108. I would expect that now this is
> properly shown in most browsers, MUAs and editors.
>
> I guess Andy still doesn't agree to write it that way.

Yeah, I prefer a solid overline which Unicode simply incapable of, but
HTML does.
In any case the representation in this version is much better than in
the previous version.
I leave this up to Jonathan, but as I said an electrical engineer in
me is not satisfied.

> Jonathan,
> would you decide here please? If you agree with Andy I suggest to
> replace it by #RDY. Andy suggested #RDY_N which I think is too far
> away from the original name. If you (also) like R̅D̅Y̅, just keep it as
> is.
>
> - Fix error handling in patch #8
> I just pasted "return ret" to all callers of
> ad_sigma_delta_clear_pending_event() before. Now the error handling
> matches the actual needs of the context.
>
> - s/irq controller's capabilities/irq controller capabilities/
> as suggested by Andy for patch #8

--
With Best Regards,
Andy Shevchenko