From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh@kernel.org>, <conor+dt@kernel.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH 3/3] iio: frequency: adf4371: add ref doubler
Date: Sun, 8 Dec 2024 16:42:42 +0000 [thread overview]
Message-ID: <20241208164242.013ac089@jic23-huawei> (raw)
In-Reply-To: <20241206152207.37928-3-antoniu.miclaus@analog.com>
On Fri, 6 Dec 2024 17:22:06 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add support for the reference doubler.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> drivers/iio/frequency/adf4371.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/frequency/adf4371.c b/drivers/iio/frequency/adf4371.c
> index 55bee06fb42d..dc01f2aafb9a 100644
> --- a/drivers/iio/frequency/adf4371.c
> +++ b/drivers/iio/frequency/adf4371.c
> @@ -44,6 +44,8 @@
> /* ADF4371_REG22 */
> #define ADF4371_REFIN_MODE_MASK BIT(6)
> #define ADF4371_REFIN_MODE(x) FIELD_PREP(ADF4371_REFIN_MODE_MASK, x)
> +#define ADF4371_REF_DOUB_MASK BIT(5)
> +#define ADF4371_REF_DOUB(x) FIELD_PREP(ADF4371_REF_DOUB_MASK, x)\
>
> /* ADF4371_REG24 */
> #define ADF4371_RF_DIV_SEL_MSK GENMASK(6, 4)
> @@ -75,6 +77,9 @@
> #define ADF4371_MAX_FREQ_REFIN 600000000UL /* Hz */
> #define ADF4371_MAX_FREQ_REFIN_SE 500000000UL /* Hz */
>
> +#define ADF4371_MIN_CLKIN_DOUB_FREQ 10000000ULL /* Hz */
> +#define ADF4371_MAX_CLKIN_DOUB_FREQ 125000000ULL /* Hz */
> +
> /* MOD1 is a 24-bit primary modulus with fixed value of 2^25 */
> #define ADF4371_MODULUS1 33554432ULL
> /* MOD2 is the programmable, 14-bit auxiliary fractional modulus */
> @@ -480,7 +485,7 @@ static const struct iio_info adf4371_info = {
> static int adf4371_setup(struct adf4371_state *st)
> {
> unsigned int synth_timeout = 2, timeout = 1, vco_alc_timeout = 1;
> - unsigned int vco_band_div, tmp;
> + unsigned int vco_band_div, tmp, ref_doubler_en = 0;
> bool ref_diff_en;
> int ret;
>
> @@ -516,6 +521,10 @@ static int adf4371_setup(struct adf4371_state *st)
> (!ref_diff_en && st->clkin_freq > ADF4371_MAX_FREQ_REFIN_SE))
> return -EINVAL;
>
> + if (st->clkin_freq < ADF4371_MAX_CLKIN_DOUB_FREQ &&
> + st->clkin_freq > ADF4371_MIN_CLKIN_DOUB_FREQ)
> + ref_doubler_en = 1;
> +
> ret = regmap_update_bits(st->regmap, ADF4371_REG(0x22),
> ADF4371_REFIN_MODE_MASK,
> ADF4371_REFIN_MODE(ref_diff_en));
> @@ -531,7 +540,8 @@ static int adf4371_setup(struct adf4371_state *st)
> */
> do {
> st->ref_div_factor++;
> - st->fpfd = st->clkin_freq / st->ref_div_factor;
> + st->fpfd = (st->clkin_freq * (1 + ref_doubler_en)) /
> + (st->ref_div_factor);
No need for brackets on the previous line.
Otherwise this looks good to me.
> } while (st->fpfd > ADF4371_MAX_FREQ_PFD);
>
> /* Calculate Timeouts */
next prev parent reply other threads:[~2024-12-08 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 15:22 [PATCH 1/3] dt-bindings: iio: adf4371: add differential ref Antoniu Miclaus
2024-12-06 15:22 ` [PATCH 2/3] iio: frequency: " Antoniu Miclaus
2024-12-06 15:22 ` [PATCH 3/3] iio: frequency: adf4371: add ref doubler Antoniu Miclaus
2024-12-08 16:42 ` Jonathan Cameron [this message]
2024-12-08 16:41 ` [PATCH 1/3] dt-bindings: iio: adf4371: add differential ref Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241208164242.013ac089@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox