From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Alexandru Ardelean" <aardelean@baylibre.com>,
"Alisa-Dariana Roman" <alisa.roman@analog.com>,
"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
devicetree@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
linux-iio@vger.kernel.org,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sa" <nuno.sa@analog.com>,
"Renato Lui Geh" <renatogeh@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Trevor Gamblin" <tgamblin@baylibre.com>
Subject: Re: [PATCH v6 06/10] iio: adc: ad_sigma_delta: Fix a race condition
Date: Sun, 8 Dec 2024 18:23:46 +0000 [thread overview]
Message-ID: <20241208182346.423bfd06@jic23-huawei> (raw)
In-Reply-To: <CAHp75Vei1g6iL0qWV2Y7+L4M+kJyLfUDoWd0HiXRbAWqQSR0qQ@mail.gmail.com>
On Sun, 8 Dec 2024 15:05:38 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sun, Dec 8, 2024 at 2:42 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Fri, 6 Dec 2024 18:28:38 +0100
> > Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
>
> ...
>
> > From sparse.
> >
> > drivers/iio/adc/ad_sigma_delta.c:205:13: warning: context imbalance in 'ad_sd_disable_irq' - wrong count at exit
> > drivers/iio/adc/ad_sigma_delta.c:218:13: warning: context imbalance in 'ad_sd_enable_irq' - wrong count at exit
> >
> > I saw your discussion with Linus on this...
> >
> > https://lore.kernel.org/all/CAHk-=wiVDZejo_1BhOaR33qb=pny7sWnYtP4JUbRTXkXCkW6jA@mail.gmail.com/
> >
> > So I guess we just treat that as a false positive and move on.
>
> I'm wondering if sparse annotation __acquire and __release may help here...
The complaint is (I think) about guard(spinlock_irqsave)
so I'm not immediately sure how.
next prev parent reply other threads:[~2024-12-08 18:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 17:28 [PATCH v6 00/10] iio: adc: ad7124: Various fixes Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 01/10] iio: adc: ad7124: Don't create more channels than the driver can handle Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 02/10] iio: adc: ad7124: Refuse invalid input specifiers Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 03/10] dt-bindings: iio: adc: adi,ad7{124,173,192,780}: Allow specifications of a gpio for irq line Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 04/10] iio: adc: ad_sigma_delta: Add support for reading irq status using a GPIO Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 05/10] iio: adc: ad_sigma_delta: Handle CS assertion as intended in ad_sd_read_reg_raw() Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 06/10] iio: adc: ad_sigma_delta: Fix a race condition Uwe Kleine-König
2024-12-08 12:42 ` Jonathan Cameron
2024-12-08 13:05 ` Andy Shevchenko
2024-12-08 18:23 ` Jonathan Cameron [this message]
2024-12-09 0:52 ` Andy Shevchenko
2024-12-09 9:37 ` Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 07/10] iio: adc: ad_sigma_delta: Store information about reset sequence length Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 08/10] iio: adc: ad_sigma_delta: Check for previous ready signals Uwe Kleine-König
2024-12-17 10:23 ` Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 09/10] iio: adc: ad7124: Add error reporting during probe Uwe Kleine-König
2024-12-06 17:28 ` [PATCH v6 10/10] iio: adc: ad7124: Implement temperature measurement Uwe Kleine-König
2024-12-09 9:28 ` Uwe Kleine-König
2024-12-11 19:23 ` Jonathan Cameron
2024-12-06 23:12 ` [PATCH v6 00/10] iio: adc: ad7124: Various fixes Andy Shevchenko
2024-12-08 12:46 ` Jonathan Cameron
2024-12-08 12:44 ` Jonathan Cameron
2024-12-09 9:47 ` Uwe Kleine-König
2024-12-11 19:24 ` Jonathan Cameron
2024-12-12 11:28 ` Uwe Kleine-König
2024-12-12 11:44 ` Andy Shevchenko
2024-12-14 17:14 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241208182346.423bfd06@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=aardelean@baylibre.com \
--cc=alisa.roman@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dumitru.ceclan@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=renatogeh@gmail.com \
--cc=robh@kernel.org \
--cc=tgamblin@baylibre.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox