From: Rob Herring <robh@kernel.org>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Badhri Jagan Sridharan <badhri@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Kyle Tso <kyletso@google.com>, RD Babiera <rdbabiera@google.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: connector: Add pd-revision property
Date: Tue, 10 Dec 2024 17:06:15 -0600 [thread overview]
Message-ID: <20241210230615.GA766674-robh@kernel.org> (raw)
In-Reply-To: <20241205-get_rev_upstream-v1-1-90158ee7d75f@google.com>
On Thu, Dec 05, 2024 at 11:46:08PM -0800, Amit Sunil Dhamne wrote:
> Add pd-revision property definition, to specify the maximum Power
> Delivery Revision and Version supported by the connector.
>
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
> Documentation/devicetree/bindings/connector/usb-connector.yaml | 6 ++++++
> Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 67700440e23b5b7ca0db2c395c8a455bcf650864..341d2872e8d43450d219b7b72d48790051dc4e2b 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -293,6 +293,12 @@ properties:
> PD negotiation till BC1.2 detection completes.
> default: 0
>
> + pd-revision:
> + description: Specifies the maximum USB PD revision and version supported by
> + the connector. This property is specified in the following order;
> + <revision_major, revision_minor, version_major, version_minor>.
> + $ref: /schemas/types.yaml#/definitions/uint8-array
Always exactly 4 entries? Then:
maxItems: 4
> +
> dependencies:
> sink-vdos-v1: [ sink-vdos ]
> sink-vdos: [ sink-vdos-v1 ]
> diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> index 20b62228371bdedf2fe92767ffe443bec87babc5..350d39fbf2dcd4d99db07cb8f099467e6fc653ee 100644
> --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml
> @@ -70,6 +70,7 @@ examples:
> PDO_FIXED_DUAL_ROLE)
> PDO_FIXED(9000, 2000, 0)>;
> sink-bc12-completion-time-ms = <500>;
> + pd-revision = /bits/ 8 <0x03 0x01 0x01 0x08>;
> };
> };
> };
>
> --
> 2.47.0.338.g60cca15819-goog
>
next prev parent reply other threads:[~2024-12-10 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 7:46 [PATCH 0/3] Add support for responding to Get_Revision request Amit Sunil Dhamne via B4 Relay
2024-12-06 7:46 ` [PATCH 1/3] dt-bindings: connector: Add pd-revision property Amit Sunil Dhamne via B4 Relay
2024-12-06 16:52 ` Conor Dooley
2024-12-07 0:43 ` Amit Sunil Dhamne
2024-12-15 15:37 ` Conor Dooley
2024-12-10 23:06 ` Rob Herring [this message]
2024-12-11 2:55 ` Amit Sunil Dhamne
2024-12-06 7:46 ` [PATCH 2/3] usb: typec: tcpm: Add support for parsing pd-revision DT property Amit Sunil Dhamne via B4 Relay
2024-12-06 7:46 ` [PATCH 3/3] usb: typec: tcpm: Add new AMS for Get_Revision response Amit Sunil Dhamne via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210230615.GA766674-robh@kernel.org \
--to=robh@kernel.org \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).