From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E73F71D8DEA for ; Wed, 11 Dec 2024 08:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733905458; cv=none; b=lwOd9cvMX0IdiWTqCg2i+UhoUKOZpBf/UR/qhUaRJBqE9e8qBJg9zwGAWH8tqpSiOXfYWWgDxYbG1nkv52qnp6zNeWR53WPpBmNtT08dvZ/9tKPck2eYAcKjhQ8Tk2HBO7VeMl7AcxOycvj3Y4fyiFvDemj8j7jDq2Uex7JDA70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733905458; c=relaxed/simple; bh=hU8ic9mPL/Bg2bJjsyKXRHBm1+CN3DAjSXMLP5ZIzUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dG6zZE55sprcNc87D/t0ENY9CYDDY8fN1TLRM6h3eKEZpimWnBF4OD9JAoPFnSoN3i+qRn0zb6LsdBSX6EKD1se39atKlLhLcURzx0ATQPqH/EPKzg6JMZudODzotvMJHY8c8zsa5x0KXDTFK3ErrDubS1T0L/xGOK+vE8YLYlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EcH1X+X6; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EcH1X+X6" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7fbc65f6c72so6362361a12.1 for ; Wed, 11 Dec 2024 00:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733905456; x=1734510256; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xjyvF7kb3Fj9Wqsey0yFF+HNeDsO4egY2+tvcam+GFQ=; b=EcH1X+X6Mm91AeYm8uXTKZLhLNaM5nr3nDuPPmfvEPsktM/tZwXDT+aL1aZ3ZCNrRy s2FzBpEOWHGQYGvoxR9fn4NY8DYyVIgGiGWyWHlS8eTMfuVv9pkqVfGv7MdjYfYw3ZlN G/8mkN2bAKtSby3HzY2Uh1v1FxVXxov3u1ryUaXlKsMeLpATOlzSpEGxJNsOz1n42toI My3eF2H0SrXmQVHEAlrrvtx/qX4XWo/DNBG3zD5NkYM1Vv7XlGJFGesteG868OX7MBEC 8qumcdcoJ7GhMafyIMJMtP90b5qkO4aGr9u5gbCx9Zv3R0l1nszozWSFPrkOEjqevVvL EVpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733905456; x=1734510256; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xjyvF7kb3Fj9Wqsey0yFF+HNeDsO4egY2+tvcam+GFQ=; b=gAY6Jv8oybKxlFAKCISLF1wObH/H+MLb0S62lYuvOOCyWtSX7A3cMUuk7PbvBJ9HqK vqdSXSHmmIR9VjvWuUmwWstkZCJdy8Uctom91jK2mO4Bh0hexHKTxO7y+L60E/yifB20 /5u/VE8ZDrS2QygL/5vk0DjhYuG2RU0rrtKS5zy2q0nWpYyAC+yUlVQWoVNgnyTQ3iNk wkhQ10b7HhYZGTfyMiLPkcfekSeV+jNfMre78viRJhBXYjIMY7z6nGLmdGjgAq5yf2DP 4s/ngeuzfmzcq9oj4R2eVZnAiwfNeiX4ymFfabQ/rgqQ7+0RKhcZXbLaPe29TG4G0s0o XQNw== X-Forwarded-Encrypted: i=1; AJvYcCUPqDCHCUefNKCwMIv6bizR5X/EMJPdRThJub34QzaYHtRs0a4kfKapEZcHqH+7XqccGlNpmwNpMEFr@vger.kernel.org X-Gm-Message-State: AOJu0Yz7sL/zs3OOLMSc1U39lyGQekipu6GrlkXcM6OfnVW4Gu0H3A/f cBN38uhc1+KTKh5BnaVs71b9jyCJCjAvw71OLpnjYN1lHXXpGwj5YBhjmU3qXQ== X-Gm-Gg: ASbGncv+79KIAHDZZHK7IQpA1wdrXET46eFAymSMDz9u9haLC07Ap/IwDvTkJQS00F9 An/8ZbIdwNsjzSR+kggME+6OhVAZ7nQpjUXkDHZ5Qk4fpcm7qLOBs1SlEjb0j3qsRZCODIBk8vR vf85yPa1GjcH0XRPgdejzW6VPVtws7xhZZUP5TgkgLQ0PvJj0vqQKmau6vyuvMhhhdpyt0AR1xj GL/P2GAJvbxKwHNbZBt4wRTFl6n2cdzBz6K4rRDNuFcxvnRwXRGPpYM7blfr54= X-Google-Smtp-Source: AGHT+IHAA8av2ZjtMDzhDwJWK9BDEonm49fwB5KzeIRHQyFoeoJaUDA8Pre4/aT4K/XkNchmbfmmOQ== X-Received: by 2002:a05:6a20:72a4:b0:1e1:9f57:eac1 with SMTP id adf61e73a8af0-1e1c126f5d5mr4443839637.8.1733905456230; Wed, 11 Dec 2024 00:24:16 -0800 (PST) Received: from thinkpad ([120.60.55.53]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fd2f40dc81sm6568577a12.64.2024.12.11.00.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 00:24:15 -0800 (PST) Date: Wed, 11 Dec 2024 13:54:04 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Ziyue Zhang , vkoul@kernel.org, kishon@kernel.org, dmitry.baryshkov@linaro.org, abel.vesa@linaro.org, neil.armstrong@linaro.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,qmp-pcie: add optional current load properties Message-ID: <20241211082404.p7fbmhooikmipxvm@thinkpad> References: <20241204105249.3544114-1-quic_ziyuzhan@quicinc.com> <20241204105249.3544114-2-quic_ziyuzhan@quicinc.com> <20241211062053.vxdpovlmetvyx3za@thinkpad> <33697bd9-02f4-4a9a-b8c0-4930d7fdaee2@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33697bd9-02f4-4a9a-b8c0-4930d7fdaee2@kernel.org> On Wed, Dec 11, 2024 at 09:09:18AM +0100, Krzysztof Kozlowski wrote: > On 11/12/2024 07:20, Manivannan Sadhasivam wrote: > > On Thu, Dec 05, 2024 at 11:23:11AM +0100, Krzysztof Kozlowski wrote: > >> On Wed, Dec 04, 2024 at 06:52:47PM +0800, Ziyue Zhang wrote: > >>> On some platforms, the power supply for PCIe PHY is not able to provide > >>> enough current when it works in LPM mode. Hence, PCIe PHY driver needs to > >>> set current load to vote the regulator to HPM mode. > >>> > >>> Document the current load as properties for each power supply PCIe PHY > >>> required, namely vdda-phy-max-microamp, vdda-pll-max-microamp and > >>> vdda-qref-max-microamp, respectively.PCIe PHY driver should parse them to > >>> set appropriate current load during PHY power on. > >>> > >>> This three properties are optional and not mandatory for those platforms > >>> that PCIe PHY can still work with power supply. > >> > >> > >> Uh uh, so the downstream comes finally! > >> > >> No sorry guys, use existing regulator bindings for this. > >> > > > > Maybe they got inspired by upstream UFS bindings? > > Documentation/devicetree/bindings/ufs/ufs-common.yaml: > > > > vcc-max-microamp > > vccq-max-microamp > > vccq2-max-microamp > > And it is already an ABI, so we cannot do anything about it. > > > > > Regulator binding only describes the min/max load for the regulators and not > > No, it exactly describes min/max consumers can use. Let's quote: > "largest current consumers may set" > It is all about consumers. > > > consumers. What if the consumers need to set variable load per platform? Should > > Then each platform uses regulator API or regulator bindings to set it? I > don't see the problem here. > > > they hardcode the load in driver? (even so, the load should not vary for each > > board). > > The load must vary per board, because regulators vary per board. Of > course in practice most designs could be the same, but regulators and > their limits are always properties of the board, not the SoC. > How the consumer drivers are supposed to know the optimum load? I don't see how the consumer drivers can set the load without hardcoding the values. And I could see from UFS properties that each board has different values. - Mani -- மணிவண்ணன் சதாசிவம்