Re: [PATCH v5 02/10] iio: accel: adxl345: rename variable data to st

Jonathan Cameron
2024-12-11T18:42:36Z

On Tue, 10 Dec 2024 18:31:57 +0100
Lothar Rubusch <l.rubusch@gmail.com> wrote:

> Hi,
>
> On Sun, Dec 8, 2024 at 2:28 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Thu, 5 Dec 2024 17:13:35 +0000
> > Lothar Rubusch <l.rubusch@gmail.com> wrote:
> >
> > > Rename the locally used variable data to st. The st refers to "state",
> > > representing the internal state of the driver object. Further it
> > > prepares the usage of an internal data pointer needed for the
> > > implementation of the sensor features.
> > >
> > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
> > Applied to the togreg branch of iio.git. Initially pushed out as testing
> > to let the bots take a look.
>
> Should I actually drop the "applied" patches in a v6? Or, may I keep them?

Rebase on top of my testing branch or just drop them. Either works.

>
> I see that Dan Carpenters smatch now comes up with some issues. So, do
> the fixes go into v6 here, or better separate?
If for things I've picked up, then separate fixup at the beginning of
your v6. I might squash them into original patches if I haven't pushed
out as togreg yet or they are particularly bad and I think worth potentially
work giving others a messy rebase.

Jonathan

>
> Best,
> L