Re: [PATCH v5 09/10] iio: accel: adxl345: prepare channel for scan_index

Jonathan Cameron
2024-12-08T16:17:32Z

On Thu, 5 Dec 2024 17:13:42 +0000
Lothar Rubusch <l.rubusch@gmail.com> wrote:

> Add separate fields for register and index to the channel definition.
> The scan_index is set up with the kfifo in the follow up patches.
>
> Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
I'd just squash this with the net patch. It's a trivial change and there
isn't anything specific to really highlight in this description.
Also, scan_index separate from the stuff about the format seems odd.

Jonathan

> ---
> drivers/iio/accel/adxl345_core.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
> index 0696e908bdf..3067a70c54e 100644
> --- a/drivers/iio/accel/adxl345_core.c
> +++ b/drivers/iio/accel/adxl345_core.c
> @@ -26,21 +26,26 @@ struct adxl345_state {
> u8 intio;
> };
>
> -#define ADXL345_CHANNEL(index, axis) { \
> +#define ADXL345_CHANNEL(index, reg, axis) { \
> .type = IIO_ACCEL, \
> .modified = 1, \
> .channel2 = IIO_MOD_##axis, \
> - .address = index, \
> + .address = (reg), \
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> BIT(IIO_CHAN_INFO_CALIBBIAS), \
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) | \
> BIT(IIO_CHAN_INFO_SAMP_FREQ), \
> + .scan_index = (index), \
> }
>
> +enum adxl345_chans {
> + chan_x, chan_y, chan_z,
> +};
> +
> static const struct iio_chan_spec adxl345_channels[] = {
> - ADXL345_CHANNEL(0, X),
> - ADXL345_CHANNEL(1, Y),
> - ADXL345_CHANNEL(2, Z),
> + ADXL345_CHANNEL(0, chan_x, X),
> + ADXL345_CHANNEL(1, chan_y, Y),
> + ADXL345_CHANNEL(2, chan_z, Z),
> };
>
> static int adxl345_read_raw(struct iio_dev *indio_dev,