Re: [PATCH leds v7 03/11] turris-omnia-mcu-interface.h: Add LED commands related definitions to global header

[Lee Jones <lee@kernel.org>]

On Mon, 11 Nov 2024, Marek Behún wrote:

> Add definitions for contents of the OMNIA_CMD_LED_MODE and
> OMNIA_CMD_LED_STATE commands to the global turris-omnia-mcu-interface.h
> header.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
>  include/linux/turris-omnia-mcu-interface.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/include/linux/turris-omnia-mcu-interface.h b/include/linux/turris-omnia-mcu-interface.h
> index 7f24cc682780..06c94e032c6f 100644
> --- a/include/linux/turris-omnia-mcu-interface.h
> +++ b/include/linux/turris-omnia-mcu-interface.h
> @@ -239,6 +239,18 @@ enum omnia_int_e {
>  	OMNIA_INT_LAN5_LED1		= BIT(31),
>  };
>  
> +enum omnia_cmd_led_mode_e {
> +	OMNIA_CMD_LED_MODE_LED_MASK	= GENMASK(3, 0),
> +#define OMNIA_CMD_LED_MODE_LED(_l)	FIELD_PREP(OMNIA_CMD_LED_MODE_LED_MASK, _l)
> +	OMNIA_CMD_LED_MODE_USER		= BIT(4),
> +};
> +
> +enum omnia_cmd_led_state_e {
> +	OMNIA_CMD_LED_STATE_LED_MASK	= GENMASK(3, 0),
> +#define OMNIA_CMD_LED_STATE_LED(_l)	FIELD_PREP(OMNIA_CMD_LED_STATE_LED_MASK, _l)
> +	OMNIA_CMD_LED_STATE_ON		= BIT(4),
> +};

I'm going to take this set now as-is, but can you submit a patch moving
these #defines out of the enum block please?

-- 
Lee Jones [李琼斯]