From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Luca Weiss <luca.weiss@fairphone.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v3 04/23] arm64: dts: qcom: sm8450: Fix ADSP memory base and length
Date: Fri, 13 Dec 2024 15:53:53 +0100 [thread overview]
Message-ID: <20241213-dts-qcom-cdsp-mpss-base-address-v3-4-2e0036fccd8d@linaro.org> (raw)
In-Reply-To: <20241213-dts-qcom-cdsp-mpss-base-address-v3-0-2e0036fccd8d@linaro.org>
The address space in ADSP PAS (Peripheral Authentication Service)
remoteproc node should point to the QDSP PUB address space
(QDSP6...SS_PUB): 0x0300_0000 with length of 0x10000, which also matches
downstream DTS. 0x3000_0000, value used so far, was in datasheet is the
region of CDSP.
Correct the base address and length, which also moves the node to
different place to keep things sorted by unit address. The diff looks
big, but only the unit address and "reg" property were changed. This
should have no functional impact on Linux users, because PAS loader does
not use this address space at all.
Fixes: 1172729576fb ("arm64: dts: qcom: sm8450: Add remoteproc enablers and instances")
Cc: stable@vger.kernel.org
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 212 +++++++++++++++++------------------
1 file changed, 106 insertions(+), 106 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 53147aa6f7e4acb102dd5dee51f0aec164b971c7..d028079c11bdc2dd2b254f7f7d85e315a86f79bc 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2496,6 +2496,112 @@ compute-cb@3 {
};
};
+ remoteproc_adsp: remoteproc@3000000 {
+ compatible = "qcom,sm8450-adsp-pas";
+ reg = <0x0 0x03000000 0x0 0x10000>;
+
+ interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "wdog", "fatal", "ready",
+ "handover", "stop-ack";
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "xo";
+
+ power-domains = <&rpmhpd RPMHPD_LCX>,
+ <&rpmhpd RPMHPD_LMX>;
+ power-domain-names = "lcx", "lmx";
+
+ memory-region = <&adsp_mem>;
+
+ qcom,qmp = <&aoss_qmp>;
+
+ qcom,smem-states = <&smp2p_adsp_out 0>;
+ qcom,smem-state-names = "stop";
+
+ status = "disabled";
+
+ remoteproc_adsp_glink: glink-edge {
+ interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_GLINK_QMP
+ IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_GLINK_QMP>;
+
+ label = "lpass";
+ qcom,remote-pid = <2>;
+
+ gpr {
+ compatible = "qcom,gpr";
+ qcom,glink-channels = "adsp_apps";
+ qcom,domain = <GPR_DOMAIN_ID_ADSP>;
+ qcom,intents = <512 20>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ q6apm: service@1 {
+ compatible = "qcom,q6apm";
+ reg = <GPR_APM_MODULE_IID>;
+ #sound-dai-cells = <0>;
+ qcom,protection-domain = "avs/audio",
+ "msm/adsp/audio_pd";
+
+ q6apmdai: dais {
+ compatible = "qcom,q6apm-dais";
+ iommus = <&apps_smmu 0x1801 0x0>;
+ };
+
+ q6apmbedai: bedais {
+ compatible = "qcom,q6apm-lpass-dais";
+ #sound-dai-cells = <1>;
+ };
+ };
+
+ q6prm: service@2 {
+ compatible = "qcom,q6prm";
+ reg = <GPR_PRM_MODULE_IID>;
+ qcom,protection-domain = "avs/audio",
+ "msm/adsp/audio_pd";
+
+ q6prmcc: clock-controller {
+ compatible = "qcom,q6prm-lpass-clocks";
+ #clock-cells = <2>;
+ };
+ };
+ };
+
+ fastrpc {
+ compatible = "qcom,fastrpc";
+ qcom,glink-channels = "fastrpcglink-apps-dsp";
+ label = "adsp";
+ qcom,non-secure-domain;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ compute-cb@3 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <3>;
+ iommus = <&apps_smmu 0x1803 0x0>;
+ };
+
+ compute-cb@4 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <4>;
+ iommus = <&apps_smmu 0x1804 0x0>;
+ };
+
+ compute-cb@5 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <5>;
+ iommus = <&apps_smmu 0x1805 0x0>;
+ };
+ };
+ };
+ };
+
wsa2macro: codec@31e0000 {
compatible = "qcom,sm8450-lpass-wsa-macro";
reg = <0 0x031e0000 0 0x1000>;
@@ -2692,112 +2798,6 @@ vamacro: codec@33f0000 {
status = "disabled";
};
- remoteproc_adsp: remoteproc@30000000 {
- compatible = "qcom,sm8450-adsp-pas";
- reg = <0 0x30000000 0 0x100>;
-
- interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
- <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
- <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
- <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
- <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;
- interrupt-names = "wdog", "fatal", "ready",
- "handover", "stop-ack";
-
- clocks = <&rpmhcc RPMH_CXO_CLK>;
- clock-names = "xo";
-
- power-domains = <&rpmhpd RPMHPD_LCX>,
- <&rpmhpd RPMHPD_LMX>;
- power-domain-names = "lcx", "lmx";
-
- memory-region = <&adsp_mem>;
-
- qcom,qmp = <&aoss_qmp>;
-
- qcom,smem-states = <&smp2p_adsp_out 0>;
- qcom,smem-state-names = "stop";
-
- status = "disabled";
-
- remoteproc_adsp_glink: glink-edge {
- interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
- IPCC_MPROC_SIGNAL_GLINK_QMP
- IRQ_TYPE_EDGE_RISING>;
- mboxes = <&ipcc IPCC_CLIENT_LPASS
- IPCC_MPROC_SIGNAL_GLINK_QMP>;
-
- label = "lpass";
- qcom,remote-pid = <2>;
-
- gpr {
- compatible = "qcom,gpr";
- qcom,glink-channels = "adsp_apps";
- qcom,domain = <GPR_DOMAIN_ID_ADSP>;
- qcom,intents = <512 20>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- q6apm: service@1 {
- compatible = "qcom,q6apm";
- reg = <GPR_APM_MODULE_IID>;
- #sound-dai-cells = <0>;
- qcom,protection-domain = "avs/audio",
- "msm/adsp/audio_pd";
-
- q6apmdai: dais {
- compatible = "qcom,q6apm-dais";
- iommus = <&apps_smmu 0x1801 0x0>;
- };
-
- q6apmbedai: bedais {
- compatible = "qcom,q6apm-lpass-dais";
- #sound-dai-cells = <1>;
- };
- };
-
- q6prm: service@2 {
- compatible = "qcom,q6prm";
- reg = <GPR_PRM_MODULE_IID>;
- qcom,protection-domain = "avs/audio",
- "msm/adsp/audio_pd";
-
- q6prmcc: clock-controller {
- compatible = "qcom,q6prm-lpass-clocks";
- #clock-cells = <2>;
- };
- };
- };
-
- fastrpc {
- compatible = "qcom,fastrpc";
- qcom,glink-channels = "fastrpcglink-apps-dsp";
- label = "adsp";
- qcom,non-secure-domain;
- #address-cells = <1>;
- #size-cells = <0>;
-
- compute-cb@3 {
- compatible = "qcom,fastrpc-compute-cb";
- reg = <3>;
- iommus = <&apps_smmu 0x1803 0x0>;
- };
-
- compute-cb@4 {
- compatible = "qcom,fastrpc-compute-cb";
- reg = <4>;
- iommus = <&apps_smmu 0x1804 0x0>;
- };
-
- compute-cb@5 {
- compatible = "qcom,fastrpc-compute-cb";
- reg = <5>;
- iommus = <&apps_smmu 0x1805 0x0>;
- };
- };
- };
- };
-
remoteproc_cdsp: remoteproc@32300000 {
compatible = "qcom,sm8450-cdsp-pas";
reg = <0 0x32300000 0 0x1400000>;
--
2.43.0
next prev parent reply other threads:[~2024-12-13 14:54 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 14:53 [PATCH v3 00/23] arm64: dts: qcom: Fix remoteproc memory base and length Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 01/23] arm64: dts: qcom: sm8350: Fix ADSP " Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 02/23] arm64: dts: qcom: sm8350: Fix CDSP " Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 03/23] arm64: dts: qcom: sm8350: Fix MPSS memory length Krzysztof Kozlowski
2024-12-13 14:53 ` Krzysztof Kozlowski [this message]
2024-12-13 14:53 ` [PATCH v3 05/23] arm64: dts: qcom: sm8450: Fix CDSP " Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 06/23] arm64: dts: qcom: sm8450: Fix MPSS " Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 07/23] arm64: dts: qcom: sm8550: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 08/23] arm64: dts: qcom: sm8550: Fix CDSP memory length Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 09/23] arm64: dts: qcom: sm8550: Fix MPSS " Krzysztof Kozlowski
2024-12-13 14:53 ` [PATCH v3 10/23] arm64: dts: qcom: sm8650: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-13 14:54 ` [PATCH v3 11/23] arm64: dts: qcom: sm8650: Fix CDSP memory length Krzysztof Kozlowski
2024-12-13 14:54 ` [PATCH v3 12/23] arm64: dts: qcom: sm8650: Fix MPSS " Krzysztof Kozlowski
2024-12-13 14:54 ` [PATCH v3 13/23] arm64: dts: qcom: x1e80100: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-13 15:35 ` Johan Hovold
2024-12-13 15:45 ` Krzysztof Kozlowski
2024-12-13 16:01 ` Johan Hovold
2024-12-13 14:54 ` [PATCH v3 14/23] arm64: dts: qcom: x1e80100: Fix CDSP memory length Krzysztof Kozlowski
2024-12-13 15:37 ` Johan Hovold
2024-12-13 14:54 ` [PATCH v3 15/23] arm64: dts: qcom: sm6350: Fix ADSP " Krzysztof Kozlowski
2024-12-13 14:54 ` [PATCH v3 16/23] arm64: dts: qcom: sm6350: Fix MPSS " Krzysztof Kozlowski
2024-12-13 14:54 ` [PATCH RFT v3 17/23] arm64: dts: qcom: sm6375: Fix ADSP " Krzysztof Kozlowski
2024-12-19 20:30 ` Konrad Dybcio
2024-12-13 14:54 ` [PATCH RFT v3 18/23] arm64: dts: qcom: sm6375: Fix CDSP memory base and length Krzysztof Kozlowski
2024-12-19 20:31 ` Konrad Dybcio
2024-12-13 14:54 ` [PATCH RFT v3 19/23] arm64: dts: qcom: sm6375: Fix MPSS " Krzysztof Kozlowski
2024-12-19 20:32 ` Konrad Dybcio
2024-12-13 14:54 ` [PATCH v3 20/23] arm64: dts: qcom: sdx75: Fix MPSS memory length Krzysztof Kozlowski
2024-12-13 14:56 ` Konrad Dybcio
2024-12-13 15:06 ` Krzysztof Kozlowski
2024-12-13 15:08 ` Konrad Dybcio
2024-12-13 14:54 ` [PATCH v3 21/23] arm64: dts: qcom: sm6115: " Krzysztof Kozlowski
2024-12-13 14:57 ` Konrad Dybcio
2024-12-13 14:54 ` [PATCH v3 22/23] arm64: dts: qcom: sm6115: Fix CDSP " Krzysztof Kozlowski
2024-12-13 14:58 ` Konrad Dybcio
2024-12-13 14:54 ` [PATCH v3 23/23] arm64: dts: qcom: sm6115: Fix ADSP memory base and length Krzysztof Kozlowski
2024-12-13 14:58 ` Konrad Dybcio
2024-12-23 9:21 ` [PATCH v3 00/23] arm64: dts: qcom: Fix remoteproc " Aiqun(Maria) Yu
2024-12-23 10:52 ` Konrad Dybcio
2024-12-23 14:29 ` Krzysztof Kozlowski
2025-01-07 16:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213-dts-qcom-cdsp-mpss-base-address-v3-4-2e0036fccd8d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).