Re: [PATCH v4] dt-bindings: mfd: sprd,sc2731: reference sprd,sc2731-efuse bindings

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2102 bytes --]

On Mon, Dec 16, 2024 at 11:13:24AM +0100, Stanislav Jakubek wrote:
> Directly reference the sc2731-efuse bindings to simplify the schema.
> Remove the duplicate example from the efuse bindings.
> While at it, add the "pmic_adc" label that was missed during the
> initial YAML conversion.
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> ---
> Changes in V4:
> - rebase on next-20241216
> - drop patch 1 (already applied)
> - add the pmic_adc label that was initially missed
> 
> Changes in V3:
> - new patch due to a missing dependency in the MFD tree 
> 
> Link to V3: https://lore.kernel.org/lkml/cd8cc95b59c31418b174bba521dd2599a7929fda.1730709384.git.stano.jakubek@gmail.com/
> Link to V2: https://lore.kernel.org/lkml/ZyExK01iprBHhGm6@standask-GA-A55M-S2HP/
> Link to V1: https://lore.kernel.org/lkml/Zr3X1RoQs7ElTnlJ@standask-GA-A55M-S2HP/
> 
>  .../devicetree/bindings/mfd/sprd,sc2731.yaml  | 12 ++------
>  .../bindings/nvmem/sprd,sc2731-efuse.yaml     | 29 -------------------
>  2 files changed, 2 insertions(+), 39 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> index 8beec7e8e4c6..b023e1ef8d3c 100644
> --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> @@ -67,15 +67,7 @@ patternProperties:
>  
>    "^efuse@[0-9a-f]+$":
>      type: object
> -    additionalProperties: true
> -    properties:
> -      compatible:
> -        enum:
> -          - sprd,sc2720-efuse
> -          - sprd,sc2721-efuse
> -          - sprd,sc2723-efuse
> -          - sprd,sc2730-efuse
> -          - sprd,sc2731-efuse
> +    $ref: /schemas/nvmem/sprd,sc2731-efuse.yaml#
>  
>    "^fuel-gauge@[0-9a-f]+$":
>      type: object
> @@ -199,7 +191,7 @@ examples:
>            };
>          };
>  
> -        adc@480 {
> +        pmic_adc: adc@480 {

I don't understand the point of this hunk, nothing ever references it.
Examples aren't supposed to contain unused labels.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]