From: Conor Dooley <conor@kernel.org>
To: E Shattow <e@freeshell.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Hal Feng <hal.feng@starfivetech.com>,
Jianlong Huang <jianlong.huang@starfivetech.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Date: Mon, 16 Dec 2024 20:09:09 +0000 [thread overview]
Message-ID: <20241216-nuttiness-arrogant-27063bd1c47b@spud> (raw)
In-Reply-To: <e4e19875-c02c-4673-814b-86090223b55d@freeshell.de>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Fri, Dec 13, 2024 at 11:58:29AM -0800, E Shattow wrote:
> Hi Krzysztof,
>
> On 12/13/24 01:37, Krzysztof Kozlowski wrote:
> > On Mon, Dec 09, 2024 at 08:19:56PM -0800, E Shattow wrote:
> > > Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
> > >
> > > Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
> > > Signed-off-by: E Shattow <e@freeshell.de>
> > > Acked-by: Hal Feng <hal.feng@starfivetech.com>
> > > ---
> >
> > Why are you sending the same multiple times? Where is the changelog and
> > proper patch versioning?
> >
> > Best regards,
> > Krzysztof
> >
>
> I did respond to Hal's comment that the patch is missing a commit title
> description and that I would re-send. How instead should the message be
> formatted so the patch commit title description is changed but the patch is
> not the same being sent multiple times? And now, again, based on your
> comment that this is not a typo I will again change the commit description
> but I don't know how to do that without sending again as a duplicate.
>
> Thank you for the review and for your patience with me when I am learning
> how to participate.
FWIW, this should be v2. Don't resend for that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-16 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 4:19 [PATCH] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions E Shattow
2024-12-13 9:37 ` Krzysztof Kozlowski
2024-12-13 19:58 ` E Shattow
2024-12-16 20:09 ` Conor Dooley [this message]
2024-12-16 20:12 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216-nuttiness-arrogant-27063bd1c47b@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=e@freeshell.de \
--cc=hal.feng@starfivetech.com \
--cc=jianlong.huang@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox