From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC14D1F0E2C for ; Wed, 18 Dec 2024 16:11:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734538262; cv=none; b=Oxq3Zqug7eKTa37bqLNsGJ3dcKW9GQQrmk6mZJJWUa2RM49Ej2HCTY71D7BSvx1nwVX3RyXOUuFemFNiP0Dgiz8qYFE0lYQ254pJs0tjqt6dmoa43x47PS94z1tHUWwnrUy7vVNgwPIQ/UJ3S39WLrSMY29ZikAKMQgVIKsyjWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734538262; c=relaxed/simple; bh=1Gk0KV03HG2uxujhvGDXC3rHVzPAgouln8SZSXFcWeQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hBqe1Os3fEQxvpjIVVLaV7cLKaVcpX6G4eBLp49F8dVc73kroFHRfofn8Vi9iDsvqczGh+vTHnf1U8hwx3PGKx7qp1BbzmaJDje+6XxrlntwAMZx35H8CbsTsqU+SGJNqYqHcTtdodYjyVbPYbv87Ym0nNJTK24v6NTB8puzUhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CyDdt3Ld; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CyDdt3Ld" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8487AC4CECD; Wed, 18 Dec 2024 16:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734538262; bh=1Gk0KV03HG2uxujhvGDXC3rHVzPAgouln8SZSXFcWeQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CyDdt3LdLlL6HwReTDDCbzvkwB59dO36Xmf0oyvxWZoPl+4LqKhzt4OKatwZ8cJVB JEP7YFqo5LZmeGTo/q67ZG3U4IAQJVSA339J3CR+nePcsgdspHpfSjsfoX8qKnzaWj JhOt1VF6RKvuHJCl4X4fMMwa/G5Y2knNgxfBU/GKvrm7lyem8MaNEedXpIWM/rTqqj wlUEp6fdXoO33bxj2kB1BnemJHFMzERLeWthRRrwijNoL86nfbT6olhpGkC8pGajaX H8nTStu/hFBWqwLPYFfHrROUlPS6r9jsF2r8tcPhKYZ7Qx0Q/JcUq/Nab3cqREmW4J +CY5eBp4+qz2Q== Date: Wed, 18 Dec 2024 16:10:59 +0000 From: Conor Dooley To: Poojaa Rangaiah Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH] dtoverlays: Added DT overlay file for MAX98090 and the detailed steps for its usage is included in https://github.com/Poojaa-Rangaiah/DeviceTreeOverlay-for-MAX98090 . Message-ID: <20241218-widen-ladies-8539476e3b80@spud> References: <20241218065848.12254-1-poojaamonica94@gmail.com> <20241218-arrange-pointer-cdd39770b48b@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kF7nJA3fJHxMxL+t" Content-Disposition: inline In-Reply-To: --kF7nJA3fJHxMxL+t Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 18, 2024 at 09:25:13PM +0530, Poojaa Rangaiah wrote: >=20 > On Wed, Dec 18, 2024, 7:58=E2=80=AFPM Conor Dooley wro= te: >=20 > > On Wed, Dec 18, 2024 at 12:28:48PM +0530, Poojaa R wrote: > > > Only the driver files were existing for max98090 audio codec (playback > > and capture) but now the max98090.dts file is also included in > > linux/arch/arm/boot/dts/overlays/. > > > new file: arch/arm/boot/dts/overlays/max98090.dts > > > > > > Signed-off-by: Poojaa R > > > > Why have you send this patch for your random github tree to lkml? > Sorry for that, I wanted it to be just mentioned in commits so people who > don't have an idea can refer to it. But I didn't expect that to be > mentioned in the subject. Right, so it is not a random patch but one you want included in mainline? Given this is something only usable on the RPi, you should move this file to the broadcom directory and CC the relevant maintainers. Additionally, the correct filetype for overlays is .dtso nor should there be dtso files in the kernel tree that are never built. Cheers, Conor. > > > > Thanks, > > Conor. > > > > > --- > > > arch/arm/boot/dts/overlays/max98090.dts | 96 +++++++++++++++++++++++= ++ > > > 1 file changed, 96 insertions(+) > > > create mode 100644 arch/arm/boot/dts/overlays/max98090.dts > > > > > > diff --git a/arch/arm/boot/dts/overlays/max98090.dts > > b/arch/arm/boot/dts/overlays/max98090.dts > > > new file mode 100644 > > > index 000000000000..eaf197384edb > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/overlays/max98090.dts > > > @@ -0,0 +1,96 @@ > > > +/* > > > + * Device Tree Overlay for MAX98090, MAX98091 Audio Codec. > > > + * https://github.com/Poojaa-Rangaiah/DeviceTreeOverlay-for-MAX98090 > > =3D> for more details. > > > + * MAX98090 audio codec as master and Raspberry Pi as slave. > > > + */ > > > + > > > +/dts-v1/; > > > +/plugin/; > > > + > > > +/ { > > > + compatible =3D "brcm,bcm2835", "brcm,bcm2711"; > > > + > > > + fragment@0 { > > > + target =3D <&i2s_clk_consumer>; > > > + __overlay__ { > > > + status =3D "okay"; > > > + }; > > > + }; > > > + > > > + fragment@1 { > > > + target =3D <&i2c1>; > > > + __overlay__ { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + status =3D "okay"; > > > + max98090_codec: max98090@10 { > > > + #sound-dai-cells =3D <0>; > > > + compatible =3D "maxim,max98090","maxim,max98091"; > > > + reg =3D <0x10>; > > > + interrupt-parent =3D <&gpio>; > > > + interrupts =3D <27 2>; /* GPIO 27 as Edge_Falling_IR= Q (2) > > */ > > > + maxim,micbias =3D <3>; > > > + status =3D "okay"; > > > + }; > > > + }; > > > + }; > > > + > > > + fragment@2 { > > > + target-path =3D "/"; > > > + __overlay__ { > > > + clk_oscillator: oscillator { > > > + compatible =3D "fixed-clock"; > > > + #clock-cells =3D <0>; > > > + clock-frequency =3D <12288000>; /* Frequency of the > > external oscillator (mclk =3D 12.288 MHz) but can also be 11.2896 MHz/12 > > MHz/13 MHz/26 MHz/19.2 MHz. */ > > > + clock-output-names =3D "mclk"; > > > + }; > > > + }; > > > + }; > > > + > > > + fragment@3 { > > > + target =3D <&sound>; > > > + sound_overlay: __overlay__ { > > > + compatible =3D "simple-audio-card"; > > > + simple-audio-card,format =3D "i2s"; > > > + simple-audio-card,name =3D "MAX98090-Codec"; > > > + simple-audio-card,bitclock-master =3D <&dailink0_master>; > > > + simple-audio-card,frame-master =3D <&dailink0_master>; > > > + > > > + simple-audio-card,widgets =3D > > > + "Microphone", "Mic Jack", > > > + "Speaker", "Speaker", > > > + "Line", "Line In", > > > + "Line", "Line Out", > > > + "Headphone", "Headphone Jack"; > > > + > > > + simple-audio-card,routing =3D > > > + "Headphone Jack", "HPL", > > > + "Headphone Jack", "HPR", > > > + "Line Out", "RCVL", > > > + "Line Out", "RCVR", > > > + /* Uncomment any of these below lines if the Line > > Input(s) is(are) used else leave it as such. */ > > > + //"IN5", "Line In", /* IN1/IN2/IN3/IN4/IN6 (For sin= gle > > ended input) */ > > > + //"IN56", "Line In", /* IN34 (For differential input= s) > > */ > > > + "MIC1", "Mic Jack", > > > + "MIC2", "Mic Jack", > > > + "Speaker", "SPKL", > > > + "Speaker", "SPKR"; > > > + > > > + status =3D "okay"; > > > + > > > + simple-audio-card,cpu { > > > + sound-dai =3D <&i2s_clk_consumer>; > > > + }; > > > + > > > + dailink0_master: simple-audio-card,codec { > > > + sound-dai =3D <&max98090_codec>; > > > + clocks =3D <&clk_oscillator>; > > > + }; > > > + }; > > > + }; > > > + > > > + __overrides__ { > > > + card-name =3D <&sound_overlay>, "simple-audio-card,name"; > > > + }; > > > +}; > > > + > > > -- > > > 2.34.1 > > > > > > > > --kF7nJA3fJHxMxL+t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ2L0EwAKCRB4tDGHoIJi 0kzbAP9NQ7Zxwm3/TRZ9eJC8KQh9P4w5QbW4D1siOYZGtoB+ZgEA0WOJLXLQbxef eMN8fHJnGZK2wJLjsoDxIa738iunbAc= =W6ua -----END PGP SIGNATURE----- --kF7nJA3fJHxMxL+t--